fix: order reasoning before reply text
This commit is contained in:
@@ -43,6 +43,8 @@
|
|||||||
- iMessage: ignore disconnect errors during shutdown (avoid unhandled promise rejections). Thanks @antons for PR #359.
|
- iMessage: ignore disconnect errors during shutdown (avoid unhandled promise rejections). Thanks @antons for PR #359.
|
||||||
- Messages: stop defaulting ack reactions to 👀 when identity emoji is missing.
|
- Messages: stop defaulting ack reactions to 👀 when identity emoji is missing.
|
||||||
- Auto-reply: require slash for control commands to avoid false triggers in normal text.
|
- Auto-reply: require slash for control commands to avoid false triggers in normal text.
|
||||||
|
- Auto-reply: add `/reasoning on|off` to expose model reasoning blocks (italic).
|
||||||
|
- Auto-reply: place reasoning blocks before the final reply text when appended.
|
||||||
- Auto-reply: flag error payloads and improve Bun socket error messaging. Thanks @emanuelst for PR #331.
|
- Auto-reply: flag error payloads and improve Bun socket error messaging. Thanks @emanuelst for PR #331.
|
||||||
- Commands: add `/stop` to the registry and route native aborts to the active chat session. Thanks @nachoiacovino for PR #295.
|
- Commands: add `/stop` to the registry and route native aborts to the active chat session. Thanks @nachoiacovino for PR #295.
|
||||||
- Commands: unify native + text chat commands behind `commands.*` config (Discord/Slack/Telegram). Thanks @thewilloftheshadow for PR #275.
|
- Commands: unify native + text chat commands behind `commands.*` config (Discord/Slack/Telegram). Thanks @thewilloftheshadow for PR #275.
|
||||||
|
|||||||
@@ -1102,7 +1102,7 @@ export async function runEmbeddedPiAgent(params: {
|
|||||||
? formatReasoningMarkdown(thinking)
|
? formatReasoningMarkdown(thinking)
|
||||||
: "";
|
: "";
|
||||||
if (!formatted) return base;
|
if (!formatted) return base;
|
||||||
return base ? `${base}\n\n${formatted}` : formatted;
|
return base ? `${formatted}\n\n${base}` : formatted;
|
||||||
})()
|
})()
|
||||||
: "";
|
: "";
|
||||||
for (const text of assistantTexts.length
|
for (const text of assistantTexts.length
|
||||||
|
|||||||
@@ -129,6 +129,42 @@ describe("subscribeEmbeddedPiSession", () => {
|
|||||||
expect(payload.text).toBe("Hello block");
|
expect(payload.text).toBe("Hello block");
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("prepends reasoning before text when enabled", () => {
|
||||||
|
let handler: ((evt: unknown) => void) | undefined;
|
||||||
|
const session: StubSession = {
|
||||||
|
subscribe: (fn) => {
|
||||||
|
handler = fn;
|
||||||
|
return () => {};
|
||||||
|
},
|
||||||
|
};
|
||||||
|
|
||||||
|
const onBlockReply = vi.fn();
|
||||||
|
|
||||||
|
subscribeEmbeddedPiSession({
|
||||||
|
session: session as unknown as Parameters<
|
||||||
|
typeof subscribeEmbeddedPiSession
|
||||||
|
>[0]["session"],
|
||||||
|
runId: "run",
|
||||||
|
onBlockReply,
|
||||||
|
blockReplyBreak: "message_end",
|
||||||
|
includeReasoning: true,
|
||||||
|
});
|
||||||
|
|
||||||
|
const assistantMessage = {
|
||||||
|
role: "assistant",
|
||||||
|
content: [
|
||||||
|
{ type: "thinking", thinking: "Because it helps" },
|
||||||
|
{ type: "text", text: "Final answer" },
|
||||||
|
],
|
||||||
|
} as AssistantMessage;
|
||||||
|
|
||||||
|
handler?.({ type: "message_end", message: assistantMessage });
|
||||||
|
|
||||||
|
expect(onBlockReply).toHaveBeenCalledTimes(1);
|
||||||
|
const payload = onBlockReply.mock.calls[0][0];
|
||||||
|
expect(payload.text).toBe("_Reasoning:_\n_Because it helps_\n\nFinal answer");
|
||||||
|
});
|
||||||
|
|
||||||
it("emits block replies on text_end and does not duplicate on message_end", () => {
|
it("emits block replies on text_end and does not duplicate on message_end", () => {
|
||||||
let handler: ((evt: unknown) => void) | undefined;
|
let handler: ((evt: unknown) => void) | undefined;
|
||||||
const session: StubSession = {
|
const session: StubSession = {
|
||||||
|
|||||||
@@ -511,8 +511,8 @@ export function subscribeEmbeddedPiSession(params: {
|
|||||||
: "";
|
: "";
|
||||||
const text =
|
const text =
|
||||||
baseText && formattedReasoning
|
baseText && formattedReasoning
|
||||||
? `${baseText}\n\n${formattedReasoning}`
|
? `${formattedReasoning}\n\n${baseText}`
|
||||||
: baseText || formattedReasoning;
|
: formattedReasoning || baseText;
|
||||||
|
|
||||||
const addedDuringMessage =
|
const addedDuringMessage =
|
||||||
assistantTexts.length > assistantTextBaseline;
|
assistantTexts.length > assistantTextBaseline;
|
||||||
|
|||||||
Reference in New Issue
Block a user