let5see/clawdbot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test: isolate exec allowlist env

Browse Source
This commit is contained in:
Peter Steinberger
2026-01-22 08:58:55 +00:00
parent 0e17e55be9
commit 0824bc0236
1 changed files with 39 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/agents/bash-tools.exec.approval-id.test.ts
View File

@@ -80,14 +80,10 @@ describe("exec approvals", () => {
if (process.platform !== "win32") { if (process.platform !== "win32") {
await fs.chmod(exePath, 0o755); await fs.chmod(exePath, 0o755);
} }
const prevPath = process.env.PATH; const execEnv: Record<string, string> = { PATH: binDir };
const prevPathExt = process.env.PATHEXT;
process.env.PATH = binDir;
if (process.platform === "win32") { if (process.platform === "win32") {
process.env.PATHEXT = ".CMD"; execEnv.PATHEXT = ".CMD";
} }
try {
const approvalsFile = { const approvalsFile = {
version: 1, version: 1,
defaults: { security: "allowlist", ask: "on-miss", askFallback: "deny" }, defaults: { security: "allowlist", ask: "on-miss", askFallback: "deny" },
@@ -120,18 +116,13 @@ describe("exec approvals", () => {
approvalRunningNoticeMs: 0, approvalRunningNoticeMs: 0,
}); });
const result = await tool.execute("call2", { command: `${exeName} --help` }); const result = await tool.execute("call2", {
command: `${exeName} --help`,
env: execEnv,
});
expect(result.details.status).toBe("completed"); expect(result.details.status).toBe("completed");
expect(calls).toContain("exec.approvals.node.get"); expect(calls).toContain("exec.approvals.node.get");
expect(calls).toContain("node.invoke"); expect(calls).toContain("node.invoke");
expect(calls).not.toContain("exec.approval.request"); expect(calls).not.toContain("exec.approval.request");
} finally {
process.env.PATH = prevPath;
if (prevPathExt === undefined) {
delete process.env.PATHEXT;
} else {
process.env.PATHEXT = prevPathExt;
}
}
}); });
}); });