refactor: centralize outbound policy + target schema
This commit is contained in:
@@ -1,4 +1,8 @@
|
|||||||
import { Type } from "@sinclair/typebox";
|
import { Type } from "@sinclair/typebox";
|
||||||
|
import {
|
||||||
|
CHANNEL_TARGET_DESCRIPTION,
|
||||||
|
CHANNEL_TARGETS_DESCRIPTION,
|
||||||
|
} from "../../infra/outbound/channel-target.js";
|
||||||
|
|
||||||
type StringEnumOptions<T extends readonly string[]> = {
|
type StringEnumOptions<T extends readonly string[]> = {
|
||||||
description?: string;
|
description?: string;
|
||||||
@@ -25,3 +29,13 @@ export function optionalStringEnum<T extends readonly string[]>(
|
|||||||
) {
|
) {
|
||||||
return Type.Optional(stringEnum(values, options));
|
return Type.Optional(stringEnum(values, options));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
export function channelTargetSchema(options?: { description?: string }) {
|
||||||
|
return Type.String({
|
||||||
|
description: options?.description ?? CHANNEL_TARGET_DESCRIPTION,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
export function channelTargetsSchema(options?: { description?: string }) {
|
||||||
|
return Type.Array(channelTargetSchema({ description: options?.description ?? CHANNEL_TARGETS_DESCRIPTION }));
|
||||||
|
}
|
||||||
|
|||||||
@@ -17,7 +17,7 @@ import { GATEWAY_CLIENT_IDS, GATEWAY_CLIENT_MODES } from "../../gateway/protocol
|
|||||||
import { runMessageAction } from "../../infra/outbound/message-action-runner.js";
|
import { runMessageAction } from "../../infra/outbound/message-action-runner.js";
|
||||||
import { resolveSessionAgentId } from "../agent-scope.js";
|
import { resolveSessionAgentId } from "../agent-scope.js";
|
||||||
import { normalizeAccountId } from "../../routing/session-key.js";
|
import { normalizeAccountId } from "../../routing/session-key.js";
|
||||||
import { stringEnum } from "../schema/typebox.js";
|
import { channelTargetSchema, channelTargetsSchema, stringEnum } from "../schema/typebox.js";
|
||||||
import type { AnyAgentTool } from "./common.js";
|
import type { AnyAgentTool } from "./common.js";
|
||||||
import { jsonResult, readNumberParam, readStringParam } from "./common.js";
|
import { jsonResult, readNumberParam, readStringParam } from "./common.js";
|
||||||
|
|
||||||
@@ -25,8 +25,8 @@ const AllMessageActions = CHANNEL_MESSAGE_ACTION_NAMES;
|
|||||||
|
|
||||||
const MessageToolCommonSchema = {
|
const MessageToolCommonSchema = {
|
||||||
channel: Type.Optional(Type.String()),
|
channel: Type.Optional(Type.String()),
|
||||||
to: Type.Optional(Type.String()),
|
to: Type.Optional(channelTargetSchema()),
|
||||||
targets: Type.Optional(Type.Array(Type.String())),
|
targets: Type.Optional(channelTargetsSchema()),
|
||||||
message: Type.Optional(Type.String()),
|
message: Type.Optional(Type.String()),
|
||||||
media: Type.Optional(Type.String()),
|
media: Type.Optional(Type.String()),
|
||||||
buttons: Type.Optional(
|
buttons: Type.Optional(
|
||||||
@@ -59,8 +59,8 @@ const MessageToolCommonSchema = {
|
|||||||
pollOption: Type.Optional(Type.Array(Type.String())),
|
pollOption: Type.Optional(Type.Array(Type.String())),
|
||||||
pollDurationHours: Type.Optional(Type.Number()),
|
pollDurationHours: Type.Optional(Type.Number()),
|
||||||
pollMulti: Type.Optional(Type.Boolean()),
|
pollMulti: Type.Optional(Type.Boolean()),
|
||||||
channelId: Type.Optional(Type.String()),
|
channelId: Type.Optional(channelTargetSchema()),
|
||||||
channelIds: Type.Optional(Type.Array(Type.String())),
|
channelIds: Type.Optional(channelTargetsSchema()),
|
||||||
guildId: Type.Optional(Type.String()),
|
guildId: Type.Optional(Type.String()),
|
||||||
userId: Type.Optional(Type.String()),
|
userId: Type.Optional(Type.String()),
|
||||||
authorId: Type.Optional(Type.String()),
|
authorId: Type.Optional(Type.String()),
|
||||||
|
|||||||
@@ -1,6 +1,7 @@
|
|||||||
import type { Command } from "commander";
|
import type { Command } from "commander";
|
||||||
import { messageCommand } from "../../../commands/message.js";
|
import { messageCommand } from "../../../commands/message.js";
|
||||||
import { danger, setVerbose } from "../../../globals.js";
|
import { danger, setVerbose } from "../../../globals.js";
|
||||||
|
import { CHANNEL_TARGET_DESCRIPTION } from "../../../infra/outbound/channel-target.js";
|
||||||
import { defaultRuntime } from "../../../runtime.js";
|
import { defaultRuntime } from "../../../runtime.js";
|
||||||
import { createDefaultDeps } from "../../deps.js";
|
import { createDefaultDeps } from "../../deps.js";
|
||||||
|
|
||||||
@@ -26,12 +27,12 @@ export function createMessageCliHelpers(
|
|||||||
const withMessageTarget = (command: Command) =>
|
const withMessageTarget = (command: Command) =>
|
||||||
command.option(
|
command.option(
|
||||||
"-t, --to <dest>",
|
"-t, --to <dest>",
|
||||||
"Recipient/channel: E.164 for WhatsApp/Signal, Telegram chat id/@username, Discord/Slack channel/user, or iMessage handle/chat_id",
|
CHANNEL_TARGET_DESCRIPTION,
|
||||||
);
|
);
|
||||||
const withRequiredMessageTarget = (command: Command) =>
|
const withRequiredMessageTarget = (command: Command) =>
|
||||||
command.requiredOption(
|
command.requiredOption(
|
||||||
"-t, --to <dest>",
|
"-t, --to <dest>",
|
||||||
"Recipient/channel: E.164 for WhatsApp/Signal, Telegram chat id/@username, Discord/Slack channel/user, or iMessage handle/chat_id",
|
CHANNEL_TARGET_DESCRIPTION,
|
||||||
);
|
);
|
||||||
|
|
||||||
const runMessageAction = async (action: string, opts: Record<string, unknown>) => {
|
const runMessageAction = async (action: string, opts: Record<string, unknown>) => {
|
||||||
|
|||||||
@@ -1,4 +1,5 @@
|
|||||||
import type { Command } from "commander";
|
import type { Command } from "commander";
|
||||||
|
import { CHANNEL_TARGETS_DESCRIPTION } from "../../../infra/outbound/channel-target.js";
|
||||||
import type { MessageCliHelpers } from "./helpers.js";
|
import type { MessageCliHelpers } from "./helpers.js";
|
||||||
|
|
||||||
export function registerMessageBroadcastCommand(message: Command, helpers: MessageCliHelpers) {
|
export function registerMessageBroadcastCommand(message: Command, helpers: MessageCliHelpers) {
|
||||||
@@ -8,7 +9,7 @@ export function registerMessageBroadcastCommand(message: Command, helpers: Messa
|
|||||||
)
|
)
|
||||||
.requiredOption(
|
.requiredOption(
|
||||||
"--targets <target...>",
|
"--targets <target...>",
|
||||||
"Targets to broadcast to (repeatable, accepts names or ids)",
|
CHANNEL_TARGETS_DESCRIPTION,
|
||||||
)
|
)
|
||||||
.option("--message <text>", "Message to send")
|
.option("--message <text>", "Message to send")
|
||||||
.option("--media <url>", "Media URL")
|
.option("--media <url>", "Media URL")
|
||||||
|
|||||||
24
src/infra/outbound/channel-adapters.ts
Normal file
24
src/infra/outbound/channel-adapters.ts
Normal file
@@ -0,0 +1,24 @@
|
|||||||
|
import type { ChannelId } from "../../channels/plugins/types.js";
|
||||||
|
|
||||||
|
export type ChannelMessageAdapter = {
|
||||||
|
supportsEmbeds: boolean;
|
||||||
|
buildCrossContextEmbeds?: (originLabel: string) => unknown[];
|
||||||
|
};
|
||||||
|
|
||||||
|
const DEFAULT_ADAPTER: ChannelMessageAdapter = {
|
||||||
|
supportsEmbeds: false,
|
||||||
|
};
|
||||||
|
|
||||||
|
const DISCORD_ADAPTER: ChannelMessageAdapter = {
|
||||||
|
supportsEmbeds: true,
|
||||||
|
buildCrossContextEmbeds: (originLabel: string) => [
|
||||||
|
{
|
||||||
|
description: `From ${originLabel}`,
|
||||||
|
},
|
||||||
|
],
|
||||||
|
};
|
||||||
|
|
||||||
|
export function getChannelMessageAdapter(channel: ChannelId): ChannelMessageAdapter {
|
||||||
|
if (channel === "discord") return DISCORD_ADAPTER;
|
||||||
|
return DEFAULT_ADAPTER;
|
||||||
|
}
|
||||||
9
src/infra/outbound/channel-target.ts
Normal file
9
src/infra/outbound/channel-target.ts
Normal file
@@ -0,0 +1,9 @@
|
|||||||
|
export const CHANNEL_TARGET_DESCRIPTION =
|
||||||
|
"Recipient/channel: E.164 for WhatsApp/Signal, Telegram chat id/@username, Discord/Slack channel/user, or iMessage handle/chat_id";
|
||||||
|
|
||||||
|
export const CHANNEL_TARGETS_DESCRIPTION =
|
||||||
|
"Recipient/channel targets (same format as --to); accepts ids or names when the directory is available.";
|
||||||
|
|
||||||
|
export function normalizeChannelTargetInput(raw: string): string {
|
||||||
|
return raw.trim();
|
||||||
|
}
|
||||||
53
src/infra/outbound/directory-cache.ts
Normal file
53
src/infra/outbound/directory-cache.ts
Normal file
@@ -0,0 +1,53 @@
|
|||||||
|
import type { ChannelDirectoryEntryKind, ChannelId } from "../../channels/plugins/types.js";
|
||||||
|
import type { ClawdbotConfig } from "../../config/config.js";
|
||||||
|
|
||||||
|
type CacheEntry<T> = {
|
||||||
|
value: T;
|
||||||
|
fetchedAt: number;
|
||||||
|
};
|
||||||
|
|
||||||
|
export type DirectoryCacheKey = {
|
||||||
|
channel: ChannelId;
|
||||||
|
accountId?: string | null;
|
||||||
|
kind: ChannelDirectoryEntryKind;
|
||||||
|
source: "cache" | "live";
|
||||||
|
};
|
||||||
|
|
||||||
|
export function buildDirectoryCacheKey(key: DirectoryCacheKey): string {
|
||||||
|
return `${key.channel}:${key.accountId ?? "default"}:${key.kind}:${key.source}`;
|
||||||
|
}
|
||||||
|
|
||||||
|
export class DirectoryCache<T> {
|
||||||
|
private readonly cache = new Map<string, CacheEntry<T>>();
|
||||||
|
private lastConfigRef: ClawdbotConfig | null = null;
|
||||||
|
|
||||||
|
constructor(private readonly ttlMs: number) {}
|
||||||
|
|
||||||
|
get(key: string, cfg: ClawdbotConfig): T | undefined {
|
||||||
|
this.resetIfConfigChanged(cfg);
|
||||||
|
const entry = this.cache.get(key);
|
||||||
|
if (!entry) return undefined;
|
||||||
|
if (Date.now() - entry.fetchedAt > this.ttlMs) {
|
||||||
|
this.cache.delete(key);
|
||||||
|
return undefined;
|
||||||
|
}
|
||||||
|
return entry.value;
|
||||||
|
}
|
||||||
|
|
||||||
|
set(key: string, value: T, cfg: ClawdbotConfig): void {
|
||||||
|
this.resetIfConfigChanged(cfg);
|
||||||
|
this.cache.set(key, { value, fetchedAt: Date.now() });
|
||||||
|
}
|
||||||
|
|
||||||
|
clear(cfg?: ClawdbotConfig): void {
|
||||||
|
this.cache.clear();
|
||||||
|
if (cfg) this.lastConfigRef = cfg;
|
||||||
|
}
|
||||||
|
|
||||||
|
private resetIfConfigChanged(cfg: ClawdbotConfig): void {
|
||||||
|
if (this.lastConfigRef && this.lastConfigRef !== cfg) {
|
||||||
|
this.cache.clear();
|
||||||
|
}
|
||||||
|
this.lastConfigRef = cfg;
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -1,5 +1,4 @@
|
|||||||
import type { AgentToolResult } from "@mariozechner/pi-agent-core";
|
import type { AgentToolResult } from "@mariozechner/pi-agent-core";
|
||||||
import { normalizeTargetForProvider } from "../../agents/pi-embedded-messaging.js";
|
|
||||||
import {
|
import {
|
||||||
readNumberParam,
|
readNumberParam,
|
||||||
readStringArrayParam,
|
readStringArrayParam,
|
||||||
@@ -18,7 +17,13 @@ import { listConfiguredMessageChannels, resolveMessageChannelSelection } from ".
|
|||||||
import type { OutboundSendDeps } from "./deliver.js";
|
import type { OutboundSendDeps } from "./deliver.js";
|
||||||
import type { MessagePollResult, MessageSendResult } from "./message.js";
|
import type { MessagePollResult, MessageSendResult } from "./message.js";
|
||||||
import { sendMessage, sendPoll } from "./message.js";
|
import { sendMessage, sendPoll } from "./message.js";
|
||||||
import { lookupDirectoryDisplay, resolveMessagingTarget } from "./target-resolver.js";
|
import {
|
||||||
|
applyCrossContextDecoration,
|
||||||
|
buildCrossContextDecoration,
|
||||||
|
enforceCrossContextPolicy,
|
||||||
|
shouldApplyCrossContextMarker,
|
||||||
|
} from "./outbound-policy.js";
|
||||||
|
import { resolveMessagingTarget } from "./target-resolver.js";
|
||||||
|
|
||||||
export type MessageActionRunnerGateway = {
|
export type MessageActionRunnerGateway = {
|
||||||
url?: string;
|
url?: string;
|
||||||
@@ -139,72 +144,6 @@ function parseButtonsParam(params: Record<string, unknown>): void {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
const CONTEXT_GUARDED_ACTIONS = new Set<ChannelMessageActionName>([
|
|
||||||
"send",
|
|
||||||
"poll",
|
|
||||||
"thread-create",
|
|
||||||
"thread-reply",
|
|
||||||
"sticker",
|
|
||||||
]);
|
|
||||||
|
|
||||||
function resolveContextGuardTarget(
|
|
||||||
action: ChannelMessageActionName,
|
|
||||||
params: Record<string, unknown>,
|
|
||||||
): string | undefined {
|
|
||||||
if (!CONTEXT_GUARDED_ACTIONS.has(action)) return undefined;
|
|
||||||
|
|
||||||
if (action === "thread-reply" || action === "thread-create") {
|
|
||||||
return readStringParam(params, "channelId") ?? readStringParam(params, "to");
|
|
||||||
}
|
|
||||||
|
|
||||||
return readStringParam(params, "to") ?? readStringParam(params, "channelId");
|
|
||||||
}
|
|
||||||
|
|
||||||
function enforceContextIsolation(params: {
|
|
||||||
channel: ChannelId;
|
|
||||||
action: ChannelMessageActionName;
|
|
||||||
params: Record<string, unknown>;
|
|
||||||
toolContext?: ChannelThreadingToolContext;
|
|
||||||
cfg: ClawdbotConfig;
|
|
||||||
}): void {
|
|
||||||
const currentTarget = params.toolContext?.currentChannelId?.trim();
|
|
||||||
if (!currentTarget) return;
|
|
||||||
if (!CONTEXT_GUARDED_ACTIONS.has(params.action)) return;
|
|
||||||
|
|
||||||
if (params.cfg.tools?.message?.allowCrossContextSend) return;
|
|
||||||
|
|
||||||
const currentProvider = params.toolContext?.currentChannelProvider;
|
|
||||||
const allowWithinProvider = params.cfg.tools?.message?.crossContext?.allowWithinProvider !== false;
|
|
||||||
const allowAcrossProviders =
|
|
||||||
params.cfg.tools?.message?.crossContext?.allowAcrossProviders === true;
|
|
||||||
|
|
||||||
if (currentProvider && currentProvider !== params.channel) {
|
|
||||||
if (!allowAcrossProviders) {
|
|
||||||
throw new Error(
|
|
||||||
`Cross-context messaging denied: action=${params.action} target provider "${params.channel}" while bound to "${currentProvider}".`,
|
|
||||||
);
|
|
||||||
}
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (allowWithinProvider) return;
|
|
||||||
|
|
||||||
const target = resolveContextGuardTarget(params.action, params.params);
|
|
||||||
if (!target) return;
|
|
||||||
|
|
||||||
const normalizedTarget =
|
|
||||||
normalizeTargetForProvider(params.channel, target) ?? target.toLowerCase();
|
|
||||||
const normalizedCurrent =
|
|
||||||
normalizeTargetForProvider(params.channel, currentTarget) ?? currentTarget.toLowerCase();
|
|
||||||
|
|
||||||
if (!normalizedTarget || !normalizedCurrent) return;
|
|
||||||
if (normalizedTarget === normalizedCurrent) return;
|
|
||||||
|
|
||||||
throw new Error(
|
|
||||||
`Cross-context messaging denied: action=${params.action} target="${target}" while bound to "${currentTarget}" (channel=${params.channel}).`,
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
async function resolveChannel(cfg: ClawdbotConfig, params: Record<string, unknown>) {
|
async function resolveChannel(cfg: ClawdbotConfig, params: Record<string, unknown>) {
|
||||||
const channelHint = readStringParam(params, "channel");
|
const channelHint = readStringParam(params, "channel");
|
||||||
const selection = await resolveMessageChannelSelection({
|
const selection = await resolveMessageChannelSelection({
|
||||||
@@ -214,57 +153,6 @@ async function resolveChannel(cfg: ClawdbotConfig, params: Record<string, unknow
|
|||||||
return selection.channel;
|
return selection.channel;
|
||||||
}
|
}
|
||||||
|
|
||||||
function shouldApplyCrossContextMarker(action: ChannelMessageActionName): boolean {
|
|
||||||
return action === "send" || action === "poll" || action === "thread-reply" || action === "sticker";
|
|
||||||
}
|
|
||||||
|
|
||||||
async function buildCrossContextMarker(params: {
|
|
||||||
cfg: ClawdbotConfig;
|
|
||||||
channel: ChannelId;
|
|
||||||
target: string;
|
|
||||||
toolContext?: ChannelThreadingToolContext;
|
|
||||||
accountId?: string | null;
|
|
||||||
}) {
|
|
||||||
const currentTarget = params.toolContext?.currentChannelId?.trim();
|
|
||||||
if (!currentTarget) return null;
|
|
||||||
const normalizedTarget =
|
|
||||||
normalizeTargetForProvider(params.channel, params.target) ?? params.target.toLowerCase();
|
|
||||||
const normalizedCurrent =
|
|
||||||
normalizeTargetForProvider(params.channel, currentTarget) ?? currentTarget.toLowerCase();
|
|
||||||
if (!normalizedTarget || !normalizedCurrent) return null;
|
|
||||||
if (normalizedTarget === normalizedCurrent) return null;
|
|
||||||
|
|
||||||
const markerEnabled = params.cfg.tools?.message?.crossContext?.marker?.enabled !== false;
|
|
||||||
if (!markerEnabled) return null;
|
|
||||||
|
|
||||||
const currentName =
|
|
||||||
(await lookupDirectoryDisplay({
|
|
||||||
cfg: params.cfg,
|
|
||||||
channel: params.channel,
|
|
||||||
targetId: currentTarget,
|
|
||||||
accountId: params.accountId ?? undefined,
|
|
||||||
})) ?? currentTarget;
|
|
||||||
const originLabel = currentName.startsWith("#") ? currentName : `#${currentName}`;
|
|
||||||
const markerConfig = params.cfg.tools?.message?.crossContext?.marker;
|
|
||||||
const prefixTemplate = markerConfig?.prefix ?? "[from {channel}] ";
|
|
||||||
const suffixTemplate = markerConfig?.suffix ?? "";
|
|
||||||
const prefix = prefixTemplate.replaceAll("{channel}", originLabel);
|
|
||||||
const suffix = suffixTemplate.replaceAll("{channel}", originLabel);
|
|
||||||
const discordEmbeds =
|
|
||||||
params.channel === "discord"
|
|
||||||
? [
|
|
||||||
{
|
|
||||||
description: `From ${originLabel}`,
|
|
||||||
},
|
|
||||||
]
|
|
||||||
: undefined;
|
|
||||||
return {
|
|
||||||
prefix,
|
|
||||||
suffix,
|
|
||||||
discordEmbeds,
|
|
||||||
};
|
|
||||||
}
|
|
||||||
|
|
||||||
async function resolveActionTarget(params: {
|
async function resolveActionTarget(params: {
|
||||||
cfg: ClawdbotConfig;
|
cfg: ClawdbotConfig;
|
||||||
channel: ChannelId;
|
channel: ChannelId;
|
||||||
@@ -396,10 +284,10 @@ export async function runMessageAction(
|
|||||||
accountId,
|
accountId,
|
||||||
});
|
});
|
||||||
|
|
||||||
enforceContextIsolation({
|
enforceCrossContextPolicy({
|
||||||
channel,
|
channel,
|
||||||
action,
|
action,
|
||||||
params,
|
args: params,
|
||||||
toolContext: input.toolContext,
|
toolContext: input.toolContext,
|
||||||
cfg,
|
cfg,
|
||||||
});
|
});
|
||||||
@@ -433,9 +321,9 @@ export async function runMessageAction(
|
|||||||
params.media = parsed.mediaUrls?.[0] || parsed.mediaUrl || undefined;
|
params.media = parsed.mediaUrls?.[0] || parsed.mediaUrl || undefined;
|
||||||
}
|
}
|
||||||
|
|
||||||
const marker =
|
const decoration =
|
||||||
shouldApplyCrossContextMarker(action) && input.toolContext
|
shouldApplyCrossContextMarker(action) && input.toolContext
|
||||||
? await buildCrossContextMarker({
|
? await buildCrossContextDecoration({
|
||||||
cfg,
|
cfg,
|
||||||
channel,
|
channel,
|
||||||
target: to,
|
target: to,
|
||||||
@@ -443,20 +331,22 @@ export async function runMessageAction(
|
|||||||
accountId: accountId ?? undefined,
|
accountId: accountId ?? undefined,
|
||||||
})
|
})
|
||||||
: null;
|
: null;
|
||||||
const useTextMarker = !(channel === "discord" && marker?.discordEmbeds?.length);
|
if (decoration) {
|
||||||
if (useTextMarker && (marker?.prefix || marker?.suffix)) {
|
const applied = applyCrossContextDecoration({
|
||||||
const merged = `${marker?.prefix ?? ""}${message}${marker?.suffix ?? ""}`;
|
message,
|
||||||
params.message = merged;
|
decoration,
|
||||||
message = merged;
|
preferEmbeds: true,
|
||||||
|
});
|
||||||
|
message = applied.message;
|
||||||
|
params.message = applied.message;
|
||||||
|
if (applied.embeds?.length) {
|
||||||
|
params.embeds = applied.embeds;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
const mediaUrl = readStringParam(params, "media", { trim: false });
|
const mediaUrl = readStringParam(params, "media", { trim: false });
|
||||||
const gifPlayback = readBooleanParam(params, "gifPlayback") ?? false;
|
const gifPlayback = readBooleanParam(params, "gifPlayback") ?? false;
|
||||||
const bestEffort = readBooleanParam(params, "bestEffort");
|
const bestEffort = readBooleanParam(params, "bestEffort");
|
||||||
if (marker?.discordEmbeds && channel === "discord") {
|
|
||||||
params.embeds = marker.discordEmbeds;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (!dryRun) {
|
if (!dryRun) {
|
||||||
const handled = await dispatchChannelMessageAction({
|
const handled = await dispatchChannelMessageAction({
|
||||||
channel,
|
channel,
|
||||||
@@ -529,9 +419,9 @@ export async function runMessageAction(
|
|||||||
integer: true,
|
integer: true,
|
||||||
});
|
});
|
||||||
const maxSelections = allowMultiselect ? Math.max(2, options.length) : 1;
|
const maxSelections = allowMultiselect ? Math.max(2, options.length) : 1;
|
||||||
const marker =
|
const decoration =
|
||||||
shouldApplyCrossContextMarker(action) && input.toolContext
|
shouldApplyCrossContextMarker(action) && input.toolContext
|
||||||
? await buildCrossContextMarker({
|
? await buildCrossContextDecoration({
|
||||||
cfg,
|
cfg,
|
||||||
channel,
|
channel,
|
||||||
target: to,
|
target: to,
|
||||||
@@ -539,12 +429,17 @@ export async function runMessageAction(
|
|||||||
accountId: accountId ?? undefined,
|
accountId: accountId ?? undefined,
|
||||||
})
|
})
|
||||||
: null;
|
: null;
|
||||||
if (marker?.prefix || marker?.suffix) {
|
if (decoration) {
|
||||||
const base = typeof params.message === "string" ? params.message : "";
|
const base = typeof params.message === "string" ? params.message : "";
|
||||||
params.message = `${marker?.prefix ?? ""}${base}${marker?.suffix ?? ""}`;
|
const applied = applyCrossContextDecoration({
|
||||||
|
message: base,
|
||||||
|
decoration,
|
||||||
|
preferEmbeds: true,
|
||||||
|
});
|
||||||
|
params.message = applied.message;
|
||||||
|
if (applied.embeds?.length) {
|
||||||
|
params.embeds = applied.embeds;
|
||||||
}
|
}
|
||||||
if (marker?.discordEmbeds && channel === "discord") {
|
|
||||||
params.embeds = marker.discordEmbeds;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
if (!dryRun) {
|
if (!dryRun) {
|
||||||
|
|||||||
156
src/infra/outbound/outbound-policy.ts
Normal file
156
src/infra/outbound/outbound-policy.ts
Normal file
@@ -0,0 +1,156 @@
|
|||||||
|
import { normalizeTargetForProvider } from "../../agents/pi-embedded-messaging.js";
|
||||||
|
import type {
|
||||||
|
ChannelId,
|
||||||
|
ChannelMessageActionName,
|
||||||
|
ChannelThreadingToolContext,
|
||||||
|
} from "../../channels/plugins/types.js";
|
||||||
|
import type { ClawdbotConfig } from "../../config/config.js";
|
||||||
|
import { getChannelMessageAdapter } from "./channel-adapters.js";
|
||||||
|
import { lookupDirectoryDisplay } from "./target-resolver.js";
|
||||||
|
|
||||||
|
export type CrossContextDecoration = {
|
||||||
|
prefix: string;
|
||||||
|
suffix: string;
|
||||||
|
embeds?: unknown[];
|
||||||
|
};
|
||||||
|
|
||||||
|
const CONTEXT_GUARDED_ACTIONS = new Set<ChannelMessageActionName>([
|
||||||
|
"send",
|
||||||
|
"poll",
|
||||||
|
"thread-create",
|
||||||
|
"thread-reply",
|
||||||
|
"sticker",
|
||||||
|
]);
|
||||||
|
|
||||||
|
const CONTEXT_MARKER_ACTIONS = new Set<ChannelMessageActionName>([
|
||||||
|
"send",
|
||||||
|
"poll",
|
||||||
|
"thread-reply",
|
||||||
|
"sticker",
|
||||||
|
]);
|
||||||
|
|
||||||
|
function resolveContextGuardTarget(
|
||||||
|
action: ChannelMessageActionName,
|
||||||
|
params: Record<string, unknown>,
|
||||||
|
): string | undefined {
|
||||||
|
if (!CONTEXT_GUARDED_ACTIONS.has(action)) return undefined;
|
||||||
|
|
||||||
|
if (action === "thread-reply" || action === "thread-create") {
|
||||||
|
if (typeof params.channelId === "string") return params.channelId;
|
||||||
|
if (typeof params.to === "string") return params.to;
|
||||||
|
return undefined;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (typeof params.to === "string") return params.to;
|
||||||
|
if (typeof params.channelId === "string") return params.channelId;
|
||||||
|
return undefined;
|
||||||
|
}
|
||||||
|
|
||||||
|
function normalizeTarget(channel: ChannelId, raw: string): string | undefined {
|
||||||
|
return normalizeTargetForProvider(channel, raw) ?? raw.trim().toLowerCase();
|
||||||
|
}
|
||||||
|
|
||||||
|
function isCrossContextTarget(params: {
|
||||||
|
channel: ChannelId;
|
||||||
|
target: string;
|
||||||
|
toolContext?: ChannelThreadingToolContext;
|
||||||
|
}): boolean {
|
||||||
|
const currentTarget = params.toolContext?.currentChannelId?.trim();
|
||||||
|
if (!currentTarget) return false;
|
||||||
|
const normalizedTarget = normalizeTarget(params.channel, params.target);
|
||||||
|
const normalizedCurrent = normalizeTarget(params.channel, currentTarget);
|
||||||
|
if (!normalizedTarget || !normalizedCurrent) return false;
|
||||||
|
return normalizedTarget !== normalizedCurrent;
|
||||||
|
}
|
||||||
|
|
||||||
|
export function enforceCrossContextPolicy(params: {
|
||||||
|
channel: ChannelId;
|
||||||
|
action: ChannelMessageActionName;
|
||||||
|
args: Record<string, unknown>;
|
||||||
|
toolContext?: ChannelThreadingToolContext;
|
||||||
|
cfg: ClawdbotConfig;
|
||||||
|
}): void {
|
||||||
|
const currentTarget = params.toolContext?.currentChannelId?.trim();
|
||||||
|
if (!currentTarget) return;
|
||||||
|
if (!CONTEXT_GUARDED_ACTIONS.has(params.action)) return;
|
||||||
|
|
||||||
|
if (params.cfg.tools?.message?.allowCrossContextSend) return;
|
||||||
|
|
||||||
|
const currentProvider = params.toolContext?.currentChannelProvider;
|
||||||
|
const allowWithinProvider = params.cfg.tools?.message?.crossContext?.allowWithinProvider !== false;
|
||||||
|
const allowAcrossProviders =
|
||||||
|
params.cfg.tools?.message?.crossContext?.allowAcrossProviders === true;
|
||||||
|
|
||||||
|
if (currentProvider && currentProvider !== params.channel) {
|
||||||
|
if (!allowAcrossProviders) {
|
||||||
|
throw new Error(
|
||||||
|
`Cross-context messaging denied: action=${params.action} target provider "${params.channel}" while bound to "${currentProvider}".`,
|
||||||
|
);
|
||||||
|
}
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (allowWithinProvider) return;
|
||||||
|
|
||||||
|
const target = resolveContextGuardTarget(params.action, params.args);
|
||||||
|
if (!target) return;
|
||||||
|
|
||||||
|
if (!isCrossContextTarget({ channel: params.channel, target, toolContext: params.toolContext })) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
throw new Error(
|
||||||
|
`Cross-context messaging denied: action=${params.action} target="${target}" while bound to "${currentTarget}" (channel=${params.channel}).`,
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
export async function buildCrossContextDecoration(params: {
|
||||||
|
cfg: ClawdbotConfig;
|
||||||
|
channel: ChannelId;
|
||||||
|
target: string;
|
||||||
|
toolContext?: ChannelThreadingToolContext;
|
||||||
|
accountId?: string | null;
|
||||||
|
}): Promise<CrossContextDecoration | null> {
|
||||||
|
if (!params.toolContext?.currentChannelId) return null;
|
||||||
|
if (!isCrossContextTarget(params)) return null;
|
||||||
|
|
||||||
|
const markerConfig = params.cfg.tools?.message?.crossContext?.marker;
|
||||||
|
if (markerConfig?.enabled === false) return null;
|
||||||
|
|
||||||
|
const currentName =
|
||||||
|
(await lookupDirectoryDisplay({
|
||||||
|
cfg: params.cfg,
|
||||||
|
channel: params.channel,
|
||||||
|
targetId: params.toolContext.currentChannelId,
|
||||||
|
accountId: params.accountId ?? undefined,
|
||||||
|
})) ?? params.toolContext.currentChannelId;
|
||||||
|
const originLabel = currentName.startsWith("#") ? currentName : `#${currentName}`;
|
||||||
|
const prefixTemplate = markerConfig?.prefix ?? "[from {channel}] ";
|
||||||
|
const suffixTemplate = markerConfig?.suffix ?? "";
|
||||||
|
const prefix = prefixTemplate.replaceAll("{channel}", originLabel);
|
||||||
|
const suffix = suffixTemplate.replaceAll("{channel}", originLabel);
|
||||||
|
|
||||||
|
const adapter = getChannelMessageAdapter(params.channel);
|
||||||
|
const embeds = adapter.supportsEmbeds
|
||||||
|
? adapter.buildCrossContextEmbeds?.(originLabel) ?? undefined
|
||||||
|
: undefined;
|
||||||
|
|
||||||
|
return { prefix, suffix, embeds };
|
||||||
|
}
|
||||||
|
|
||||||
|
export function shouldApplyCrossContextMarker(action: ChannelMessageActionName): boolean {
|
||||||
|
return CONTEXT_MARKER_ACTIONS.has(action);
|
||||||
|
}
|
||||||
|
|
||||||
|
export function applyCrossContextDecoration(params: {
|
||||||
|
message: string;
|
||||||
|
decoration: CrossContextDecoration;
|
||||||
|
preferEmbeds: boolean;
|
||||||
|
}): { message: string; embeds?: unknown[]; usedEmbeds: boolean } {
|
||||||
|
const useEmbeds = params.preferEmbeds && params.decoration.embeds?.length;
|
||||||
|
if (useEmbeds) {
|
||||||
|
return { message: params.message, embeds: params.decoration.embeds, usedEmbeds: true };
|
||||||
|
}
|
||||||
|
const message = `${params.decoration.prefix}${params.message}${params.decoration.suffix}`;
|
||||||
|
return { message, usedEmbeds: false };
|
||||||
|
}
|
||||||
@@ -7,6 +7,8 @@ import type {
|
|||||||
} from "../../channels/plugins/types.js";
|
} from "../../channels/plugins/types.js";
|
||||||
import type { ClawdbotConfig } from "../../config/config.js";
|
import type { ClawdbotConfig } from "../../config/config.js";
|
||||||
import { defaultRuntime, type RuntimeEnv } from "../../runtime.js";
|
import { defaultRuntime, type RuntimeEnv } from "../../runtime.js";
|
||||||
|
import { normalizeChannelTargetInput } from "./channel-target.js";
|
||||||
|
import { buildDirectoryCacheKey, DirectoryCache } from "./directory-cache.js";
|
||||||
|
|
||||||
export type TargetResolveKind = ChannelDirectoryEntryKind | "channel";
|
export type TargetResolveKind = ChannelDirectoryEntryKind | "channel";
|
||||||
|
|
||||||
@@ -21,30 +23,8 @@ export type ResolveMessagingTargetResult =
|
|||||||
| { ok: true; target: ResolvedMessagingTarget }
|
| { ok: true; target: ResolvedMessagingTarget }
|
||||||
| { ok: false; error: Error; candidates?: ChannelDirectoryEntry[] };
|
| { ok: false; error: Error; candidates?: ChannelDirectoryEntry[] };
|
||||||
|
|
||||||
type DirectoryCacheEntry = {
|
|
||||||
entries: ChannelDirectoryEntry[];
|
|
||||||
fetchedAt: number;
|
|
||||||
};
|
|
||||||
|
|
||||||
const CACHE_TTL_MS = 30 * 60 * 1000;
|
const CACHE_TTL_MS = 30 * 60 * 1000;
|
||||||
const directoryCache = new Map<string, DirectoryCacheEntry>();
|
const directoryCache = new DirectoryCache<ChannelDirectoryEntry[]>(CACHE_TTL_MS);
|
||||||
let lastConfigRef: ClawdbotConfig | null = null;
|
|
||||||
|
|
||||||
function resetCacheIfConfigChanged(cfg: ClawdbotConfig): void {
|
|
||||||
if (lastConfigRef && lastConfigRef !== cfg) {
|
|
||||||
directoryCache.clear();
|
|
||||||
}
|
|
||||||
lastConfigRef = cfg;
|
|
||||||
}
|
|
||||||
|
|
||||||
function buildCacheKey(params: {
|
|
||||||
channel: ChannelId;
|
|
||||||
accountId?: string | null;
|
|
||||||
kind: ChannelDirectoryEntryKind;
|
|
||||||
source: "cache" | "live";
|
|
||||||
}) {
|
|
||||||
return `${params.channel}:${params.accountId ?? "default"}:${params.kind}:${params.source}`;
|
|
||||||
}
|
|
||||||
|
|
||||||
function normalizeQuery(value: string): string {
|
function normalizeQuery(value: string): string {
|
||||||
return value.trim().toLowerCase();
|
return value.trim().toLowerCase();
|
||||||
@@ -182,17 +162,14 @@ async function getDirectoryEntries(params: {
|
|||||||
runtime?: RuntimeEnv;
|
runtime?: RuntimeEnv;
|
||||||
preferLiveOnMiss?: boolean;
|
preferLiveOnMiss?: boolean;
|
||||||
}): Promise<ChannelDirectoryEntry[]> {
|
}): Promise<ChannelDirectoryEntry[]> {
|
||||||
resetCacheIfConfigChanged(params.cfg);
|
const cacheKey = buildDirectoryCacheKey({
|
||||||
const cacheKey = buildCacheKey({
|
|
||||||
channel: params.channel,
|
channel: params.channel,
|
||||||
accountId: params.accountId,
|
accountId: params.accountId,
|
||||||
kind: params.kind,
|
kind: params.kind,
|
||||||
source: "cache",
|
source: "cache",
|
||||||
});
|
});
|
||||||
const cached = directoryCache.get(cacheKey);
|
const cached = directoryCache.get(cacheKey, params.cfg);
|
||||||
if (cached && Date.now() - cached.fetchedAt < CACHE_TTL_MS) {
|
if (cached) return cached;
|
||||||
return cached.entries;
|
|
||||||
}
|
|
||||||
const entries = await listDirectoryEntries({
|
const entries = await listDirectoryEntries({
|
||||||
cfg: params.cfg,
|
cfg: params.cfg,
|
||||||
channel: params.channel,
|
channel: params.channel,
|
||||||
@@ -203,10 +180,10 @@ async function getDirectoryEntries(params: {
|
|||||||
source: "cache",
|
source: "cache",
|
||||||
});
|
});
|
||||||
if (entries.length > 0 || !params.preferLiveOnMiss) {
|
if (entries.length > 0 || !params.preferLiveOnMiss) {
|
||||||
directoryCache.set(cacheKey, { entries, fetchedAt: Date.now() });
|
directoryCache.set(cacheKey, entries, params.cfg);
|
||||||
return entries;
|
return entries;
|
||||||
}
|
}
|
||||||
const liveKey = buildCacheKey({
|
const liveKey = buildDirectoryCacheKey({
|
||||||
channel: params.channel,
|
channel: params.channel,
|
||||||
accountId: params.accountId,
|
accountId: params.accountId,
|
||||||
kind: params.kind,
|
kind: params.kind,
|
||||||
@@ -221,7 +198,7 @@ async function getDirectoryEntries(params: {
|
|||||||
runtime: params.runtime,
|
runtime: params.runtime,
|
||||||
source: "live",
|
source: "live",
|
||||||
});
|
});
|
||||||
directoryCache.set(liveKey, { entries: liveEntries, fetchedAt: Date.now() });
|
directoryCache.set(liveKey, liveEntries, params.cfg);
|
||||||
return liveEntries;
|
return liveEntries;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -233,7 +210,7 @@ export async function resolveMessagingTarget(params: {
|
|||||||
preferredKind?: TargetResolveKind;
|
preferredKind?: TargetResolveKind;
|
||||||
runtime?: RuntimeEnv;
|
runtime?: RuntimeEnv;
|
||||||
}): Promise<ResolveMessagingTargetResult> {
|
}): Promise<ResolveMessagingTargetResult> {
|
||||||
const raw = params.input.trim();
|
const raw = normalizeChannelTargetInput(params.input);
|
||||||
if (!raw) {
|
if (!raw) {
|
||||||
return { ok: false, error: new Error("Target is required") };
|
return { ok: false, error: new Error("Target is required") };
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user