fix(browser): restore tsc types

This commit is contained in:
Peter Steinberger
2025-12-20 01:27:22 +00:00
parent 1a51257b71
commit 0e94c6b025
7 changed files with 45 additions and 14 deletions

View File

@@ -232,7 +232,12 @@ export async function fileUploadViaPlaywright(opts: {
const timeout = Math.max(500, Math.min(60_000, opts.timeoutMs ?? 10_000));
const fileChooser = await page.waitForEvent("filechooser", { timeout });
if (!opts.paths?.length) {
await fileChooser.cancel();
// Playwright removed `FileChooser.cancel()`; best-effort close the chooser instead.
try {
await page.keyboard.press("Escape");
} catch {
// Best-effort.
}
return;
}
await fileChooser.setFiles(opts.paths);

View File

@@ -13,7 +13,7 @@ import {
const STATIC_RESOURCE_TYPES = new Set(["image", "font", "stylesheet", "media"]);
const tracingContexts = new WeakSet<unknown>();
const tracingContexts = new WeakSet<object>();
function consolePriority(level: string) {
switch (level) {

View File

@@ -27,6 +27,29 @@ import {
toStringOrEmpty,
} from "./utils.js";
type MouseButton = "left" | "right" | "middle";
type KeyboardModifier = "Alt" | "Control" | "ControlOrMeta" | "Meta" | "Shift";
function normalizeMouseButton(value: unknown): MouseButton | undefined {
const raw = toStringOrEmpty(value);
if (raw === "left" || raw === "right" || raw === "middle") return raw;
return undefined;
}
function normalizeModifiers(value: unknown): KeyboardModifier[] | undefined {
const raw = toStringArray(value);
if (!raw?.length) return undefined;
const normalized = raw.filter(
(m): m is KeyboardModifier =>
m === "Alt" ||
m === "Control" ||
m === "ControlOrMeta" ||
m === "Meta" ||
m === "Shift",
);
return normalized.length ? normalized : undefined;
}
export type BrowserActionCore =
| "back"
| "click"
@@ -228,10 +251,8 @@ export async function handleBrowserActionCore(
return true;
}
const doubleClick = toBoolean(args.doubleClick) ?? false;
const button = toStringOrEmpty(args.button) || undefined;
const modifiers = Array.isArray(args.modifiers)
? (args.modifiers as string[])
: undefined;
const button = normalizeMouseButton(args.button);
const modifiers = normalizeModifiers(args.modifiers);
const tab = await ctx.ensureTabAvailable(target);
await clickViaPlaywright({
cdpPort,

View File

@@ -27,6 +27,14 @@ import {
toStringOrEmpty,
} from "./utils.js";
type MouseButton = "left" | "right" | "middle";
function normalizeMouseButton(value: unknown): MouseButton | undefined {
const raw = toStringOrEmpty(value);
if (raw === "left" || raw === "right" || raw === "middle") return raw;
return undefined;
}
export type BrowserActionExtra =
| "console"
| "locator"
@@ -223,7 +231,7 @@ export async function handleBrowserActionExtra(
jsonError(res, 400, "x and y are required");
return true;
}
const button = toStringOrEmpty(args.button) || undefined;
const button = normalizeMouseButton(args.button);
const tab = await ctx.ensureTabAvailable(target);
await mouseClickViaPlaywright({
cdpPort,