fix: mutate prefixContext object instead of reassigning for closure correctness

2026-01-14 23:20:19 -05:00
parent 7b04e6ac42
commit 113eea5047
8 changed files with 30 additions and 53 deletions
--- a/src/slack/monitor/message-handler/dispatch.ts
+++ b/src/slack/monitor/message-handler/dispatch.ts
@@ -117,13 +117,11 @@ export async function dispatchPreparedSlackMessage(prepared: PreparedSlackMessag
          ? !account.config.blockStreaming
          : undefined,
      onModelSelected: (ctx) => {
-        prefixContext = {
-          ...prefixContext,
-          provider: ctx.provider,
-          model: extractShortModelName(ctx.model),
-          modelFull: `${ctx.provider}/${ctx.model}`,
-          thinkingLevel: ctx.thinkLevel ?? "off",
-        };
+        // Mutate the object directly instead of reassigning to ensure the closure sees updates
+        prefixContext.provider = ctx.provider;
+        prefixContext.model = extractShortModelName(ctx.model);
+        prefixContext.modelFull = `${ctx.provider}/${ctx.model}`;
+        prefixContext.thinkingLevel = ctx.thinkLevel ?? "off";
      },
    },
  });