From 242add587f39f4ad3f8ea4f48e815d7f10917aaa Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Fri, 23 Jan 2026 19:51:49 +0000 Subject: [PATCH] fix: quiet auth probe diagnostics --- CHANGELOG.md | 1 + src/agents/pi-embedded-runner/runs.ts | 8 ++++++-- src/logging/diagnostic.ts | 17 ++++++++++------- src/process/command-queue.ts | 9 ++++++--- 4 files changed, 23 insertions(+), 12 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e49b37002..288458bd1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ Docs: https://docs.clawd.bot - TUI: forward unknown slash commands (for example, `/context`) to the Gateway. - TUI: include Gateway slash commands in autocomplete and `/help`. - CLI: skip usage lines in `clawdbot models status` when provider usage is unavailable. +- CLI: suppress diagnostic session/run noise during auth probes. - Linux: include env-configured user bin roots in systemd PATH and align PATH audits. (#1512) Thanks @robbyczgw-cla. - TUI: render Gateway slash-command replies as system output (for example, `/context`). - Media: preserve PNG alpha when possible; fall back to JPEG when still over size cap. (#1491) Thanks @robbyczgw-cla. diff --git a/src/agents/pi-embedded-runner/runs.ts b/src/agents/pi-embedded-runner/runs.ts index 4fcefca12..dcbe56244 100644 --- a/src/agents/pi-embedded-runner/runs.ts +++ b/src/agents/pi-embedded-runner/runs.ts @@ -109,14 +109,18 @@ export function setActiveEmbeddedRun(sessionId: string, handle: EmbeddedPiQueueH state: "processing", reason: wasActive ? "run_replaced" : "run_started", }); - diag.info(`run registered: sessionId=${sessionId} totalActive=${ACTIVE_EMBEDDED_RUNS.size}`); + if (!sessionId.startsWith("probe-")) { + diag.info(`run registered: sessionId=${sessionId} totalActive=${ACTIVE_EMBEDDED_RUNS.size}`); + } } export function clearActiveEmbeddedRun(sessionId: string, handle: EmbeddedPiQueueHandle) { if (ACTIVE_EMBEDDED_RUNS.get(sessionId) === handle) { ACTIVE_EMBEDDED_RUNS.delete(sessionId); logSessionStateChange({ sessionId, state: "idle", reason: "run_completed" }); - diag.info(`run cleared: sessionId=${sessionId} totalActive=${ACTIVE_EMBEDDED_RUNS.size}`); + if (!sessionId.startsWith("probe-")) { + diag.info(`run cleared: sessionId=${sessionId} totalActive=${ACTIVE_EMBEDDED_RUNS.size}`); + } notifyEmbeddedRunEnded(sessionId); } else { diag.debug(`run clear skipped: sessionId=${sessionId} reason=handle_mismatch`); diff --git a/src/logging/diagnostic.ts b/src/logging/diagnostic.ts index ba6239184..adcb93eca 100644 --- a/src/logging/diagnostic.ts +++ b/src/logging/diagnostic.ts @@ -197,17 +197,20 @@ export function logSessionStateChange( }, ) { const state = getSessionState(params); + const isProbeSession = state.sessionId?.startsWith("probe-") ?? false; const prevState = state.state; state.state = params.state; state.lastActivity = Date.now(); if (params.state === "idle") state.queueDepth = Math.max(0, state.queueDepth - 1); - diag.info( - `session state: sessionId=${state.sessionId ?? "unknown"} sessionKey=${ - state.sessionKey ?? "unknown" - } prev=${prevState} new=${params.state} reason="${params.reason ?? ""}" queueDepth=${ - state.queueDepth - }`, - ); + if (!isProbeSession) { + diag.info( + `session state: sessionId=${state.sessionId ?? "unknown"} sessionKey=${ + state.sessionKey ?? "unknown" + } prev=${prevState} new=${params.state} reason="${params.reason ?? ""}" queueDepth=${ + state.queueDepth + }`, + ); + } emitDiagnosticEvent({ type: "session.state", sessionId: state.sessionId, diff --git a/src/process/command-queue.ts b/src/process/command-queue.ts index 9b203c938..2f2857130 100644 --- a/src/process/command-queue.ts +++ b/src/process/command-queue.ts @@ -68,9 +68,12 @@ function drainLane(lane: string) { entry.resolve(result); } catch (err) { state.active -= 1; - diag.error( - `lane task error: lane=${lane} durationMs=${Date.now() - startTime} error="${String(err)}"`, - ); + const isProbeLane = lane.startsWith("auth-probe:") || lane.startsWith("session:probe-"); + if (!isProbeLane) { + diag.error( + `lane task error: lane=${lane} durationMs=${Date.now() - startTime} error="${String(err)}"`, + ); + } pump(); entry.reject(err); }