fix: harden Mattermost plugin gating (#1428) (thanks @damoahdominic)

ui/src/ui/types.ts

@@ -164,39 +164,6 @@ export type SlackStatus = {
   lastProbeAt?: number | null;
 };
 
-export type MattermostBot = {
-  id?: string | null;
-  username?: string | null;
-};
-
-export type MattermostProbe = {
-  ok: boolean;
-  status?: number | null;
-  error?: string | null;
-  elapsedMs?: number | null;
-  bot?: MattermostBot | null;
-};
-
-export type MattermostStatus = {
-  configured: boolean;
-  botTokenSource?: string | null;
-  running: boolean;
-  connected?: boolean | null;
-  lastConnectedAt?: number | null;
-  lastDisconnect?: {
-    at: number;
-    status?: number | null;
-    error?: string | null;
-    loggedOut?: boolean | null;
-  } | null;
-  lastStartAt?: number | null;
-  lastStopAt?: number | null;
-  lastError?: string | null;
-  baseUrl?: string | null;
-  probe?: MattermostProbe | null;
-  lastProbeAt?: number | null;
-};
-
 export type SignalProbe = {
   ok: boolean;
   status?: number | null;
@@ -415,7 +382,6 @@ export type CronPayload =
         | "telegram"
         | "discord"
         | "slack"
-        | "mattermost"
         | "signal"
         | "imessage"
         | "msteams";

ui/src/ui/views/channels.mattermost.ts

@@ -1,70 +0,0 @@
-import { html, nothing } from "lit";
-
-import { formatAgo } from "../format";
-import type { MattermostStatus } from "../types";
-import type { ChannelsProps } from "./channels.types";
-import { renderChannelConfigSection } from "./channels.config";
-
-export function renderMattermostCard(params: {
-  props: ChannelsProps;
-  mattermost?: MattermostStatus | null;
-  accountCountLabel: unknown;
-}) {
-  const { props, mattermost, accountCountLabel } = params;
-
-  return html`
-    <div class="card">
-      <div class="card-title">Mattermost</div>
-      <div class="card-sub">Bot token + WebSocket status and configuration.</div>
-      ${accountCountLabel}
-
-      <div class="status-list" style="margin-top: 16px;">
-        <div>
-          <span class="label">Configured</span>
-          <span>${mattermost?.configured ? "Yes" : "No"}</span>
-        </div>
-        <div>
-          <span class="label">Running</span>
-          <span>${mattermost?.running ? "Yes" : "No"}</span>
-        </div>
-        <div>
-          <span class="label">Connected</span>
-          <span>${mattermost?.connected ? "Yes" : "No"}</span>
-        </div>
-        <div>
-          <span class="label">Base URL</span>
-          <span>${mattermost?.baseUrl || "n/a"}</span>
-        </div>
-        <div>
-          <span class="label">Last start</span>
-          <span>${mattermost?.lastStartAt ? formatAgo(mattermost.lastStartAt) : "n/a"}</span>
-        </div>
-        <div>
-          <span class="label">Last probe</span>
-          <span>${mattermost?.lastProbeAt ? formatAgo(mattermost.lastProbeAt) : "n/a"}</span>
-        </div>
-      </div>
-
-      ${mattermost?.lastError
-        ? html`<div class="callout danger" style="margin-top: 12px;">
-            ${mattermost.lastError}
-          </div>`
-        : nothing}
-
-      ${mattermost?.probe
-        ? html`<div class="callout" style="margin-top: 12px;">
-            Probe ${mattermost.probe.ok ? "ok" : "failed"} -
-            ${mattermost.probe.status ?? ""} ${mattermost.probe.error ?? ""}
-          </div>`
-        : nothing}
-
-      ${renderChannelConfigSection({ channelId: "mattermost", props })}
-
-      <div class="row" style="margin-top: 12px;">
-        <button class="btn" @click=${() => props.onRefresh(true)}>
-          Probe
-        </button>
-      </div>
-    </div>
-  `;
-}

ui/src/ui/views/channels.ts

@@ -7,7 +7,6 @@ import type {
   ChannelsStatusSnapshot,
   DiscordStatus,
   IMessageStatus,
-  MattermostStatus,
   NostrProfile,
   NostrStatus,
   SignalStatus,
@@ -24,7 +23,6 @@ import { channelEnabled, renderChannelAccountCount } from "./channels.shared";
 import { renderChannelConfigSection } from "./channels.config";
 import { renderDiscordCard } from "./channels.discord";
 import { renderIMessageCard } from "./channels.imessage";
-import { renderMattermostCard } from "./channels.mattermost";
 import { renderNostrCard } from "./channels.nostr";
 import { renderSignalCard } from "./channels.signal";
 import { renderSlackCard } from "./channels.slack";
@@ -41,7 +39,6 @@ export function renderChannels(props: ChannelsProps) {
     | undefined;
   const discord = (channels?.discord ?? null) as DiscordStatus | null;
   const slack = (channels?.slack ?? null) as SlackStatus | null;
-  const mattermost = (channels?.mattermost ?? null) as MattermostStatus | null;
   const signal = (channels?.signal ?? null) as SignalStatus | null;
   const imessage = (channels?.imessage ?? null) as IMessageStatus | null;
   const nostr = (channels?.nostr ?? null) as NostrStatus | null;
@@ -65,7 +62,6 @@ export function renderChannels(props: ChannelsProps) {
           telegram,
           discord,
           slack,
-          mattermost,
           signal,
           imessage,
           nostr,
@@ -139,12 +135,6 @@ function renderChannel(
         slack: data.slack,
         accountCountLabel,
       });
-    case "mattermost":
-      return renderMattermostCard({
-        props,
-        mattermost: data.mattermost,
-        accountCountLabel,
-      });
     case "signal":
       return renderSignalCard({
         props,

ui/src/ui/views/channels.types.ts

@@ -4,7 +4,6 @@ import type {
   ConfigUiHints,
   DiscordStatus,
   IMessageStatus,
-  MattermostStatus,
   NostrProfile,
   NostrStatus,
   SignalStatus,
@@ -54,7 +53,6 @@ export type ChannelsChannelData = {
   telegram?: TelegramStatus;
   discord?: DiscordStatus | null;
   slack?: SlackStatus | null;
-  mattermost?: MattermostStatus | null;
   signal?: SignalStatus | null;
   imessage?: IMessageStatus | null;
   nostr?: NostrStatus | null;