diff --git a/CHANGELOG.md b/CHANGELOG.md index 8ea80235a..85d231035 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,7 +7,7 @@ - Memory: allow custom OpenAI-compatible embedding endpoints for memory search (remote baseUrl/apiKey/headers). (#819 — thanks @mukhtharcm) ### Fixes -- Fallback: treat credential validation failures ("no credentials found", "no API key found") as auth errors that trigger model fallback. (#761 — thanks @pilkster) +- Fallback: treat credential validation failures ("no credentials found", "no API key found") as auth errors that trigger model fallback. (#822 — thanks @sebslight) - Telegram: persist polling update offsets across restarts to avoid duplicate updates. (#739 — thanks @thewilloftheshadow) - Discord: avoid duplicate message/reaction listeners on monitor reloads. (#744 — thanks @thewilloftheshadow) - System events: include local timestamps when events are injected into prompts. (#245 — thanks @thewilloftheshadow) diff --git a/src/agents/model-fallback.test.ts b/src/agents/model-fallback.test.ts index 6f0b3fb30..b9786f4b8 100644 --- a/src/agents/model-fallback.test.ts +++ b/src/agents/model-fallback.test.ts @@ -124,6 +124,26 @@ describe("runWithModelFallback", () => { expect(run.mock.calls[1]?.[1]).toBe("claude-haiku-3-5"); }); + it("falls back on missing API key errors", async () => { + const cfg = makeCfg(); + const run = vi + .fn() + .mockRejectedValueOnce(new Error("No API key found for profile openai.")) + .mockResolvedValueOnce("ok"); + + const result = await runWithModelFallback({ + cfg, + provider: "openai", + model: "gpt-4.1-mini", + run, + }); + + expect(result.result).toBe("ok"); + expect(run).toHaveBeenCalledTimes(2); + expect(run.mock.calls[1]?.[0]).toBe("anthropic"); + expect(run.mock.calls[1]?.[1]).toBe("claude-haiku-3-5"); + }); + it("appends the configured primary as a last fallback", async () => { const cfg = makeCfg({ agents: { diff --git a/src/telegram/monitor.ts b/src/telegram/monitor.ts index 908c8de39..a14cda10d 100644 --- a/src/telegram/monitor.ts +++ b/src/telegram/monitor.ts @@ -6,11 +6,11 @@ import { formatDurationMs } from "../infra/format-duration.js"; import type { RuntimeEnv } from "../runtime.js"; import { resolveTelegramAccount } from "./accounts.js"; import { createTelegramBot } from "./bot.js"; +import { makeProxyFetch } from "./proxy.js"; import { readTelegramUpdateOffset, writeTelegramUpdateOffset, } from "./update-offset-store.js"; -import { makeProxyFetch } from "./proxy.js"; import { startTelegramWebhook } from "./webhook.js"; export type MonitorTelegramOpts = { diff --git a/src/telegram/update-offset-store.test.ts b/src/telegram/update-offset-store.test.ts index 2483c4101..b028802bc 100644 --- a/src/telegram/update-offset-store.test.ts +++ b/src/telegram/update-offset-store.test.ts @@ -34,9 +34,9 @@ describe("telegram update offset store", () => { updateId: 421, }); - expect( - await readTelegramUpdateOffset({ accountId: "primary" }), - ).toBe(421); + expect(await readTelegramUpdateOffset({ accountId: "primary" })).toBe( + 421, + ); }); }); });