fix: preserve explicit maxChars=0 (#796) (thanks @gabriel-trigo)

src/agents/tools/browser-tool.test.ts

@@ -89,4 +89,17 @@ describe("browser tool snapshot maxChars", () => {
       }),
     );
   });
+
+  it("skips the default when maxChars is explicitly zero", async () => {
+    const tool = createBrowserTool();
+    await tool.execute?.(null, {
+      action: "snapshot",
+      format: "ai",
+      maxChars: 0,
+    });
+
+    expect(browserClientMocks.browserSnapshot).toHaveBeenCalled();
+    const [, opts] = browserClientMocks.browserSnapshot.mock.calls.at(-1) ?? [];
+    expect(Object.hasOwn(opts ?? {}, "maxChars")).toBe(false);
+  });
 });

src/agents/tools/browser-tool.ts

@@ -322,6 +322,7 @@ export function createBrowserTool(opts?: {
             params.format === "ai" || params.format === "aria"
               ? (params.format as "ai" | "aria")
               : "ai";
+          const hasMaxChars = Object.hasOwn(params, "maxChars");
           const targetId =
             typeof params.targetId === "string"
               ? params.targetId.trim()
@@ -338,7 +339,9 @@ export function createBrowserTool(opts?: {
               : undefined;
           const resolvedMaxChars =
             format === "ai"
-              ? (maxChars ?? DEFAULT_AI_SNAPSHOT_MAX_CHARS)
+              ? hasMaxChars
+                ? maxChars
+                : DEFAULT_AI_SNAPSHOT_MAX_CHARS
               : undefined;
           const interactive =
             typeof params.interactive === "boolean"
@@ -360,7 +363,9 @@ export function createBrowserTool(opts?: {
             format,
             targetId,
             limit,
-            ...(resolvedMaxChars ? { maxChars: resolvedMaxChars } : {}),
+            ...(typeof resolvedMaxChars === "number"
+              ? { maxChars: resolvedMaxChars }
+              : {}),
             interactive,
             compact,
             depth,

src/browser/routes/agent.ts

@@ -1195,6 +1195,7 @@ export function registerBrowserAgentRoutes(
             : "aria";
     const limitRaw =
       typeof req.query.limit === "string" ? Number(req.query.limit) : undefined;
+    const hasMaxChars = Object.hasOwn(req.query, "maxChars");
     const maxCharsRaw =
       typeof req.query.maxChars === "string"
         ? Number(req.query.maxChars)
@@ -1207,7 +1208,11 @@ export function registerBrowserAgentRoutes(
         ? Math.floor(maxCharsRaw)
         : undefined;
     const resolvedMaxChars =
-      format === "ai" ? (maxChars ?? DEFAULT_AI_SNAPSHOT_MAX_CHARS) : undefined;
+      format === "ai"
+        ? hasMaxChars
+          ? maxChars
+          : DEFAULT_AI_SNAPSHOT_MAX_CHARS
+        : undefined;
     const interactive = toBoolean(req.query.interactive);
     const compact = toBoolean(req.query.compact);
     const depth = toNumber(req.query.depth);

src/browser/server.test.ts

@@ -687,6 +687,25 @@ describe("browser control server", () => {
     expect(stopped.stopped).toBe(true);
   });
 
+  it("skips default maxChars when explicitly set to zero", async () => {
+    const { startBrowserControlServerFromConfig } = await import("./server.js");
+    await startBrowserControlServerFromConfig();
+    const base = `http://127.0.0.1:${testPort}`;
+    await realFetch(`${base}/start`, { method: "POST" }).then((r) => r.json());
+
+    const snapAi = (await realFetch(
+      `${base}/snapshot?format=ai&maxChars=0`,
+    ).then((r) => r.json())) as { ok: boolean; format?: string };
+    expect(snapAi.ok).toBe(true);
+    expect(snapAi.format).toBe("ai");
+
+    const [call] = pwMocks.snapshotAiViaPlaywright.mock.calls.at(-1) ?? [];
+    expect(call).toEqual({
+      cdpUrl: cdpBaseUrl,
+      targetId: "abcd1234",
+    });
+  });
+
   it("validates agent inputs (agent routes)", async () => {
     const { startBrowserControlServerFromConfig } = await import("./server.js");
     await startBrowserControlServerFromConfig();