fix: preserve explicit maxChars=0 (#796) (thanks @gabriel-trigo)

This commit is contained in:
Peter Steinberger
2026-01-13 02:29:48 +00:00
parent 56c406b19e
commit 46a694bbc7
5 changed files with 46 additions and 3 deletions

View File

@@ -1195,6 +1195,7 @@ export function registerBrowserAgentRoutes(
: "aria";
const limitRaw =
typeof req.query.limit === "string" ? Number(req.query.limit) : undefined;
const hasMaxChars = Object.hasOwn(req.query, "maxChars");
const maxCharsRaw =
typeof req.query.maxChars === "string"
? Number(req.query.maxChars)
@@ -1207,7 +1208,11 @@ export function registerBrowserAgentRoutes(
? Math.floor(maxCharsRaw)
: undefined;
const resolvedMaxChars =
format === "ai" ? (maxChars ?? DEFAULT_AI_SNAPSHOT_MAX_CHARS) : undefined;
format === "ai"
? hasMaxChars
? maxChars
: DEFAULT_AI_SNAPSHOT_MAX_CHARS
: undefined;
const interactive = toBoolean(req.query.interactive);
const compact = toBoolean(req.query.compact);
const depth = toNumber(req.query.depth);

View File

@@ -687,6 +687,25 @@ describe("browser control server", () => {
expect(stopped.stopped).toBe(true);
});
it("skips default maxChars when explicitly set to zero", async () => {
const { startBrowserControlServerFromConfig } = await import("./server.js");
await startBrowserControlServerFromConfig();
const base = `http://127.0.0.1:${testPort}`;
await realFetch(`${base}/start`, { method: "POST" }).then((r) => r.json());
const snapAi = (await realFetch(
`${base}/snapshot?format=ai&maxChars=0`,
).then((r) => r.json())) as { ok: boolean; format?: string };
expect(snapAi.ok).toBe(true);
expect(snapAi.format).toBe("ai");
const [call] = pwMocks.snapshotAiViaPlaywright.mock.calls.at(-1) ?? [];
expect(call).toEqual({
cdpUrl: cdpBaseUrl,
targetId: "abcd1234",
});
});
it("validates agent inputs (agent routes)", async () => {
const { startBrowserControlServerFromConfig } = await import("./server.js");
await startBrowserControlServerFromConfig();