let5see/clawdbot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test: stabilize exec approvals path resolution

Browse Source
This commit is contained in:
Peter Steinberger
2026-01-22 02:07:36 +00:00
parent cc74e0d188
commit 47ebe29195
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/infra/exec-approvals.test.ts
View File

@@ -17,6 +17,13 @@ import {
type ExecAllowlistEntry, type ExecAllowlistEntry,
} from "./exec-approvals.js"; } from "./exec-approvals.js";
function makePathEnv(binDir: string): NodeJS.ProcessEnv {
if (process.platform !== "win32") {
return { PATH: binDir };
}
return { PATH: binDir, PATHEXT: ".EXE;.CMD;.BAT;.COM" };
}
function makeTempDir() { function makeTempDir() {
return fs.mkdtempSync(path.join(os.tmpdir(), "clawdbot-exec-approvals-")); return fs.mkdtempSync(path.join(os.tmpdir(), "clawdbot-exec-approvals-"));
} }
@@ -76,7 +83,7 @@ describe("exec approvals command resolution", () => {
const exe = path.join(binDir, exeName); const exe = path.join(binDir, exeName);
fs.writeFileSync(exe, ""); fs.writeFileSync(exe, "");
fs.chmodSync(exe, 0o755); fs.chmodSync(exe, 0o755);
const res = resolveCommandResolution("rg -n foo", undefined, { PATH: binDir }); const res = resolveCommandResolution("rg -n foo", undefined, makePathEnv(binDir));
expect(res?.resolvedPath).toBe(exe); expect(res?.resolvedPath).toBe(exe);
expect(res?.executableName).toBe(exeName); expect(res?.executableName).toBe(exeName);
}); });
@@ -135,7 +142,7 @@ describe("exec approvals safe bins", () => {
const res = analyzeShellCommand({ const res = analyzeShellCommand({
command: "jq .foo", command: "jq .foo",
cwd: dir, cwd: dir,
env: { PATH: binDir }, env: makePathEnv(binDir),
}); });
expect(res.ok).toBe(true); expect(res.ok).toBe(true);
const segment = res.segments[0]; const segment = res.segments[0];
@@ -161,7 +168,7 @@ describe("exec approvals safe bins", () => {
const res = analyzeShellCommand({ const res = analyzeShellCommand({
command: "jq .foo secret.json", command: "jq .foo secret.json",
cwd: dir, cwd: dir,
env: { PATH: binDir }, env: makePathEnv(binDir),
}); });
expect(res.ok).toBe(true); expect(res.ok).toBe(true);
const segment = res.segments[0]; const segment = res.segments[0];