feat: run doctor after restart

This commit is contained in:
Peter Steinberger
2026-01-10 23:14:55 +01:00
parent 4eb6aec016
commit 494743a4e5
6 changed files with 74 additions and 1 deletions

View File

@@ -1,3 +1,6 @@
import fs from "node:fs/promises";
import os from "node:os";
import path from "node:path";
import { describe, expect, it, vi } from "vitest"; import { describe, expect, it, vi } from "vitest";
import { createClawdbotTools } from "./clawdbot-tools.js"; import { createClawdbotTools } from "./clawdbot-tools.js";
@@ -10,6 +13,11 @@ describe("gateway tool", () => {
it("schedules SIGUSR1 restart", async () => { it("schedules SIGUSR1 restart", async () => {
vi.useFakeTimers(); vi.useFakeTimers();
const kill = vi.spyOn(process, "kill").mockImplementation(() => true); const kill = vi.spyOn(process, "kill").mockImplementation(() => true);
const previousStateDir = process.env.CLAWDBOT_STATE_DIR;
const stateDir = await fs.mkdtemp(
path.join(os.tmpdir(), "clawdbot-test-"),
);
process.env.CLAWDBOT_STATE_DIR = stateDir;
try { try {
const tool = createClawdbotTools({ const tool = createClawdbotTools({
@@ -29,12 +37,27 @@ describe("gateway tool", () => {
delayMs: 0, delayMs: 0,
}); });
const sentinelPath = path.join(stateDir, "restart-sentinel.json");
const raw = await fs.readFile(sentinelPath, "utf-8");
const parsed = JSON.parse(raw) as {
payload?: { kind?: string; doctorHint?: string | null };
};
expect(parsed.payload?.kind).toBe("restart");
expect(parsed.payload?.doctorHint).toBe(
"Run: clawdbot doctor --non-interactive",
);
expect(kill).not.toHaveBeenCalled(); expect(kill).not.toHaveBeenCalled();
await vi.runAllTimersAsync(); await vi.runAllTimersAsync();
expect(kill).toHaveBeenCalledWith(process.pid, "SIGUSR1"); expect(kill).toHaveBeenCalledWith(process.pid, "SIGUSR1");
} finally { } finally {
kill.mockRestore(); kill.mockRestore();
vi.useRealTimers(); vi.useRealTimers();
if (previousStateDir === undefined) {
delete process.env.CLAWDBOT_STATE_DIR;
} else {
process.env.CLAWDBOT_STATE_DIR = previousStateDir;
}
} }
}); });

View File

@@ -2,6 +2,11 @@ import { Type } from "@sinclair/typebox";
import type { ClawdbotConfig } from "../../config/config.js"; import type { ClawdbotConfig } from "../../config/config.js";
import { scheduleGatewaySigusr1Restart } from "../../infra/restart.js"; import { scheduleGatewaySigusr1Restart } from "../../infra/restart.js";
import {
DOCTOR_NONINTERACTIVE_HINT,
type RestartSentinelPayload,
writeRestartSentinel,
} from "../../infra/restart-sentinel.js";
import { type AnyAgentTool, jsonResult, readStringParam } from "./common.js"; import { type AnyAgentTool, jsonResult, readStringParam } from "./common.js";
import { callGatewayTool } from "./gateway.js"; import { callGatewayTool } from "./gateway.js";
@@ -61,6 +66,10 @@ export function createGatewayTool(opts?: {
"Gateway restart is disabled. Set commands.restart=true to enable.", "Gateway restart is disabled. Set commands.restart=true to enable.",
); );
} }
const sessionKey =
typeof params.sessionKey === "string" && params.sessionKey.trim()
? params.sessionKey.trim()
: opts?.agentSessionKey?.trim() || undefined;
const delayMs = const delayMs =
typeof params.delayMs === "number" && Number.isFinite(params.delayMs) typeof params.delayMs === "number" && Number.isFinite(params.delayMs)
? Math.floor(params.delayMs) ? Math.floor(params.delayMs)
@@ -69,6 +78,27 @@ export function createGatewayTool(opts?: {
typeof params.reason === "string" && params.reason.trim() typeof params.reason === "string" && params.reason.trim()
? params.reason.trim().slice(0, 200) ? params.reason.trim().slice(0, 200)
: undefined; : undefined;
const note =
typeof params.note === "string" && params.note.trim()
? params.note.trim()
: undefined;
const payload: RestartSentinelPayload = {
kind: "restart",
status: "ok",
ts: Date.now(),
sessionKey,
message: note ?? reason ?? null,
doctorHint: DOCTOR_NONINTERACTIVE_HINT,
stats: {
mode: "gateway.restart",
reason,
},
};
try {
await writeRestartSentinel(payload);
} catch {
// ignore: sentinel is best-effort
}
console.info( console.info(
`gateway tool: restart requested (delayMs=${delayMs ?? "default"}, reason=${reason ?? "none"})`, `gateway tool: restart requested (delayMs=${delayMs ?? "default"}, reason=${reason ?? "none"})`,
); );

View File

@@ -1,5 +1,6 @@
import type { Command } from "commander"; import type { Command } from "commander";
import { doctorCommand } from "../commands/doctor.js";
import { resolveClawdbotPackageRoot } from "../infra/clawdbot-root.js"; import { resolveClawdbotPackageRoot } from "../infra/clawdbot-root.js";
import { import {
runGatewayUpdate, runGatewayUpdate,
@@ -159,6 +160,17 @@ export async function updateCommand(opts: UpdateCommandOptions): Promise<void> {
const restarted = await runDaemonRestart(); const restarted = await runDaemonRestart();
if (!opts.json && restarted) { if (!opts.json && restarted) {
defaultRuntime.log(theme.success("Daemon restarted successfully.")); defaultRuntime.log(theme.success("Daemon restarted successfully."));
defaultRuntime.log("");
process.env.CLAWDBOT_UPDATE_IN_PROGRESS = "1";
try {
await doctorCommand(defaultRuntime, { nonInteractive: true });
} catch (err) {
defaultRuntime.log(
theme.warn(`Doctor failed: ${String(err)}`),
);
} finally {
delete process.env.CLAWDBOT_UPDATE_IN_PROGRESS;
}
} }
} catch (err) { } catch (err) {
if (!opts.json) { if (!opts.json) {

View File

@@ -8,6 +8,7 @@ import {
import { buildConfigSchema } from "../../config/schema.js"; import { buildConfigSchema } from "../../config/schema.js";
import { scheduleGatewaySigusr1Restart } from "../../infra/restart.js"; import { scheduleGatewaySigusr1Restart } from "../../infra/restart.js";
import { import {
DOCTOR_NONINTERACTIVE_HINT,
type RestartSentinelPayload, type RestartSentinelPayload,
writeRestartSentinel, writeRestartSentinel,
} from "../../infra/restart-sentinel.js"; } from "../../infra/restart-sentinel.js";
@@ -176,6 +177,7 @@ export const configHandlers: GatewayRequestHandlers = {
ts: Date.now(), ts: Date.now(),
sessionKey, sessionKey,
message: note ?? null, message: note ?? null,
doctorHint: DOCTOR_NONINTERACTIVE_HINT,
stats: { stats: {
mode: "config.apply", mode: "config.apply",
root: CONFIG_PATH_CLAWDBOT, root: CONFIG_PATH_CLAWDBOT,

View File

@@ -1,6 +1,7 @@
import { resolveClawdbotPackageRoot } from "../../infra/clawdbot-root.js"; import { resolveClawdbotPackageRoot } from "../../infra/clawdbot-root.js";
import { scheduleGatewaySigusr1Restart } from "../../infra/restart.js"; import { scheduleGatewaySigusr1Restart } from "../../infra/restart.js";
import { import {
DOCTOR_NONINTERACTIVE_HINT,
type RestartSentinelPayload, type RestartSentinelPayload,
writeRestartSentinel, writeRestartSentinel,
} from "../../infra/restart-sentinel.js"; } from "../../infra/restart-sentinel.js";
@@ -76,6 +77,7 @@ export const updateHandlers: GatewayRequestHandlers = {
ts: Date.now(), ts: Date.now(),
sessionKey, sessionKey,
message: note ?? null, message: note ?? null,
doctorHint: DOCTOR_NONINTERACTIVE_HINT,
stats: { stats: {
mode: result.mode, mode: result.mode,
root: result.root ?? undefined, root: result.root ?? undefined,

View File

@@ -28,11 +28,12 @@ export type RestartSentinelStats = {
}; };
export type RestartSentinelPayload = { export type RestartSentinelPayload = {
kind: "config-apply" | "update"; kind: "config-apply" | "update" | "restart";
status: "ok" | "error" | "skipped"; status: "ok" | "error" | "skipped";
ts: number; ts: number;
sessionKey?: string; sessionKey?: string;
message?: string | null; message?: string | null;
doctorHint?: string | null;
stats?: RestartSentinelStats | null; stats?: RestartSentinelStats | null;
}; };
@@ -43,6 +44,9 @@ export type RestartSentinel = {
const SENTINEL_FILENAME = "restart-sentinel.json"; const SENTINEL_FILENAME = "restart-sentinel.json";
export const DOCTOR_NONINTERACTIVE_HINT =
"Run: clawdbot doctor --non-interactive";
export function resolveRestartSentinelPath( export function resolveRestartSentinelPath(
env: NodeJS.ProcessEnv = process.env, env: NodeJS.ProcessEnv = process.env,
): string { ): string {