Merge pull request #630 from adam91holt/fix/heartbeat-default-agent-only

fix: only inject heartbeat prompt for default agent

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## Unreleased
 
+- Agents: gate heartbeat prompt to default agent sessions (including non-agent session keys). (#630) — thanks @adam91holt
 - Agent: fast abort on /stop and cancel tool calls between tool boundaries. (#617)
 - Models/Auth: add OpenCode Zen (multi-model proxy) onboarding. (#623) — thanks @magimetal
 - WhatsApp: refactor vCard parsing helper and improve empty contact card summaries. (#624) — thanks @steipete

src/agents/pi-embedded-runner.test.ts

@@ -2,10 +2,12 @@ import type { AgentMessage, AgentTool } from "@mariozechner/pi-agent-core";
 import { SessionManager } from "@mariozechner/pi-coding-agent";
 import { Type } from "@sinclair/typebox";
 import { describe, expect, it, vi } from "vitest";
+import type { ClawdbotConfig } from "../config/config.js";
 import {
   applyGoogleTurnOrderingFix,
   buildEmbeddedSandboxInfo,
   createSystemPromptOverride,
+  resolveSessionAgentIds,
   splitSdkTools,
 } from "./pi-embedded-runner.js";
 import type { SandboxContext } from "./sandbox.js";
@@ -57,6 +59,38 @@ describe("buildEmbeddedSandboxInfo", () => {
   });
 });
 
+describe("resolveSessionAgentIds", () => {
+  const cfg = {
+    agents: {
+      list: [{ id: "main" }, { id: "beta", default: true }],
+    },
+  } as ClawdbotConfig;
+
+  it("falls back to the configured default when sessionKey is missing", () => {
+    const { defaultAgentId, sessionAgentId } = resolveSessionAgentIds({
+      config: cfg,
+    });
+    expect(defaultAgentId).toBe("beta");
+    expect(sessionAgentId).toBe("beta");
+  });
+
+  it("falls back to the configured default when sessionKey is non-agent", () => {
+    const { sessionAgentId } = resolveSessionAgentIds({
+      sessionKey: "telegram:slash:123",
+      config: cfg,
+    });
+    expect(sessionAgentId).toBe("beta");
+  });
+
+  it("uses the agent id from agent session keys", () => {
+    const { sessionAgentId } = resolveSessionAgentIds({
+      sessionKey: "agent:main:main",
+      config: cfg,
+    });
+    expect(sessionAgentId).toBe("main");
+  });
+});
+
 function createStubTool(name: string): AgentTool {
   return {
     name,

src/agents/pi-embedded-runner.ts

@@ -33,9 +33,14 @@ import {
   type enqueueCommand,
   enqueueCommandInLane,
 } from "../process/command-queue.js";
+import {
+  normalizeAgentId,
+  parseAgentSessionKey,
+} from "../routing/session-key.js";
 import { normalizeMessageProvider } from "../utils/message-provider.js";
 import { resolveUserPath } from "../utils.js";
 import { resolveClawdbotAgentDir } from "./agent-paths.js";
+import { resolveDefaultAgentId } from "./agent-scope.js";
 import {
   markAuthProfileFailure,
   markAuthProfileGood,
@@ -555,6 +560,19 @@ export function buildEmbeddedSandboxInfo(
   };
 }
 
+export function resolveSessionAgentIds(params: {
+  sessionKey?: string;
+  config?: ClawdbotConfig;
+}): { defaultAgentId: string; sessionAgentId: string } {
+  const defaultAgentId = resolveDefaultAgentId(params.config ?? {});
+  const sessionKey = params.sessionKey?.trim();
+  const parsed = sessionKey ? parseAgentSessionKey(sessionKey) : null;
+  const sessionAgentId = parsed?.agentId
+    ? normalizeAgentId(parsed.agentId)
+    : defaultAgentId;
+  return { defaultAgentId, sessionAgentId };
+}
+
 function buildEmbeddedSystemPrompt(params: {
   workspaceDir: string;
   defaultThinkLevel?: ThinkLevel;
@@ -882,15 +900,23 @@ export async function compactEmbeddedPiSession(params: {
           params.config?.agents?.defaults?.userTimezone,
         );
         const userTime = formatUserTime(new Date(), userTimezone);
+        // Only include heartbeat prompt for the default agent
+        const { defaultAgentId, sessionAgentId } = resolveSessionAgentIds({
+          sessionKey: params.sessionKey,
+          config: params.config,
+        });
+        const isDefaultAgent = sessionAgentId === defaultAgentId;
         const appendPrompt = buildEmbeddedSystemPrompt({
           workspaceDir: effectiveWorkspace,
           defaultThinkLevel: params.thinkLevel,
           extraSystemPrompt: params.extraSystemPrompt,
           ownerNumbers: params.ownerNumbers,
           reasoningTagHint,
-          heartbeatPrompt: resolveHeartbeatPrompt(
+          heartbeatPrompt: isDefaultAgent
-            params.config?.agents?.defaults?.heartbeat?.prompt,
+            ? resolveHeartbeatPrompt(
-          ),
+                params.config?.agents?.defaults?.heartbeat?.prompt,
+              )
+            : undefined,
           skillsPrompt,
           runtimeInfo,
           sandboxInfo,
@@ -1245,15 +1271,23 @@ export async function runEmbeddedPiAgent(params: {
             params.config?.agents?.defaults?.userTimezone,
           );
           const userTime = formatUserTime(new Date(), userTimezone);
+          // Only include heartbeat prompt for the default agent
+          const { defaultAgentId, sessionAgentId } = resolveSessionAgentIds({
+            sessionKey: params.sessionKey,
+            config: params.config,
+          });
+          const isDefaultAgent = sessionAgentId === defaultAgentId;
           const appendPrompt = buildEmbeddedSystemPrompt({
             workspaceDir: effectiveWorkspace,
             defaultThinkLevel: thinkLevel,
             extraSystemPrompt: params.extraSystemPrompt,
             ownerNumbers: params.ownerNumbers,
             reasoningTagHint,
-            heartbeatPrompt: resolveHeartbeatPrompt(
+            heartbeatPrompt: isDefaultAgent
-              params.config?.agents?.defaults?.heartbeat?.prompt,
+              ? resolveHeartbeatPrompt(
-            ),
+                  params.config?.agents?.defaults?.heartbeat?.prompt,
+                )
+              : undefined,
             skillsPrompt,
             runtimeInfo,
             sandboxInfo,