From 65dd73b4c369f1adab49e5216269cf7f2a6bbde2 Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Wed, 21 Jan 2026 06:28:22 +0000 Subject: [PATCH] fix: clean up slack threading landings (#1360) (thanks @SocialNerd42069) --- Peekaboo | 1 - ...i-session.does-not-emit-duplicate-block-replies-text.test.ts | 2 +- src/cli/update-cli.ts | 1 + src/slack/monitor/message-handler/prepare.ts | 1 - 4 files changed, 2 insertions(+), 3 deletions(-) delete mode 160000 Peekaboo diff --git a/Peekaboo b/Peekaboo deleted file mode 160000 index 5c195f5e4..000000000 --- a/Peekaboo +++ /dev/null @@ -1 +0,0 @@ -Subproject commit 5c195f5e46ebfcc953af74fdd05fbc962d05a50c diff --git a/src/agents/pi-embedded-subscribe.subscribe-embedded-pi-session.does-not-emit-duplicate-block-replies-text.test.ts b/src/agents/pi-embedded-subscribe.subscribe-embedded-pi-session.does-not-emit-duplicate-block-replies-text.test.ts index 7d592caad..827c58193 100644 --- a/src/agents/pi-embedded-subscribe.subscribe-embedded-pi-session.does-not-emit-duplicate-block-replies-text.test.ts +++ b/src/agents/pi-embedded-subscribe.subscribe-embedded-pi-session.does-not-emit-duplicate-block-replies-text.test.ts @@ -113,7 +113,7 @@ describe("subscribeEmbeddedPiSession", () => { handler?.({ type: "message_end", message: assistantMessageWithNewline }); handler?.({ type: "message_end", message: assistantMessageTrimmed }); - expect(subscription.assistantTexts).toEqual(["Hello world\n"]); + expect(subscription.assistantTexts).toEqual(["Hello world"]); }); it("does not duplicate assistantTexts when message_end repeats with reasoning blocks", () => { let handler: SessionEventHandler | undefined; diff --git a/src/cli/update-cli.ts b/src/cli/update-cli.ts index 17eb91757..99da9ac0d 100644 --- a/src/cli/update-cli.ts +++ b/src/cli/update-cli.ts @@ -17,6 +17,7 @@ import { runGatewayUpdate, type UpdateRunResult, type UpdateStepInfo, + type UpdateStepResult, type UpdateStepProgress, type UpdateStepResult, } from "../infra/update-runner.js"; diff --git a/src/slack/monitor/message-handler/prepare.ts b/src/slack/monitor/message-handler/prepare.ts index 5a27b30ce..849c08d31 100644 --- a/src/slack/monitor/message-handler/prepare.ts +++ b/src/slack/monitor/message-handler/prepare.ts @@ -481,7 +481,6 @@ export async function prepareSlackMessage(params: { ParentSessionKey: threadKeys.parentSessionKey, ThreadStarterBody: threadStarterBody, ThreadLabel: threadLabel, - MessageThreadId: isThreadReply ? threadTs : undefined, Timestamp: message.ts ? Math.round(Number(message.ts) * 1000) : undefined, WasMentioned: isRoomish ? effectiveWasMentioned : undefined, MediaPath: media?.path,