diff --git a/CHANGELOG.md b/CHANGELOG.md index 9969e98e4..fa7b81806 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,10 @@ # Changelog +## 2026.1.11 (Unreleased) + +### Changes +- macOS: prompt to install the global `clawdbot` CLI when missing in local mode, and use external launchd/CLI instead of the embedded gateway runtime. + ## 2026.1.10 ### Highlights diff --git a/apps/macos/Sources/Clawdbot/CLIInstallPrompter.swift b/apps/macos/Sources/Clawdbot/CLIInstallPrompter.swift new file mode 100644 index 000000000..5f6afe067 --- /dev/null +++ b/apps/macos/Sources/Clawdbot/CLIInstallPrompter.swift @@ -0,0 +1,71 @@ +import AppKit +import Foundation +import OSLog + +@MainActor +final class CLIInstallPrompter { + static let shared = CLIInstallPrompter() + private let logger = Logger(subsystem: "com.clawdbot", category: "cli.prompt") + private var isPrompting = false + + func checkAndPromptIfNeeded(reason: String) { + guard self.shouldPrompt() else { return } + guard let version = Self.appVersion() else { return } + self.isPrompting = true + UserDefaults.standard.set(version, forKey: cliInstallPromptedVersionKey) + + let alert = NSAlert() + alert.messageText = "Install Clawdbot CLI?" + alert.informativeText = "Local mode needs the CLI so launchd can run the gateway." + alert.addButton(withTitle: "Install CLI") + alert.addButton(withTitle: "Not now") + alert.addButton(withTitle: "Open Settings") + let response = alert.runModal() + + switch response { + case .alertFirstButtonReturn: + Task { await self.installCLI() } + case .alertThirdButtonReturn: + self.openSettings(tab: .general) + default: + break + } + + self.logger.debug("cli install prompt handled reason=\(reason, privacy: .public)") + self.isPrompting = false + } + + private func shouldPrompt() -> Bool { + guard !self.isPrompting else { return false } + guard AppStateStore.shared.onboardingSeen else { return false } + guard AppStateStore.shared.connectionMode == .local else { return false } + guard !AppStateStore.shared.attachExistingGatewayOnly else { return false } + guard CLIInstaller.installedLocation() == nil else { return false } + guard let version = Self.appVersion() else { return false } + let lastPrompt = UserDefaults.standard.string(forKey: cliInstallPromptedVersionKey) + return lastPrompt != version + } + + private func installCLI() async { + var lastStatus: String? + await CLIInstaller.install { message in + lastStatus = message + } + if let message = lastStatus { + let alert = NSAlert() + alert.messageText = "CLI install finished" + alert.informativeText = message + alert.runModal() + } + } + + private func openSettings(tab: SettingsTab) { + SettingsTabRouter.request(tab) + NotificationCenter.default.post(name: .clawdbotSelectSettingsTab, object: tab) + NSApp.sendAction(#selector(NSApplication.showSettingsWindow), to: nil, from: nil) + } + + private static func appVersion() -> String? { + Bundle.main.infoDictionary?["CFBundleShortVersionString"] as? String + } +} diff --git a/apps/macos/Sources/Clawdbot/CLIInstaller.swift b/apps/macos/Sources/Clawdbot/CLIInstaller.swift index 374201123..efe92fb7d 100644 --- a/apps/macos/Sources/Clawdbot/CLIInstaller.swift +++ b/apps/macos/Sources/Clawdbot/CLIInstaller.swift @@ -2,24 +2,16 @@ import Foundation @MainActor enum CLIInstaller { - private static func embeddedHelperURL() -> URL { - Bundle.main.bundleURL.appendingPathComponent("Contents/Resources/Relay/clawdbot") - } - static func installedLocation() -> String? { self.installedLocation( - searchPaths: cliHelperSearchPaths, - embeddedHelper: self.embeddedHelperURL(), + searchPaths: CommandResolver.preferredPaths(), fileManager: .default) } static func installedLocation( searchPaths: [String], - embeddedHelper: URL, fileManager: FileManager) -> String? { - let embedded = embeddedHelper.resolvingSymlinksInPath() - for basePath in searchPaths { let candidate = URL(fileURLWithPath: basePath).appendingPathComponent("clawdbot").path var isDirectory: ObjCBool = false @@ -32,10 +24,7 @@ enum CLIInstaller { guard fileManager.isExecutableFile(atPath: candidate) else { continue } - let resolved = URL(fileURLWithPath: candidate).resolvingSymlinksInPath() - if resolved == embedded { - return candidate - } + return candidate } return nil @@ -46,57 +35,9 @@ enum CLIInstaller { } static func install(statusHandler: @escaping @Sendable (String) async -> Void) async { - let helper = self.embeddedHelperURL() - guard FileManager.default.isExecutableFile(atPath: helper.path) else { - await statusHandler( - "Embedded CLI missing in bundle; repackage via scripts/package-mac-app.sh " + - "(or restart-mac.sh without SKIP_GATEWAY_PACKAGE=1).") - return + let expected = GatewayEnvironment.expectedGatewayVersion() + await GatewayEnvironment.installGlobal(version: expected) { message in + Task { @MainActor in await statusHandler(message) } } - - let targets = cliHelperSearchPaths.map { "\($0)/clawdbot" } - let result = await self.privilegedSymlink(source: helper.path, targets: targets) - await statusHandler(result) - } - - private static func privilegedSymlink(source: String, targets: [String]) async -> String { - let escapedSource = self.shellEscape(source) - let targetList = targets.map(self.shellEscape).joined(separator: " ") - let cmds = [ - "mkdir -p /usr/local/bin /opt/homebrew/bin", - targets.map { "ln -sf \(escapedSource) \($0)" }.joined(separator: "; "), - ].joined(separator: "; ") - - let script = """ - do shell script "\(cmds)" with administrator privileges - """ - - let proc = Process() - proc.executableURL = URL(fileURLWithPath: "/usr/bin/osascript") - proc.arguments = ["-e", script] - - let pipe = Pipe() - proc.standardOutput = pipe - proc.standardError = pipe - - do { - try proc.run() - proc.waitUntilExit() - let data = pipe.fileHandleForReading.readToEndSafely() - let output = String(data: data, encoding: .utf8)?.trimmingCharacters(in: .whitespacesAndNewlines) ?? "" - if proc.terminationStatus == 0 { - return output.isEmpty ? "CLI helper linked into \(targetList)" : output - } - if output.lowercased().contains("user canceled") { - return "Install canceled" - } - return "Failed to install CLI helper: \(output)" - } catch { - return "Failed to run installer: \(error.localizedDescription)" - } - } - - private static func shellEscape(_ path: String) -> String { - "'" + path.replacingOccurrences(of: "'", with: "'\"'\"'") + "'" } } diff --git a/apps/macos/Sources/Clawdbot/Constants.swift b/apps/macos/Sources/Clawdbot/Constants.swift index 95391deac..b07394489 100644 --- a/apps/macos/Sources/Clawdbot/Constants.swift +++ b/apps/macos/Sources/Clawdbot/Constants.swift @@ -33,8 +33,8 @@ let deepLinkKeyKey = "clawdbot.deepLinkKey" let modelCatalogPathKey = "clawdbot.modelCatalogPath" let modelCatalogReloadKey = "clawdbot.modelCatalogReload" let attachExistingGatewayOnlyKey = "clawdbot.gateway.attachExistingOnly" +let cliInstallPromptedVersionKey = "clawdbot.cliInstallPromptedVersion" let heartbeatsEnabledKey = "clawdbot.heartbeatsEnabled" let debugFileLogEnabledKey = "clawdbot.debug.fileLogEnabled" let appLogLevelKey = "clawdbot.debug.appLogLevel" let voiceWakeSupported: Bool = ProcessInfo.processInfo.operatingSystemVersion.majorVersion >= 26 -let cliHelperSearchPaths = ["/usr/local/bin", "/opt/homebrew/bin"] diff --git a/apps/macos/Sources/Clawdbot/DebugSettings.swift b/apps/macos/Sources/Clawdbot/DebugSettings.swift index 2ab0d3203..411067d7c 100644 --- a/apps/macos/Sources/Clawdbot/DebugSettings.swift +++ b/apps/macos/Sources/Clawdbot/DebugSettings.swift @@ -107,7 +107,7 @@ struct DebugSettings: View { .frame(maxWidth: .infinity, alignment: .leading) } GridRow { - self.gridLabel("CLI helper") + self.gridLabel("CLI") let loc = CLIInstaller.installedLocation() Text(loc ?? "missing") .font(.caption.monospaced()) diff --git a/apps/macos/Sources/Clawdbot/GatewayEnvironment.swift b/apps/macos/Sources/Clawdbot/GatewayEnvironment.swift index b9e6e9e97..9397c5c77 100644 --- a/apps/macos/Sources/Clawdbot/GatewayEnvironment.swift +++ b/apps/macos/Sources/Clawdbot/GatewayEnvironment.swift @@ -64,19 +64,6 @@ struct GatewayCommandResolution { enum GatewayEnvironment { private static let logger = Logger(subsystem: "com.clawdbot", category: "gateway.env") private static let supportedBindModes: Set = ["loopback", "tailnet", "lan", "auto"] - private static let bundledGatewayLabel = "Bundled gateway" - - static func bundledGatewayExecutable() -> String? { - guard let res = Bundle.main.resourceURL else { return nil } - let path = res.appendingPathComponent("Relay/clawdbot").path - return FileManager.default.isExecutableFile(atPath: path) ? path : nil - } - - static func bundledNodeExecutable() -> String? { - guard let res = Bundle.main.resourceURL else { return nil } - let path = res.appendingPathComponent("Relay/node").path - return FileManager.default.isExecutableFile(atPath: path) ? path : nil - } static func gatewayPort() -> Int { if let raw = ProcessInfo.processInfo.environment["CLAWDBOT_GATEWAY_PORT"] { @@ -112,32 +99,6 @@ enum GatewayEnvironment { } let expected = self.expectedGatewayVersion() - if let bundled = self.bundledGatewayExecutable() { - let installed = self.readGatewayVersion(binary: bundled) - let bundledNode = self.bundledNodeExecutable() - let bundledNodeVersion = bundledNode.flatMap { self.readNodeVersion(binary: $0) } - if let expected, let installed, !installed.compatible(with: expected) { - let message = self.bundledGatewayIncompatibleMessage( - installed: installed, - expected: expected) - return GatewayEnvironmentStatus( - kind: .incompatible(found: installed.description, required: expected.description), - nodeVersion: bundledNodeVersion, - gatewayVersion: installed.description, - requiredGateway: expected.description, - message: message) - } - let gatewayVersionText = installed?.description ?? "unknown" - return GatewayEnvironmentStatus( - kind: .ok, - nodeVersion: bundledNodeVersion, - gatewayVersion: gatewayVersionText, - requiredGateway: expected?.description, - message: self.bundledGatewayStatusMessage( - gatewayVersion: gatewayVersionText, - nodeVersion: bundledNodeVersion)) - } - let projectRoot = CommandResolver.projectRoot() let projectEntrypoint = CommandResolver.gatewayEntrypoint(in: projectRoot) @@ -208,7 +169,6 @@ enum GatewayEnvironment { let projectEntrypoint = CommandResolver.gatewayEntrypoint(in: projectRoot) let status = self.check() let gatewayBin = CommandResolver.clawdbotExecutable() - let bundled = self.bundledGatewayExecutable() let runtime = RuntimeLocator.resolve(searchPaths: CommandResolver.preferredPaths()) guard case .ok = status.kind else { @@ -216,20 +176,17 @@ enum GatewayEnvironment { } let port = self.gatewayPort() - if let bundled { - let bind = self.preferredGatewayBind() ?? "loopback" - let cmd = [bundled, "gateway-daemon", "--port", "\(port)", "--bind", bind] - return GatewayCommandResolution(status: status, command: cmd) - } if let gatewayBin { - let cmd = [gatewayBin, "gateway", "--port", "\(port)"] + let bind = self.preferredGatewayBind() ?? "loopback" + let cmd = [gatewayBin, "gateway-daemon", "--port", "\(port)", "--bind", bind] return GatewayCommandResolution(status: status, command: cmd) } if let entry = projectEntrypoint, case let .success(resolvedRuntime) = runtime { - let cmd = [resolvedRuntime.path, entry, "gateway", "--port", "\(port)"] + let bind = self.preferredGatewayBind() ?? "loopback" + let cmd = [resolvedRuntime.path, entry, "gateway-daemon", "--port", "\(port)", "--bind", bind] return GatewayCommandResolution(status: status, command: cmd) } @@ -363,40 +320,4 @@ enum GatewayEnvironment { return Semver.parse(version) } - private static func readNodeVersion(binary: String) -> String? { - let process = Process() - process.executableURL = URL(fileURLWithPath: binary) - process.arguments = ["--version"] - process.environment = ["PATH": CommandResolver.preferredPaths().joined(separator: ":")] - - let pipe = Pipe() - process.standardOutput = pipe - process.standardError = pipe - do { - try process.run() - process.waitUntilExit() - let data = pipe.fileHandleForReading.readToEndSafely() - let raw = String(data: data, encoding: .utf8)? - .trimmingCharacters(in: .whitespacesAndNewlines) - .replacingOccurrences(of: "^v", with: "", options: .regularExpression) - return raw?.isEmpty == false ? raw : nil - } catch { - return nil - } - } - - private static func bundledGatewayStatusMessage( - gatewayVersion: String, - nodeVersion: String?) -> String - { - "\(self.bundledGatewayLabel) \(gatewayVersion) (node \(nodeVersion ?? "unknown"))" - } - - private static func bundledGatewayIncompatibleMessage( - installed: Semver, - expected: Semver) -> String - { - "\(self.bundledGatewayLabel) \(installed.description) is incompatible with app " + - "\(expected.description); rebuild the app bundle." - } } diff --git a/apps/macos/Sources/Clawdbot/GatewayLaunchAgentManager.swift b/apps/macos/Sources/Clawdbot/GatewayLaunchAgentManager.swift index bcb9f49de..32dada0d0 100644 --- a/apps/macos/Sources/Clawdbot/GatewayLaunchAgentManager.swift +++ b/apps/macos/Sources/Clawdbot/GatewayLaunchAgentManager.swift @@ -16,32 +16,41 @@ enum GatewayLaunchAgentManager { .appendingPathComponent("Library/LaunchAgents/\(legacyGatewayLaunchdLabel).plist") } - private static func gatewayExecutablePath(bundlePath: String) -> String { - "\(bundlePath)/Contents/Resources/Relay/clawdbot" - } - - private static func relayDir(bundlePath: String) -> String { - "\(bundlePath)/Contents/Resources/Relay" - } - - private static func gatewayProgramArguments(bundlePath: String, port: Int, bind: String) -> [String] { + private static func gatewayProgramArguments(port: Int, bind: String) -> Result<[String], String> { #if DEBUG let projectRoot = CommandResolver.projectRoot() if let localBin = CommandResolver.projectClawdbotExecutable(projectRoot: projectRoot) { - return [localBin, "gateway", "--port", "\(port)", "--bind", bind] + return .success([localBin, "gateway-daemon", "--port", "\(port)", "--bind", bind]) } if let entry = CommandResolver.gatewayEntrypoint(in: projectRoot), case let .success(runtime) = CommandResolver.runtimeResolution() { - return CommandResolver.makeRuntimeCommand( + let cmd = CommandResolver.makeRuntimeCommand( runtime: runtime, entrypoint: entry, - subcommand: "gateway", + subcommand: "gateway-daemon", extraArgs: ["--port", "\(port)", "--bind", bind]) + return .success(cmd) } #endif - let gatewayBin = self.gatewayExecutablePath(bundlePath: bundlePath) - return [gatewayBin, "gateway-daemon", "--port", "\(port)", "--bind", bind] + let searchPaths = CommandResolver.preferredPaths() + if let gatewayBin = CommandResolver.clawdbotExecutable(searchPaths: searchPaths) { + return .success([gatewayBin, "gateway-daemon", "--port", "\(port)", "--bind", bind]) + } + + let projectRoot = CommandResolver.projectRoot() + if let entry = CommandResolver.gatewayEntrypoint(in: projectRoot), + case let .success(runtime) = CommandResolver.runtimeResolution(searchPaths: searchPaths) + { + let cmd = CommandResolver.makeRuntimeCommand( + runtime: runtime, + entrypoint: entry, + subcommand: "gateway-daemon", + extraArgs: ["--port", "\(port)", "--bind", bind]) + return .success(cmd) + } + + return .failure("clawdbot CLI not found in PATH; install the global package.") } static func isLoaded() async -> Bool { @@ -51,6 +60,7 @@ enum GatewayLaunchAgentManager { } static func set(enabled: Bool, bundlePath: String, port: Int) async -> String? { + _ = bundlePath if enabled, self.isLaunchAgentWriteDisabled() { self.logger.info("launchd enable skipped (attach-only or disable marker set)") return nil @@ -58,11 +68,6 @@ enum GatewayLaunchAgentManager { if enabled { _ = await Launchctl.run(["bootout", "gui/\(getuid())/\(self.legacyGatewayLaunchdLabel)"]) try? FileManager.default.removeItem(at: self.legacyPlistURL) - let gatewayBin = self.gatewayExecutablePath(bundlePath: bundlePath) - guard FileManager.default.isExecutableFile(atPath: gatewayBin) else { - self.logger.error("launchd enable failed: gateway missing at \(gatewayBin)") - return "Embedded gateway missing in bundle; rebuild via scripts/package-mac-app.sh" - } let desiredBind = self.preferredGatewayBind() ?? "loopback" let desiredToken = self.preferredGatewayToken() @@ -72,6 +77,14 @@ enum GatewayLaunchAgentManager { bind: desiredBind, token: desiredToken, password: desiredPassword) + let programArgumentsResult = self.gatewayProgramArguments(port: port, bind: desiredBind) + guard case let .success(programArguments) = programArgumentsResult else { + if case let .failure(message) = programArgumentsResult { + self.logger.error("launchd enable failed: \(message)") + return message + } + return "Failed to resolve gateway command." + } // If launchd already loaded the job (common on login), avoid `bootout` unless we must // change the config. `bootout` can kill a just-started gateway and cause attach loops. @@ -87,7 +100,7 @@ enum GatewayLaunchAgentManager { } self.logger.info("launchd enable requested port=\(port) bind=\(desiredBind)") - self.writePlist(bundlePath: bundlePath, port: port) + self.writePlist(programArguments: programArguments) await self.ensureEnabled() if loaded { @@ -117,18 +130,13 @@ enum GatewayLaunchAgentManager { } private static func writePlist(bundlePath: String, port: Int) { - let relayDir = self.relayDir(bundlePath: bundlePath) - let preferredPath = ([relayDir] + CommandResolver.preferredPaths()) - .joined(separator: ":") - let bind = self.preferredGatewayBind() ?? "loopback" - let programArguments = self.gatewayProgramArguments(bundlePath: bundlePath, port: port, bind: bind) + private static func writePlist(programArguments: [String]) { + let preferredPath = CommandResolver.preferredPaths().joined(separator: ":") let token = self.preferredGatewayToken() let password = self.preferredGatewayPassword() var envEntries = """ PATH \(preferredPath) - CLAWDBOT_IMAGE_BACKEND - sips """ if let token { let escapedToken = self.escapePlistValue(token) @@ -319,14 +327,6 @@ extension GatewayLaunchAgentManager { #if DEBUG extension GatewayLaunchAgentManager { - static func _testGatewayExecutablePath(bundlePath: String) -> String { - self.gatewayExecutablePath(bundlePath: bundlePath) - } - - static func _testRelayDir(bundlePath: String) -> String { - self.relayDir(bundlePath: bundlePath) - } - static func _testPreferredGatewayBind() -> String? { self.preferredGatewayBind() } diff --git a/apps/macos/Sources/Clawdbot/GeneralSettings.swift b/apps/macos/Sources/Clawdbot/GeneralSettings.swift index 327b3ceb2..08375695e 100644 --- a/apps/macos/Sources/Clawdbot/GeneralSettings.swift +++ b/apps/macos/Sources/Clawdbot/GeneralSettings.swift @@ -354,7 +354,7 @@ struct GeneralSettings: View { Button { Task { await self.installCLI() } } label: { - let title = self.cliInstalled ? "Reinstall CLI helper" : "Install CLI helper" + let title = self.cliInstalled ? "Reinstall CLI" : "Install CLI" ZStack { Text(title) .opacity(self.isInstallingCLI ? 0 : 1) @@ -393,7 +393,7 @@ struct GeneralSettings: View { .foregroundStyle(.secondary) .lineLimit(2) } else { - Text("Symlink \"clawdbot\" into /usr/local/bin and /opt/homebrew/bin for scripts.") + Text("Installs via npm/pnpm/bun; requires Node 22+.") .font(.caption) .foregroundStyle(.secondary) .lineLimit(2) diff --git a/apps/macos/Sources/Clawdbot/LogLocator.swift b/apps/macos/Sources/Clawdbot/LogLocator.swift index d17395417..b49e58f9c 100644 --- a/apps/macos/Sources/Clawdbot/LogLocator.swift +++ b/apps/macos/Sources/Clawdbot/LogLocator.swift @@ -29,7 +29,7 @@ enum LogLocator { stdoutLog.path } - /// Path to use for the embedded Gateway launchd job stdout/err. + /// Path to use for the Gateway launchd job stdout/err. static var launchdGatewayLogPath: String { gatewayLog.path } diff --git a/apps/macos/Sources/Clawdbot/MenuBar.swift b/apps/macos/Sources/Clawdbot/MenuBar.swift index 8812575ed..696322648 100644 --- a/apps/macos/Sources/Clawdbot/MenuBar.swift +++ b/apps/macos/Sources/Clawdbot/MenuBar.swift @@ -70,6 +70,7 @@ struct ClawdbotApp: App { } .onChange(of: self.state.connectionMode) { _, mode in Task { await ConnectionModeCoordinator.shared.apply(mode: mode, paused: self.state.isPaused) } + CLIInstallPrompter.shared.checkAndPromptIfNeeded(reason: "connection-mode") } Settings { @@ -262,6 +263,9 @@ final class AppDelegate: NSObject, NSApplicationDelegate { Task { await PortGuardian.shared.sweep(mode: AppStateStore.shared.connectionMode) } Task { await PeekabooBridgeHostCoordinator.shared.setEnabled(AppStateStore.shared.peekabooBridgeEnabled) } self.scheduleFirstRunOnboardingIfNeeded() + DispatchQueue.main.asyncAfter(deadline: .now() + 1.0) { + CLIInstallPrompter.shared.checkAndPromptIfNeeded(reason: "launch") + } // Developer/testing helper: auto-open chat when launched with --chat (or legacy --webchat). if CommandLine.arguments.contains("--chat") || CommandLine.arguments.contains("--webchat") { diff --git a/apps/macos/Sources/Clawdbot/Onboarding.swift b/apps/macos/Sources/Clawdbot/Onboarding.swift index 0271912c5..86e039926 100644 --- a/apps/macos/Sources/Clawdbot/Onboarding.swift +++ b/apps/macos/Sources/Clawdbot/Onboarding.swift @@ -151,8 +151,8 @@ struct OnboardingView: View { var canAdvance: Bool { !self.isWizardBlocking } var devLinkCommand: String { - let bundlePath = Bundle.main.bundlePath - return "ln -sf '\(bundlePath)/Contents/Resources/Relay/clawdbot' /usr/local/bin/clawdbot" + let version = GatewayEnvironment.expectedGatewayVersion()?.description ?? "latest" + return "npm install -g clawdbot@\(version)" } struct LocalGatewayProbe: Equatable { diff --git a/apps/macos/Sources/Clawdbot/OnboardingView+Pages.swift b/apps/macos/Sources/Clawdbot/OnboardingView+Pages.swift index e6e902113..f415314f0 100644 --- a/apps/macos/Sources/Clawdbot/OnboardingView+Pages.swift +++ b/apps/macos/Sources/Clawdbot/OnboardingView+Pages.swift @@ -494,9 +494,9 @@ extension OnboardingView { func cliPage() -> some View { self.onboardingPage { - Text("Install the helper CLI") + Text("Install the CLI") .font(.largeTitle.weight(.semibold)) - Text("Optional, but recommended: link `clawdbot` so scripts can reach the local gateway.") + Text("Required for local mode: installs `clawdbot` so launchd can run the gateway.") .font(.body) .foregroundStyle(.secondary) .multilineTextAlignment(.center) @@ -522,7 +522,7 @@ extension OnboardingView { .buttonStyle(.borderedProminent) .disabled(self.installingCLI) - Button(self.copied ? "Copied" : "Copy dev link") { + Button(self.copied ? "Copied" : "Copy install command") { self.copyToPasteboard(self.devLinkCommand) } .disabled(self.installingCLI) @@ -541,8 +541,8 @@ extension OnboardingView { } else if !self.cliInstalled, self.cliInstallLocation == nil { Text( """ - We install into /usr/local/bin and /opt/homebrew/bin. - Rerun anytime if you move the build output. + Uses npm/pnpm/bun. Requires Node 22+ on this Mac. + Rerun anytime to reinstall or update. """) .font(.footnote) .foregroundStyle(.secondary) diff --git a/apps/macos/Tests/ClawdbotIPCTests/CLIInstallerTests.swift b/apps/macos/Tests/ClawdbotIPCTests/CLIInstallerTests.swift index 01930fb83..829dd28a4 100644 --- a/apps/macos/Tests/ClawdbotIPCTests/CLIInstallerTests.swift +++ b/apps/macos/Tests/ClawdbotIPCTests/CLIInstallerTests.swift @@ -5,39 +5,30 @@ import Testing @Suite(.serialized) @MainActor struct CLIInstallerTests { - @Test func installedLocationOnlyAcceptsEmbeddedHelper() throws { + @Test func installedLocationFindsExecutable() throws { let fm = FileManager.default let root = fm.temporaryDirectory.appendingPathComponent( "clawdbot-cli-installer-\(UUID().uuidString)") defer { try? fm.removeItem(at: root) } - let embedded = root.appendingPathComponent("Relay/clawdbot") - try fm.createDirectory(at: embedded.deletingLastPathComponent(), withIntermediateDirectories: true) - fm.createFile(atPath: embedded.path, contents: Data()) - try fm.setAttributes([.posixPermissions: 0o755], ofItemAtPath: embedded.path) - let binDir = root.appendingPathComponent("bin") try fm.createDirectory(at: binDir, withIntermediateDirectories: true) - let link = binDir.appendingPathComponent("clawdbot") - try fm.createSymbolicLink(at: link, withDestinationURL: embedded) + let cli = binDir.appendingPathComponent("clawdbot") + fm.createFile(atPath: cli.path, contents: Data()) + try fm.setAttributes([.posixPermissions: 0o755], ofItemAtPath: cli.path) let found = CLIInstaller.installedLocation( searchPaths: [binDir.path], - embeddedHelper: embedded, fileManager: fm) - #expect(found == link.path) + #expect(found == cli.path) - try fm.removeItem(at: link) - let other = root.appendingPathComponent("Other/clawdbot") - try fm.createDirectory(at: other.deletingLastPathComponent(), withIntermediateDirectories: true) - fm.createFile(atPath: other.path, contents: Data()) - try fm.setAttributes([.posixPermissions: 0o755], ofItemAtPath: other.path) - try fm.createSymbolicLink(at: link, withDestinationURL: other) + try fm.removeItem(at: cli) + fm.createFile(atPath: cli.path, contents: Data()) + try fm.setAttributes([.posixPermissions: 0o644], ofItemAtPath: cli.path) - let rejected = CLIInstaller.installedLocation( + let missing = CLIInstaller.installedLocation( searchPaths: [binDir.path], - embeddedHelper: embedded, fileManager: fm) - #expect(rejected == nil) + #expect(missing == nil) } } diff --git a/apps/macos/Tests/ClawdbotIPCTests/LowCoverageHelperTests.swift b/apps/macos/Tests/ClawdbotIPCTests/LowCoverageHelperTests.swift index 11bd5a885..d120105f1 100644 --- a/apps/macos/Tests/ClawdbotIPCTests/LowCoverageHelperTests.swift +++ b/apps/macos/Tests/ClawdbotIPCTests/LowCoverageHelperTests.swift @@ -123,10 +123,6 @@ struct LowCoverageHelperTests { #expect( GatewayLaunchAgentManager._testEscapePlistValue("a&b\"'") == "a&b<c>"'") - - #expect(GatewayLaunchAgentManager - ._testGatewayExecutablePath(bundlePath: "/App") == "/App/Contents/Resources/Relay/clawdbot") - #expect(GatewayLaunchAgentManager._testRelayDir(bundlePath: "/App") == "/App/Contents/Resources/Relay") } } diff --git a/docs/gateway/troubleshooting.md b/docs/gateway/troubleshooting.md index 104cc645d..0b52d380a 100644 --- a/docs/gateway/troubleshooting.md +++ b/docs/gateway/troubleshooting.md @@ -339,8 +339,12 @@ sleep 1 kill -9 # last resort ``` -**Fix 3: Check embedded gateway** -Ensure the gateway relay was properly bundled. Run [`./scripts/package-mac-app.sh`](https://github.com/clawdbot/clawdbot/blob/main/scripts/package-mac-app.sh) and ensure Node is available (the script downloads a bundled runtime by default). +**Fix 3: Check the CLI install** +Ensure the global `clawdbot` CLI is installed and matches the app version: +```bash +clawdbot --version +npm install -g clawdbot@ +``` ## Debug Mode diff --git a/docs/platforms/mac/bundled-gateway.md b/docs/platforms/mac/bundled-gateway.md index dc25cd0df..79758b9f0 100644 --- a/docs/platforms/mac/bundled-gateway.md +++ b/docs/platforms/mac/bundled-gateway.md @@ -1,118 +1,63 @@ --- -summary: "Bundled gateway runtime: packaging, launchd, signing, and bundling" +summary: "Gateway runtime on macOS (external launchd service)" read_when: - Packaging Clawdbot.app - - Debugging the bundled gateway binary - - Changing relay bundling flags or codesigning + - Debugging the macOS gateway launchd service + - Installing the gateway CLI for macOS --- -# Bundled Gateway (macOS) +# Gateway on macOS (external launchd) -Goal: ship **Clawdbot.app** with a self-contained relay that can run the CLI and -Gateway daemon. No global `npm install -g clawdbot`, no system Node requirement. +Clawdbot.app no longer bundles Node/Bun or the Gateway runtime. The macOS app +expects an **external** `clawdbot` CLI install and manages a per‑user launchd +service to keep the Gateway running. -## What gets bundled +## Install the CLI (required for local mode) -App bundle layout: +You need Node 22+ on the Mac, then install `clawdbot` globally: -- `Clawdbot.app/Contents/Resources/Relay/node` - - Node runtime binary (downloaded during packaging, stripped for size) -- `Clawdbot.app/Contents/Resources/Relay/dist/` - - Compiled CLI/gateway payload from `pnpm exec tsc` -- `Clawdbot.app/Contents/Resources/Relay/node_modules/` - - Production dependencies staged via `pnpm deploy --prod --legacy` (includes optional native addons) -- `Clawdbot.app/Contents/Resources/Relay/clawdbot` - - Wrapper script that execs the bundled Node + dist entrypoint -- `Clawdbot.app/Contents/Resources/Relay/package.json` - - tiny “Pi runtime compatibility” file (see below, includes `"type": "module"`) -- `Clawdbot.app/Contents/Resources/Relay/skills/` - - Bundled skills payload (required for Pi tools) -- `Clawdbot.app/Contents/Resources/Relay/theme/` - - Pi TUI theme payload (optional, but strongly recommended) -- `Clawdbot.app/Contents/Resources/Relay/a2ui/` - - A2UI host assets (served by the gateway) -- `Clawdbot.app/Contents/Resources/Relay/control-ui/` - - Control UI build output (served by the gateway) +```bash +npm install -g clawdbot@ +``` -Why the sidecar files matter: -- The embedded Pi runtime detects “bundled relay mode” and then looks for - `package.json` + `theme/` **next to `process.execPath`** (i.e. next to - `node`). Keep the sidecar files. - -## Build pipeline - -Packaging script: -- [`scripts/package-mac-app.sh`](https://github.com/clawdbot/clawdbot/blob/main/scripts/package-mac-app.sh) - -It builds: -- TS: `pnpm exec tsc` -- Swift app + helper: `swift build …` -- Relay payload: `pnpm deploy --prod --legacy` + copy `dist/` -- Node runtime: downloads the latest Node release (override via `NODE_VERSION`) - -Important knobs: -- `NODE_VERSION=22.12.0` → pin a specific Node version -- `NODE_DIST_MIRROR=…` → mirror for downloads (default: nodejs.org) -- `STRIP_NODE=0` → keep symbols (default strips to reduce size) -- `BUNDLED_RUNTIME=bun` → switch the relay build back to Bun (`bun --compile`) - -Version injection: -- The relay wrapper exports `CLAWDBOT_BUNDLED_VERSION` so `--version` works - without reading `package.json` at runtime. +The macOS app’s **Install CLI** button runs the same flow via npm/pnpm/bun. ## Launchd (Gateway as LaunchAgent) Label: - `com.clawdbot.gateway` (or `com.clawdbot.`) -Plist location (per-user): -- `~/Library/LaunchAgents/com.clawdbot.gateway.plist` (or `.../com.clawdbot..plist`) +Plist location (per‑user): +- `~/Library/LaunchAgents/com.clawdbot.gateway.plist` Manager: -- The macOS app owns LaunchAgent install/update for the bundled gateway. +- The macOS app owns LaunchAgent install/update in Local mode. +- The CLI can also install it: `clawdbot daemon install`. Behavior: - “Clawdbot Active” enables/disables the LaunchAgent. - App quit does **not** stop the gateway (launchd keeps it alive). -- CLI install (`clawdbot daemon install`) writes the same LaunchAgent; `--force` rewrites it. Logging: - launchd stdout/err: `/tmp/clawdbot/clawdbot-gateway.log` -Default LaunchAgent env: -- `CLAWDBOT_IMAGE_BACKEND=sips` (avoid sharp native addon inside the bundle) +## Version compatibility -## Codesigning (hardened runtime + Node) +The macOS app checks the gateway version against its own version. If they’re +incompatible, update the global CLI to match the app version. -Node uses JIT. The bundled runtime is signed with: -- `com.apple.security.cs.allow-jit` -- `com.apple.security.cs.allow-unsigned-executable-memory` - -This is applied by `scripts/codesign-mac-app.sh`. - -Note: because the relay runs under hardened runtime, any bundled `*.node` native -addons must be signed with the same Team ID as the relay `node` binary. -`scripts/codesign-mac-app.sh` re-signs `Contents/Resources/Relay/**/*.node` for this. - -## Image processing - -To avoid shipping native `sharp` addons inside the bundle, the gateway defaults -to `/usr/bin/sips` for image ops when run from the app (via launchd env + wrapper). - -## Tests / smoke checks - -From a packaged app (local build): +## Smoke check ```bash -dist/Clawdbot.app/Contents/Resources/Relay/clawdbot --version +clawdbot --version CLAWDBOT_SKIP_PROVIDERS=1 \ CLAWDBOT_SKIP_CANVAS_HOST=1 \ -dist/Clawdbot.app/Contents/Resources/Relay/clawdbot gateway --port 18999 --bind loopback +clawdbot gateway --port 18999 --bind loopback ``` -Then, in another shell: +Then: ```bash -pnpm -s clawdbot gateway call health --url ws://127.0.0.1:18999 --timeout 3000 +clawdbot gateway call health --url ws://127.0.0.1:18999 --timeout 3000 ``` diff --git a/docs/platforms/mac/child-process.md b/docs/platforms/mac/child-process.md index 36219b636..28910ce8a 100644 --- a/docs/platforms/mac/child-process.md +++ b/docs/platforms/mac/child-process.md @@ -5,8 +5,9 @@ read_when: --- # Gateway lifecycle on macOS -The macOS app **manages the Gateway via launchd** by default. This gives you -reliable auto‑start at login and restart on crashes. +The macOS app **manages the Gateway via launchd** by default. The launchd job +uses the external `clawdbot` CLI (no embedded runtime). This gives you reliable +auto‑start at login and restart on crashes. Child‑process mode (Gateway spawned directly by the app) is **not in use** today. If you need tighter coupling to the UI, use **Attach‑only** and run the Gateway diff --git a/docs/platforms/mac/dev-setup.md b/docs/platforms/mac/dev-setup.md index d643e2324..514a19f0b 100644 --- a/docs/platforms/mac/dev-setup.md +++ b/docs/platforms/mac/dev-setup.md @@ -12,8 +12,7 @@ This guide covers the necessary steps to build and run the Clawdbot macOS applic Before building the app, ensure you have the following installed: 1. **Xcode 26.2+**: Required for Swift development. -2. **Node.js & pnpm**: Required for the gateway and CLI components. -3. **Node**: Required to package the embedded gateway relay (the script can download a bundled runtime). +2. **Node.js 22+ & pnpm**: Required for the gateway, CLI, and packaging scripts. ## 1. Initialize Submodules @@ -39,24 +38,22 @@ To build the macOS app and package it into `dist/Clawdbot.app`, run: ./scripts/package-mac-app.sh ``` -Use `BUNDLED_RUNTIME=node|bun` to switch the embedded gateway runtime (default: node). - If you don't have an Apple Developer ID certificate, the script will automatically use **ad-hoc signing** (`-`). > **Note**: Ad-hoc signed apps may trigger security prompts. If the app crashes immediately with "Abort trap 6", see the [Troubleshooting](#troubleshooting) section. -## 4. Install the CLI Helper +## 4. Install the CLI -The macOS app requires a symlink named `clawdbot` in `/usr/local/bin` or `/opt/homebrew/bin` to manage background tasks. +The macOS app expects a global `clawdbot` CLI install to manage background tasks. -**To install it:** +**To install it (recommended):** 1. Open the Clawdbot app. 2. Go to the **General** settings tab. -3. Click **"Install CLI helper"** (requires administrator privileges). +3. Click **"Install CLI"**. -Alternatively, you can manually link it from your Admin account: +Alternatively, install it manually: ```bash -sudo ln -sf "/Users/$(whoami)/Projects/clawdbot/dist/Clawdbot.app/Contents/Resources/Relay/clawdbot" /usr/local/bin/clawdbot +npm install -g clawdbot@ ``` ## Troubleshooting diff --git a/docs/platforms/mac/signing.md b/docs/platforms/mac/signing.md index 100377064..a1bdfbbac 100644 --- a/docs/platforms/mac/signing.md +++ b/docs/platforms/mac/signing.md @@ -9,10 +9,10 @@ This app is usually built from [`scripts/package-mac-app.sh`](https://github.com - sets a stable debug bundle identifier: `com.clawdbot.mac.debug` - writes the Info.plist with that bundle id (override via `BUNDLE_ID=...`) -- calls [`scripts/codesign-mac-app.sh`](https://github.com/clawdbot/clawdbot/blob/main/scripts/codesign-mac-app.sh) to sign the main binary, bundled CLI, and app bundle so macOS treats each rebuild as the same signed bundle and keeps TCC permissions (notifications, accessibility, screen recording, mic, speech). For stable permissions, use a real signing identity; ad-hoc is opt-in and fragile (see [macOS permissions](/platforms/mac/permissions)). +- calls [`scripts/codesign-mac-app.sh`](https://github.com/clawdbot/clawdbot/blob/main/scripts/codesign-mac-app.sh) to sign the main binary and app bundle so macOS treats each rebuild as the same signed bundle and keeps TCC permissions (notifications, accessibility, screen recording, mic, speech). For stable permissions, use a real signing identity; ad-hoc is opt-in and fragile (see [macOS permissions](/platforms/mac/permissions)). - uses `CODESIGN_TIMESTAMP=auto` by default; it enables trusted timestamps for Developer ID signatures. Set `CODESIGN_TIMESTAMP=off` to skip timestamping (offline debug builds). - inject build metadata into Info.plist: `ClawdbotBuildTimestamp` (UTC) and `ClawdbotGitCommit` (short hash) so the About pane can show build, git, and debug/release channel. -- **Packaging requires Node**: The embedded gateway relay is bundled with Node. Ensure Node is available for the packaging script (or set `NODE_VERSION` to pin the download). +- **Packaging requires Node 22+**: the script runs TS builds and the Control UI build. - reads `SIGN_IDENTITY` from the environment. Add `export SIGN_IDENTITY="Apple Development: Your Name (TEAMID)"` (or your Developer ID Application cert) to your shell rc to always sign with your cert. Ad-hoc signing requires explicit opt-in via `ALLOW_ADHOC_SIGNING=1` or `SIGN_IDENTITY="-"` (not recommended for permission testing). ## Usage diff --git a/docs/platforms/macos.md b/docs/platforms/macos.md index 37499bb5a..5eea70548 100644 --- a/docs/platforms/macos.md +++ b/docs/platforms/macos.md @@ -18,8 +18,7 @@ node. - Runs or connects to the Gateway (local or remote). - Exposes macOS‑only tools (Canvas, Camera, Screen Recording, `system.run`). - Optionally hosts **PeekabooBridge** for UI automation. -- Installs a helper CLI (`clawdbot`) into `/usr/local/bin` and - `/opt/homebrew/bin` on request. +- Installs the global CLI (`clawdbot`) via npm/pnpm/bun on request. ## Local vs remote mode @@ -84,14 +83,13 @@ Safety: 1) Install and launch **Clawdbot.app**. 2) Complete the permissions checklist (TCC prompts). 3) Ensure **Local** mode is active and the Gateway is running. -4) Install the CLI helper if you want terminal access. +4) Install the CLI if you want terminal access. ## Build & dev workflow (native) - `cd apps/macos && swift build` - `swift run Clawdbot` (or Xcode) -- Package app + CLI: `scripts/package-mac-app.sh` - - Switch bundled gateway runtime with `BUNDLED_RUNTIME=node|bun` (default: node). +- Package app: `scripts/package-mac-app.sh` ## Debug gateway discovery (macOS CLI) @@ -115,6 +113,6 @@ the Node CLI’s `dns-sd` based discovery. ## Related docs - [Gateway runbook](/gateway) -- [Bundled Node Gateway](/platforms/mac/bundled-gateway) +- [Gateway (macOS)](/platforms/mac/bundled-gateway) - [macOS permissions](/platforms/mac/permissions) - [Canvas](/platforms/mac/canvas) diff --git a/docs/start/hubs.md b/docs/start/hubs.md index 17d3a89da..7802fd9b7 100644 --- a/docs/start/hubs.md +++ b/docs/start/hubs.md @@ -143,7 +143,7 @@ Use these hubs to discover every page, including deep dives and reference docs t - [macOS remote](/platforms/mac/remote) - [macOS signing](/platforms/mac/signing) - [macOS release](/platforms/mac/release) -- [macOS bundled gateway (Node)](/platforms/mac/bundled-gateway) +- [macOS gateway (launchd)](/platforms/mac/bundled-gateway) - [macOS XPC](/platforms/mac/xpc) - [macOS skills](/platforms/mac/skills) - [macOS Peekaboo](/platforms/mac/peekaboo) diff --git a/docs/start/onboarding.md b/docs/start/onboarding.md index 933cd94b3..6be8c3124 100644 --- a/docs/start/onboarding.md +++ b/docs/start/onboarding.md @@ -17,7 +17,7 @@ wizard, and let the agent bootstrap itself. 3) **Auth (Anthropic OAuth)** — local only 4) **Setup Wizard** (Gateway‑driven) 5) **Permissions** (TCC prompts) -6) **CLI helper** (optional) +6) **CLI** (optional) 7) **Onboarding chat** (dedicated session) 8) Ready @@ -62,10 +62,10 @@ Onboarding requests TCC permissions needed for: - Microphone / Speech Recognition - Automation (AppleScript) -## 5) CLI helper (optional) +## 5) CLI (optional) -The app can symlink the bundled `clawdbot` CLI into `/usr/local/bin` and -`/opt/homebrew/bin` so terminal workflows work out of the box. +The app can install the global `clawdbot` CLI via npm/pnpm/bun so terminal +workflows and launchd tasks work out of the box. ## 6) Onboarding chat (dedicated session) diff --git a/docs/tools/browser.md b/docs/tools/browser.md index 5684d4522..690c3b640 100644 --- a/docs/tools/browser.md +++ b/docs/tools/browser.md @@ -157,8 +157,8 @@ All endpoints accept `?profile=`. ### Playwright requirement Some features (navigate/act/ai snapshot, element screenshots, PDF) require -Playwright. In embedded gateway builds, Playwright may be unavailable; those -endpoints return a clear 501 error. ARIA snapshots and basic screenshots still work. +Playwright. If Playwright isn’t installed, those endpoints return a clear 501 +error. ARIA snapshots and basic screenshots still work. ## How it works (internal) diff --git a/scripts/package-mac-app.sh b/scripts/package-mac-app.sh index e9b45c686..092bf0c02 100755 --- a/scripts/package-mac-app.sh +++ b/scripts/package-mac-app.sh @@ -22,7 +22,6 @@ if [[ "${BUILD_ARCHS_VALUE}" == "all" ]]; then fi IFS=' ' read -r -a BUILD_ARCHS <<< "$BUILD_ARCHS_VALUE" PRIMARY_ARCH="${BUILD_ARCHS[0]}" -BUNDLED_RUNTIME="${BUNDLED_RUNTIME:-node}" SPARKLE_PUBLIC_ED_KEY="${SPARKLE_PUBLIC_ED_KEY:-AGCY8w5vHirVfGGDGc8Szc5iuOqupZSh9pMj/Qs67XI=}" SPARKLE_FEED_URL="${SPARKLE_FEED_URL:-https://raw.githubusercontent.com/clawdbot/clawdbot/main/appcast.xml}" AUTO_CHECKS=true @@ -108,220 +107,6 @@ merge_framework_machos() { done < <(find "$primary" -type f -print0) } -build_relay_binary() { - local arch="$1" - local out="$2" - local define_arg="__CLAWDBOT_VERSION__=\\\"$PKG_VERSION\\\"" - local bun_bin="bun" - local -a cmd=("$bun_bin" build "$ROOT_DIR/dist/macos/relay.js" --compile --bytecode --outfile "$out" -e electron --define "$define_arg") - if [[ "$arch" == "x86_64" ]]; then - if ! arch -x86_64 /usr/bin/true >/dev/null 2>&1; then - echo "ERROR: Rosetta is required to build the x86_64 relay. Install Rosetta and retry." >&2 - exit 1 - fi - local bun_x86="${BUN_X86_64_BIN:-$HOME/.bun-x64/bun-darwin-x64/bun}" - if [[ ! -x "$bun_x86" ]]; then - bun_x86="$HOME/.bun-x64/bin/bun" - fi - if [[ "$bun_x86" == *baseline* ]]; then - echo "ERROR: x86_64 relay builds are locked to AVX2; baseline Bun is not allowed." >&2 - echo "Set BUN_X86_64_BIN to a non-baseline Bun (bun-darwin-x64)." >&2 - exit 1 - fi - if [[ -x "$bun_x86" ]]; then - cmd=("$bun_x86" build "$ROOT_DIR/dist/macos/relay.js" --compile --bytecode --outfile "$out" -e electron --define "$define_arg") - fi - arch -x86_64 "${cmd[@]}" - else - "${cmd[@]}" - fi -} - -resolve_node_version() { - if [[ -n "${NODE_VERSION:-}" ]]; then - echo "${NODE_VERSION#v}" - return - fi - - local mirror="${NODE_DIST_MIRROR:-https://nodejs.org/dist}" - local latest - if latest="$(/usr/bin/curl -fsSL "$mirror/index.tab" 2>/dev/null | /usr/bin/awk 'NR==2 {print $1}')" && [[ -n "$latest" ]]; then - echo "${latest#v}" - return - fi - - if command -v node >/dev/null 2>&1; then - node -p "process.versions.node" - return - fi - - echo "22.12.0" -} - -node_dist_filename() { - local version="$1" - local arch="$2" - local node_arch="$arch" - if [[ "$arch" == "x86_64" ]]; then - node_arch="x64" - fi - echo "node-v${version}-darwin-${node_arch}.tar.gz" -} - -download_node_binary() { - local version="$1" - local arch="$2" - local out="$3" - local mirror="${NODE_DIST_MIRROR:-https://nodejs.org/dist}" - local tarball - tarball="$(node_dist_filename "$version" "$arch")" - - local tmp_dir - tmp_dir="$(mktemp -d)" - local url="$mirror/v${version}/${tarball}" - echo "⬇️ Downloading Node ${version} (${arch})" - /usr/bin/curl -fsSL "$url" -o "$tmp_dir/node.tgz" - - /usr/bin/tar -xzf "$tmp_dir/node.tgz" -C "$tmp_dir" - local node_arch="$arch" - if [[ "$arch" == "x86_64" ]]; then - node_arch="x64" - fi - local node_src="$tmp_dir/node-v${version}-darwin-${node_arch}/bin/node" - if [[ ! -f "$node_src" ]]; then - echo "ERROR: Node binary missing in $tarball" >&2 - rm -rf "$tmp_dir" - exit 1 - fi - cp "$node_src" "$out" - chmod +x "$out" - rm -rf "$tmp_dir" -} - -stage_relay_deps() { - local relay_dir="$1" - - if [[ "${SKIP_RELAY_DEPS:-0}" == "1" ]]; then - echo "📦 Skipping relay dependency staging (SKIP_RELAY_DEPS=1)" - return - fi - - local stage_dir="$relay_dir/.relay-deploy" - rm -rf "$stage_dir" - mkdir -p "$stage_dir" - echo "📦 Staging relay dependencies (pnpm deploy --prod --legacy)" - (cd "$ROOT_DIR" && pnpm --filter . deploy "$stage_dir" --prod --legacy) - rm -rf "$relay_dir/node_modules" - cp -a "$stage_dir/node_modules" "$relay_dir/node_modules" - rm -rf "$stage_dir" -} - -stage_relay_dist() { - local relay_dir="$1" - echo "📦 Copying relay dist payload" - rm -rf "$relay_dir/dist" - mkdir -p "$relay_dir/dist" - # Only ship runtime JS payload; exclude build artifacts (app/zips/dmgs) to avoid - # recursive bundling and notarization failures. - /usr/bin/rsync -a --delete \ - --exclude 'Clawdbot.app' \ - --exclude 'Clawdbot-*.zip' \ - --exclude 'Clawdbot-*.dmg' \ - --exclude 'Clawdbot-*.notary.zip' \ - --exclude 'Clawdbot-*.dSYM.zip' \ - --exclude 'Clawdbot-*.dSYM' \ - "$ROOT_DIR/dist/" "$relay_dir/dist/" -} - -stage_relay_payload() { - local relay_dir="$1" - stage_relay_deps "$relay_dir" - stage_relay_dist "$relay_dir" -} - -write_relay_wrapper() { - local relay_dir="$1" - local wrapper="$relay_dir/clawdbot" - cat > "$wrapper" </dev/null 2>&1; then - echo "ERROR: bun missing. Install bun or set BUNDLED_RUNTIME=node." >&2 - exit 1 - fi - - echo "🧰 Building bundled relay (bun --compile)" - local relay_build_dir="$relay_dir/.relay-build" - rm -rf "$relay_build_dir" - mkdir -p "$relay_build_dir" - for arch in "${BUILD_ARCHS[@]}"; do - local relay_arch_out="$relay_build_dir/clawdbot-$arch" - build_relay_binary "$arch" "$relay_arch_out" - chmod +x "$relay_arch_out" - done - if [[ "${#BUILD_ARCHS[@]}" -gt 1 ]]; then - /usr/bin/lipo -create "$relay_build_dir"/clawdbot-* -output "$RELAY_CMD" - else - cp "$relay_build_dir/clawdbot-${BUILD_ARCHS[0]}" "$RELAY_CMD" - fi - rm -rf "$relay_build_dir" -} - -package_relay_node() { - local relay_dir="$1" - RELAY_CMD="$relay_dir/clawdbot" - - local node_version - node_version="$(resolve_node_version)" - echo "🧰 Preparing bundled Node runtime (v${node_version})" - local relay_node="$relay_dir/node" - local relay_node_build_dir="$relay_dir/.node-build" - rm -rf "$relay_node_build_dir" - mkdir -p "$relay_node_build_dir" - for arch in "${BUILD_ARCHS[@]}"; do - local node_arch_out="$relay_node_build_dir/node-$arch" - download_node_binary "$node_version" "$arch" "$node_arch_out" - done - if [[ "${#BUILD_ARCHS[@]}" -gt 1 ]]; then - /usr/bin/lipo -create "$relay_node_build_dir"/node-* -output "$relay_node" - else - cp "$relay_node_build_dir/node-${BUILD_ARCHS[0]}" "$relay_node" - fi - chmod +x "$relay_node" - if [[ "${STRIP_NODE:-0}" == "1" ]]; then - /usr/bin/strip -x "$relay_node" 2>/dev/null || true - fi - rm -rf "$relay_node_build_dir" - stage_relay_payload "$relay_dir" - write_relay_wrapper "$relay_dir" -} - -validate_bundled_runtime() { - case "$BUNDLED_RUNTIME" in - node|bun) return 0 ;; - *) - echo "ERROR: Unsupported BUNDLED_RUNTIME=$BUNDLED_RUNTIME (use node|bun)" >&2 - exit 1 - ;; - esac -} - echo "📦 Ensuring deps (pnpm install)" (cd "$ROOT_DIR" && pnpm install --no-frozen-lockfile --config.node-linker=hoisted) if [[ "${SKIP_TSC:-0}" != "1" ]]; then @@ -352,7 +137,6 @@ echo "🧹 Cleaning old app bundle" rm -rf "$APP_ROOT" mkdir -p "$APP_ROOT/Contents/MacOS" mkdir -p "$APP_ROOT/Contents/Resources" -mkdir -p "$APP_ROOT/Contents/Resources/Relay" mkdir -p "$APP_ROOT/Contents/Frameworks" echo "📄 Copying Info.plist template" @@ -432,61 +216,6 @@ else echo "WARN: ClawdbotKit resource bundle not found at $CLAWDBOTKIT_BUNDLE (continuing)" >&2 fi -RELAY_DIR="$APP_ROOT/Contents/Resources/Relay" - -if [[ "${SKIP_GATEWAY_PACKAGE:-0}" != "1" ]]; then - validate_bundled_runtime - mkdir -p "$RELAY_DIR" - - if [[ "$BUNDLED_RUNTIME" == "bun" ]]; then - package_relay_bun "$RELAY_DIR" - else - package_relay_node "$RELAY_DIR" - fi - - echo "🧪 Verifying bundled relay (version)" - "$RELAY_CMD" --version >/dev/null - - echo "🎨 Copying gateway A2UI host assets" - rm -rf "$RELAY_DIR/a2ui" - cp -R "$ROOT_DIR/src/canvas-host/a2ui" "$RELAY_DIR/a2ui" - - echo "🎛 Copying Control UI assets" - rm -rf "$RELAY_DIR/control-ui" - cp -R "$ROOT_DIR/dist/control-ui" "$RELAY_DIR/control-ui" - - echo "🧠 Copying bundled skills" - rm -rf "$RELAY_DIR/skills" - cp -R "$ROOT_DIR/skills" "$RELAY_DIR/skills" - - echo "📄 Writing embedded runtime package.json (Pi compatibility)" - cat > "$RELAY_DIR/package.json" <&2 - fi -else - echo "🧰 Skipping gateway payload packaging (SKIP_GATEWAY_PACKAGE=1)" -fi - echo "⏹ Stopping any running Clawdbot" killall -q Clawdbot 2>/dev/null || true diff --git a/scripts/restart-mac.sh b/scripts/restart-mac.sh index 9359a715e..1618ad141 100755 --- a/scripts/restart-mac.sh +++ b/scripts/restart-mac.sh @@ -177,8 +177,8 @@ elif [ "$SIGN" -eq 1 ]; then unset SIGN_IDENTITY fi -# 3) Package app (default to bundling the embedded gateway + CLI). -run_step "package app" bash -lc "cd '${ROOT_DIR}' && SKIP_TSC=${SKIP_TSC:-1} SKIP_GATEWAY_PACKAGE=${SKIP_GATEWAY_PACKAGE:-0} '${ROOT_DIR}/scripts/package-mac-app.sh'" +# 3) Package app (no embedded gateway). +run_step "package app" bash -lc "cd '${ROOT_DIR}' && SKIP_TSC=${SKIP_TSC:-1} '${ROOT_DIR}/scripts/package-mac-app.sh'" choose_app_bundle() { if [[ -n "${APP_BUNDLE}" && -d "${APP_BUNDLE}" ]]; then @@ -205,7 +205,7 @@ choose_app_bundle APP_BUNDLE_ID="$(/usr/libexec/PlistBuddy -c "Print :CFBundleIdentifier" "${APP_BUNDLE}/Contents/Info.plist" 2>/dev/null || true)" -# When unsigned, avoid the app overwriting the LaunchAgent with the relay binary. +# When unsigned, avoid the app overwriting the LaunchAgent while iterating. if [ "$NO_SIGN" -eq 1 ]; then if [[ -n "${APP_BUNDLE_ID}" ]]; then run_step "set attach-existing-only" \ @@ -239,8 +239,7 @@ else fail "App exited immediately. Check ${LOG_PATH} or Console.app (User Reports)." fi -# When unsigned, launchd cannot exec the app relay binary. Ensure the gateway -# LaunchAgent targets the repo CLI instead (after the app has launched). +# When unsigned, ensure the gateway LaunchAgent targets the repo CLI (after the app launches). if [ "$NO_SIGN" -eq 1 ]; then run_step "install gateway launch agent (unsigned)" bash -lc "cd '${ROOT_DIR}' && node dist/entry.js daemon install --force --runtime node" run_step "restart gateway daemon (unsigned)" bash -lc "cd '${ROOT_DIR}' && node dist/entry.js daemon restart"