Discord: include forwarded message snapshots
This commit is contained in:
@@ -193,6 +193,96 @@ describe("discord tool result dispatch", () => {
|
|||||||
expect(fetchChannel).toHaveBeenCalledTimes(1);
|
expect(fetchChannel).toHaveBeenCalledTimes(1);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("includes forwarded message snapshots in body", async () => {
|
||||||
|
const { createDiscordMessageHandler } = await import("./monitor.js");
|
||||||
|
let capturedBody = "";
|
||||||
|
dispatchMock.mockImplementationOnce(async ({ ctx, dispatcher }) => {
|
||||||
|
capturedBody = ctx.Body ?? "";
|
||||||
|
dispatcher.sendFinalReply({ text: "ok" });
|
||||||
|
return { queuedFinal: true, counts: { final: 1 } };
|
||||||
|
});
|
||||||
|
|
||||||
|
const cfg = {
|
||||||
|
agents: {
|
||||||
|
defaults: {
|
||||||
|
model: "anthropic/claude-opus-4-5",
|
||||||
|
workspace: "/tmp/clawd",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
session: { store: "/tmp/clawdbot-sessions.json" },
|
||||||
|
discord: { dm: { enabled: true, policy: "open" } },
|
||||||
|
} as ReturnType<typeof import("../config/config.js").loadConfig>;
|
||||||
|
|
||||||
|
const handler = createDiscordMessageHandler({
|
||||||
|
cfg,
|
||||||
|
discordConfig: cfg.discord,
|
||||||
|
accountId: "default",
|
||||||
|
token: "token",
|
||||||
|
runtime: {
|
||||||
|
log: vi.fn(),
|
||||||
|
error: vi.fn(),
|
||||||
|
exit: (code: number): never => {
|
||||||
|
throw new Error(`exit ${code}`);
|
||||||
|
},
|
||||||
|
},
|
||||||
|
botUserId: "bot-id",
|
||||||
|
guildHistories: new Map(),
|
||||||
|
historyLimit: 0,
|
||||||
|
mediaMaxBytes: 10_000,
|
||||||
|
textLimit: 2000,
|
||||||
|
replyToMode: "off",
|
||||||
|
dmEnabled: true,
|
||||||
|
groupDmEnabled: false,
|
||||||
|
});
|
||||||
|
|
||||||
|
const client = {
|
||||||
|
fetchChannel: vi.fn().mockResolvedValue({
|
||||||
|
type: ChannelType.DM,
|
||||||
|
name: "dm",
|
||||||
|
}),
|
||||||
|
} as unknown as Client;
|
||||||
|
|
||||||
|
await handler(
|
||||||
|
{
|
||||||
|
message: {
|
||||||
|
id: "m-forward-1",
|
||||||
|
content: "",
|
||||||
|
channelId: "c-forward-1",
|
||||||
|
timestamp: new Date().toISOString(),
|
||||||
|
type: MessageType.Default,
|
||||||
|
attachments: [],
|
||||||
|
embeds: [],
|
||||||
|
mentionedEveryone: false,
|
||||||
|
mentionedUsers: [],
|
||||||
|
mentionedRoles: [],
|
||||||
|
author: { id: "u1", bot: false, username: "Ada" },
|
||||||
|
rawData: {
|
||||||
|
message_snapshots: [
|
||||||
|
{
|
||||||
|
message: {
|
||||||
|
content: "forwarded hello",
|
||||||
|
embeds: [],
|
||||||
|
attachments: [],
|
||||||
|
author: {
|
||||||
|
id: "u2",
|
||||||
|
username: "Bob",
|
||||||
|
discriminator: "0",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
],
|
||||||
|
},
|
||||||
|
},
|
||||||
|
author: { id: "u1", bot: false, username: "Ada" },
|
||||||
|
guild_id: null,
|
||||||
|
},
|
||||||
|
client,
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(capturedBody).toContain("[Forwarded message from @Bob]");
|
||||||
|
expect(capturedBody).toContain("forwarded hello");
|
||||||
|
});
|
||||||
|
|
||||||
it("uses channel id allowlists for non-thread channels with categories", async () => {
|
it("uses channel id allowlists for non-thread channels with categories", async () => {
|
||||||
const { createDiscordMessageHandler } = await import("./monitor.js");
|
const { createDiscordMessageHandler } = await import("./monitor.js");
|
||||||
let capturedCtx: { SessionKey?: string } | undefined;
|
let capturedCtx: { SessionKey?: string } | undefined;
|
||||||
|
|||||||
@@ -99,6 +99,25 @@ type DiscordMediaInfo = {
|
|||||||
placeholder: string;
|
placeholder: string;
|
||||||
};
|
};
|
||||||
|
|
||||||
|
type DiscordSnapshotAuthor = {
|
||||||
|
id?: string | null;
|
||||||
|
username?: string | null;
|
||||||
|
discriminator?: string | null;
|
||||||
|
global_name?: string | null;
|
||||||
|
name?: string | null;
|
||||||
|
};
|
||||||
|
|
||||||
|
type DiscordSnapshotMessage = {
|
||||||
|
content?: string | null;
|
||||||
|
embeds?: Array<{ description?: string | null; title?: string | null }> | null;
|
||||||
|
attachments?: APIAttachment[] | null;
|
||||||
|
author?: DiscordSnapshotAuthor | null;
|
||||||
|
};
|
||||||
|
|
||||||
|
type DiscordMessageSnapshot = {
|
||||||
|
message?: DiscordSnapshotMessage | null;
|
||||||
|
};
|
||||||
|
|
||||||
type DiscordHistoryEntry = {
|
type DiscordHistoryEntry = {
|
||||||
sender: string;
|
sender: string;
|
||||||
body: string;
|
body: string;
|
||||||
@@ -706,7 +725,12 @@ export function createDiscordMessageHandler(params: {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
const botId = botUserId;
|
const botId = botUserId;
|
||||||
const baseText = resolveDiscordMessageText(message);
|
const baseText = resolveDiscordMessageText(message, {
|
||||||
|
includeForwarded: false,
|
||||||
|
});
|
||||||
|
const messageText = resolveDiscordMessageText(message, {
|
||||||
|
includeForwarded: true,
|
||||||
|
});
|
||||||
recordProviderActivity({
|
recordProviderActivity({
|
||||||
provider: "discord",
|
provider: "discord",
|
||||||
accountId,
|
accountId,
|
||||||
@@ -732,7 +756,7 @@ export function createDiscordMessageHandler(params: {
|
|||||||
matchesMentionPatterns(baseText, mentionRegexes));
|
matchesMentionPatterns(baseText, mentionRegexes));
|
||||||
if (shouldLogVerbose()) {
|
if (shouldLogVerbose()) {
|
||||||
logVerbose(
|
logVerbose(
|
||||||
`discord: inbound id=${message.id} guild=${message.guild?.id ?? "dm"} channel=${message.channelId} mention=${wasMentioned ? "yes" : "no"} type=${isDirectMessage ? "dm" : isGroupDm ? "group-dm" : "guild"} content=${baseText ? "yes" : "no"}`,
|
`discord: inbound id=${message.id} guild=${message.guild?.id ?? "dm"} channel=${message.channelId} mention=${wasMentioned ? "yes" : "no"} type=${isDirectMessage ? "dm" : isGroupDm ? "group-dm" : "guild"} content=${messageText ? "yes" : "no"}`,
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -860,7 +884,9 @@ export function createDiscordMessageHandler(params: {
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
const textForHistory = resolveDiscordMessageText(message);
|
const textForHistory = resolveDiscordMessageText(message, {
|
||||||
|
includeForwarded: true,
|
||||||
|
});
|
||||||
if (isGuildMessage && historyLimit > 0 && textForHistory) {
|
if (isGuildMessage && historyLimit > 0 && textForHistory) {
|
||||||
const history = guildHistories.get(message.channelId) ?? [];
|
const history = guildHistories.get(message.channelId) ?? [];
|
||||||
history.push({
|
history.push({
|
||||||
@@ -957,7 +983,7 @@ export function createDiscordMessageHandler(params: {
|
|||||||
}
|
}
|
||||||
|
|
||||||
const mediaList = await resolveMediaList(message, mediaMaxBytes);
|
const mediaList = await resolveMediaList(message, mediaMaxBytes);
|
||||||
const text = baseText;
|
const text = messageText;
|
||||||
if (!text) {
|
if (!text) {
|
||||||
logVerbose(`discord: drop message ${message.id} (empty content)`);
|
logVerbose(`discord: drop message ${message.id} (empty content)`);
|
||||||
return;
|
return;
|
||||||
@@ -1938,17 +1964,86 @@ function buildDiscordAttachmentPlaceholder(
|
|||||||
|
|
||||||
function resolveDiscordMessageText(
|
function resolveDiscordMessageText(
|
||||||
message: Message,
|
message: Message,
|
||||||
fallbackText?: string,
|
options?: { fallbackText?: string; includeForwarded?: boolean },
|
||||||
): string {
|
): string {
|
||||||
return (
|
const baseText =
|
||||||
message.content?.trim() ||
|
message.content?.trim() ||
|
||||||
buildDiscordAttachmentPlaceholder(message.attachments) ||
|
buildDiscordAttachmentPlaceholder(message.attachments) ||
|
||||||
message.embeds?.[0]?.description ||
|
message.embeds?.[0]?.description ||
|
||||||
fallbackText?.trim() ||
|
options?.fallbackText?.trim() ||
|
||||||
""
|
"";
|
||||||
|
if (!options?.includeForwarded) return baseText;
|
||||||
|
const forwardedText = resolveDiscordForwardedMessagesText(message);
|
||||||
|
if (!forwardedText) return baseText;
|
||||||
|
if (!baseText) return forwardedText;
|
||||||
|
return `${baseText}\n${forwardedText}`;
|
||||||
|
}
|
||||||
|
|
||||||
|
function resolveDiscordForwardedMessagesText(message: Message): string {
|
||||||
|
const snapshots = resolveDiscordMessageSnapshots(message);
|
||||||
|
if (snapshots.length === 0) return "";
|
||||||
|
const forwardedBlocks = snapshots
|
||||||
|
.map((snapshot) => {
|
||||||
|
const snapshotMessage = snapshot.message;
|
||||||
|
if (!snapshotMessage) return null;
|
||||||
|
const text = resolveDiscordSnapshotMessageText(snapshotMessage);
|
||||||
|
if (!text) return null;
|
||||||
|
const authorLabel = formatDiscordSnapshotAuthor(snapshotMessage.author);
|
||||||
|
const heading = authorLabel
|
||||||
|
? `[Forwarded message from ${authorLabel}]`
|
||||||
|
: "[Forwarded message]";
|
||||||
|
return `${heading}\n${text}`;
|
||||||
|
})
|
||||||
|
.filter((entry): entry is string => Boolean(entry));
|
||||||
|
if (forwardedBlocks.length === 0) return "";
|
||||||
|
return forwardedBlocks.join("\n\n");
|
||||||
|
}
|
||||||
|
|
||||||
|
function resolveDiscordMessageSnapshots(
|
||||||
|
message: Message,
|
||||||
|
): DiscordMessageSnapshot[] {
|
||||||
|
const rawData = (message as { rawData?: { message_snapshots?: unknown } })
|
||||||
|
.rawData;
|
||||||
|
const snapshots =
|
||||||
|
rawData?.message_snapshots ??
|
||||||
|
(message as { message_snapshots?: unknown }).message_snapshots ??
|
||||||
|
(message as { messageSnapshots?: unknown }).messageSnapshots;
|
||||||
|
if (!Array.isArray(snapshots)) return [];
|
||||||
|
return snapshots.filter(
|
||||||
|
(entry): entry is DiscordMessageSnapshot =>
|
||||||
|
Boolean(entry) && typeof entry === "object",
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
function resolveDiscordSnapshotMessageText(
|
||||||
|
snapshot: DiscordSnapshotMessage,
|
||||||
|
): string {
|
||||||
|
const content = snapshot.content?.trim() ?? "";
|
||||||
|
const attachmentText = buildDiscordAttachmentPlaceholder(
|
||||||
|
snapshot.attachments ?? undefined,
|
||||||
|
);
|
||||||
|
const embed = snapshot.embeds?.[0];
|
||||||
|
const embedText = embed?.description?.trim() || embed?.title?.trim() || "";
|
||||||
|
return content || attachmentText || embedText || "";
|
||||||
|
}
|
||||||
|
|
||||||
|
function formatDiscordSnapshotAuthor(
|
||||||
|
author: DiscordSnapshotAuthor | null | undefined,
|
||||||
|
): string | undefined {
|
||||||
|
if (!author) return undefined;
|
||||||
|
const globalName = author.global_name ?? undefined;
|
||||||
|
const username = author.username ?? undefined;
|
||||||
|
const name = author.name ?? undefined;
|
||||||
|
const discriminator = author.discriminator ?? undefined;
|
||||||
|
const base = globalName || username || name;
|
||||||
|
if (username && discriminator && discriminator !== "0") {
|
||||||
|
return `@${username}#${discriminator}`;
|
||||||
|
}
|
||||||
|
if (base) return `@${base}`;
|
||||||
|
if (author.id) return `@${author.id}`;
|
||||||
|
return undefined;
|
||||||
|
}
|
||||||
|
|
||||||
export function buildDiscordMediaPayload(
|
export function buildDiscordMediaPayload(
|
||||||
mediaList: Array<{ path: string; contentType?: string }>,
|
mediaList: Array<{ path: string; contentType?: string }>,
|
||||||
): {
|
): {
|
||||||
@@ -1977,7 +2072,9 @@ export function buildDiscordMediaPayload(
|
|||||||
function resolveReplyContext(message: Message): string | null {
|
function resolveReplyContext(message: Message): string | null {
|
||||||
const referenced = message.referencedMessage;
|
const referenced = message.referencedMessage;
|
||||||
if (!referenced?.author) return null;
|
if (!referenced?.author) return null;
|
||||||
const referencedText = resolveDiscordMessageText(referenced);
|
const referencedText = resolveDiscordMessageText(referenced, {
|
||||||
|
includeForwarded: true,
|
||||||
|
});
|
||||||
if (!referencedText) return null;
|
if (!referencedText) return null;
|
||||||
const fromLabel = referenced.author
|
const fromLabel = referenced.author
|
||||||
? buildDirectLabel(referenced.author)
|
? buildDirectLabel(referenced.author)
|
||||||
|
|||||||
Reference in New Issue
Block a user