refactor(cron): drop auto-migration

This commit is contained in:
Peter Steinberger
2025-12-13 12:45:02 +00:00
parent 5d8ee8fc28
commit 7b38ba0e65

View File

@@ -8,7 +8,6 @@ import type { CronStoreFile } from "./types.js";
export const DEFAULT_CRON_DIR = path.join(CONFIG_DIR, "cron");
export const DEFAULT_CRON_STORE_PATH = path.join(DEFAULT_CRON_DIR, "jobs.json");
export const LEGACY_FLAT_CRON_STORE_PATH = path.join(CONFIG_DIR, "cron.json");
export function resolveCronStorePath(storePath?: string) {
if (storePath?.trim()) {
@@ -20,49 +19,7 @@ export function resolveCronStorePath(storePath?: string) {
return DEFAULT_CRON_STORE_PATH;
}
async function maybeMigrateLegacyFlatStore(storePath: string) {
const resolved = path.resolve(storePath);
const resolvedDefault = path.resolve(DEFAULT_CRON_STORE_PATH);
if (resolved !== resolvedDefault) return;
if (fs.existsSync(resolved)) return;
if (!fs.existsSync(LEGACY_FLAT_CRON_STORE_PATH)) return;
try {
const raw = await fs.promises.readFile(
LEGACY_FLAT_CRON_STORE_PATH,
"utf-8",
);
const parsed = JSON5.parse(raw) as Partial<CronStoreFile> | null;
const jobs = Array.isArray(parsed?.jobs) ? (parsed?.jobs as never[]) : [];
const store: CronStoreFile = {
version: 1,
jobs: jobs.filter(Boolean) as never as CronStoreFile["jobs"],
};
await saveCronStore(storePath, store);
await fs.promises.mkdir(DEFAULT_CRON_DIR, { recursive: true });
const destBase = path.join(DEFAULT_CRON_DIR, "cron.json.migrated");
const dest = fs.existsSync(destBase)
? path.join(
DEFAULT_CRON_DIR,
`cron.json.migrated.${process.pid}.${Math.random().toString(16).slice(2)}`,
)
: destBase;
try {
await fs.promises.rename(LEGACY_FLAT_CRON_STORE_PATH, dest);
} catch {
await fs.promises.copyFile(LEGACY_FLAT_CRON_STORE_PATH, dest);
await fs.promises.unlink(LEGACY_FLAT_CRON_STORE_PATH).catch(() => {
/* ignore */
});
}
} catch {
// Best-effort; keep legacy store if anything fails.
}
}
export async function loadCronStore(storePath: string): Promise<CronStoreFile> {
await maybeMigrateLegacyFlatStore(storePath);
try {
const raw = await fs.promises.readFile(storePath, "utf-8");
const parsed = JSON5.parse(raw) as Partial<CronStoreFile> | null;