fix: doctor memory hint
This commit is contained in:
@@ -14,6 +14,8 @@
|
|||||||
- Auto-reply: treat steer during compaction as a follow-up, queued until compaction completes.
|
- Auto-reply: treat steer during compaction as a follow-up, queued until compaction completes.
|
||||||
- Auth: lock auth profile refreshes to avoid multi-instance OAuth logouts; keep credentials on refresh failure.
|
- Auth: lock auth profile refreshes to avoid multi-instance OAuth logouts; keep credentials on refresh failure.
|
||||||
- Onboarding: prompt immediately for OpenAI Codex redirect URL on remote/headless logins.
|
- Onboarding: prompt immediately for OpenAI Codex redirect URL on remote/headless logins.
|
||||||
|
- Doctor: suggest adding the workspace memory system when missing (opt-out via `--no-workspace-suggestions`).
|
||||||
|
- Build: fix duplicate protocol export, align Codex OAuth options, and add proper-lockfile typings.
|
||||||
- Typing indicators: stop typing once the reply dispatcher drains to prevent stuck typing across Discord/Telegram/WhatsApp.
|
- Typing indicators: stop typing once the reply dispatcher drains to prevent stuck typing across Discord/Telegram/WhatsApp.
|
||||||
- Typing indicators: fix a race that could keep the typing indicator stuck after quick replies. Thanks @thewilloftheshadow for PR #270.
|
- Typing indicators: fix a race that could keep the typing indicator stuck after quick replies. Thanks @thewilloftheshadow for PR #270.
|
||||||
- Google: merge consecutive messages to satisfy strict role alternation for Google provider models. Thanks @Asleep123 for PR #266.
|
- Google: merge consecutive messages to satisfy strict role alternation for Google provider models. Thanks @Asleep123 for PR #266.
|
||||||
|
|||||||
@@ -289,9 +289,16 @@ export function buildProgram() {
|
|||||||
program
|
program
|
||||||
.command("doctor")
|
.command("doctor")
|
||||||
.description("Health checks + quick fixes for the gateway and providers")
|
.description("Health checks + quick fixes for the gateway and providers")
|
||||||
.action(async () => {
|
.option(
|
||||||
|
"--no-workspace-suggestions",
|
||||||
|
"Disable workspace memory system suggestions",
|
||||||
|
false,
|
||||||
|
)
|
||||||
|
.action(async (opts) => {
|
||||||
try {
|
try {
|
||||||
await doctorCommand(defaultRuntime);
|
await doctorCommand(defaultRuntime, {
|
||||||
|
workspaceSuggestions: opts.workspaceSuggestions,
|
||||||
|
});
|
||||||
} catch (err) {
|
} catch (err) {
|
||||||
defaultRuntime.error(String(err));
|
defaultRuntime.error(String(err));
|
||||||
defaultRuntime.exit(1);
|
defaultRuntime.exit(1);
|
||||||
|
|||||||
@@ -9,6 +9,7 @@ import {
|
|||||||
DEFAULT_SANDBOX_COMMON_IMAGE,
|
DEFAULT_SANDBOX_COMMON_IMAGE,
|
||||||
DEFAULT_SANDBOX_IMAGE,
|
DEFAULT_SANDBOX_IMAGE,
|
||||||
} from "../agents/sandbox.js";
|
} from "../agents/sandbox.js";
|
||||||
|
import { DEFAULT_AGENTS_FILENAME } from "../agents/workspace.js";
|
||||||
import { buildWorkspaceSkillStatus } from "../agents/skills-status.js";
|
import { buildWorkspaceSkillStatus } from "../agents/skills-status.js";
|
||||||
import type { ClawdbotConfig } from "../config/config.js";
|
import type { ClawdbotConfig } from "../config/config.js";
|
||||||
import {
|
import {
|
||||||
@@ -128,6 +129,45 @@ async function runSandboxScript(
|
|||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
type DoctorOptions = {
|
||||||
|
workspaceSuggestions?: boolean;
|
||||||
|
};
|
||||||
|
|
||||||
|
const MEMORY_SYSTEM_PROMPT = [
|
||||||
|
"Memory system not found in workspace.",
|
||||||
|
"Paste this into your agent:",
|
||||||
|
"",
|
||||||
|
"Install the memory system by applying:",
|
||||||
|
"https://github.com/clawdbot/clawdbot/commit/9ffea23f31ca1df5183b25668f8f814bee0fb34e",
|
||||||
|
"https://github.com/clawdbot/clawdbot/commit/7d1fee70e76f2f634f1b41fca927ee663914183a",
|
||||||
|
].join("\n");
|
||||||
|
|
||||||
|
async function shouldSuggestMemorySystem(workspaceDir: string): Promise<boolean> {
|
||||||
|
const memoryPaths = [
|
||||||
|
path.join(workspaceDir, "MEMORY.md"),
|
||||||
|
path.join(workspaceDir, "memory.md"),
|
||||||
|
];
|
||||||
|
|
||||||
|
for (const memoryPath of memoryPaths) {
|
||||||
|
try {
|
||||||
|
await fs.promises.access(memoryPath);
|
||||||
|
return false;
|
||||||
|
} catch {
|
||||||
|
// keep scanning
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
const agentsPath = path.join(workspaceDir, DEFAULT_AGENTS_FILENAME);
|
||||||
|
try {
|
||||||
|
const content = await fs.promises.readFile(agentsPath, "utf-8");
|
||||||
|
if (/memory\.md/i.test(content)) return false;
|
||||||
|
} catch {
|
||||||
|
// no AGENTS.md or unreadable; treat as missing memory guidance
|
||||||
|
}
|
||||||
|
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
async function isDockerAvailable(): Promise<boolean> {
|
async function isDockerAvailable(): Promise<boolean> {
|
||||||
try {
|
try {
|
||||||
await runExec("docker", ["version", "--format", "{{.Server.Version}}"], {
|
await runExec("docker", ["version", "--format", "{{.Server.Version}}"], {
|
||||||
@@ -546,7 +586,10 @@ async function maybeMigrateLegacyGatewayService(
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
export async function doctorCommand(runtime: RuntimeEnv = defaultRuntime) {
|
export async function doctorCommand(
|
||||||
|
runtime: RuntimeEnv = defaultRuntime,
|
||||||
|
options: DoctorOptions = {},
|
||||||
|
) {
|
||||||
printWizardHeader(runtime);
|
printWizardHeader(runtime);
|
||||||
intro("Clawdbot doctor");
|
intro("Clawdbot doctor");
|
||||||
|
|
||||||
@@ -694,5 +737,14 @@ export async function doctorCommand(runtime: RuntimeEnv = defaultRuntime) {
|
|||||||
await writeConfigFile(cfg);
|
await writeConfigFile(cfg);
|
||||||
runtime.log(`Updated ${CONFIG_PATH_CLAWDBOT}`);
|
runtime.log(`Updated ${CONFIG_PATH_CLAWDBOT}`);
|
||||||
|
|
||||||
|
if (options.workspaceSuggestions !== false) {
|
||||||
|
const workspaceDir = resolveUserPath(
|
||||||
|
cfg.agent?.workspace ?? DEFAULT_WORKSPACE,
|
||||||
|
);
|
||||||
|
if (await shouldSuggestMemorySystem(workspaceDir)) {
|
||||||
|
note(MEMORY_SYSTEM_PROMPT, "Workspace");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
outro("Doctor complete.");
|
outro("Doctor complete.");
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -394,5 +394,4 @@ export type {
|
|||||||
CronRunParams,
|
CronRunParams,
|
||||||
CronRunsParams,
|
CronRunsParams,
|
||||||
CronRunLogEntry,
|
CronRunLogEntry,
|
||||||
PollParams,
|
|
||||||
};
|
};
|
||||||
|
|||||||
29
src/types/proper-lockfile.d.ts
vendored
Normal file
29
src/types/proper-lockfile.d.ts
vendored
Normal file
@@ -0,0 +1,29 @@
|
|||||||
|
declare module "proper-lockfile" {
|
||||||
|
export type RetryOptions = {
|
||||||
|
retries?: number;
|
||||||
|
factor?: number;
|
||||||
|
minTimeout?: number;
|
||||||
|
maxTimeout?: number;
|
||||||
|
randomize?: boolean;
|
||||||
|
};
|
||||||
|
|
||||||
|
export type LockOptions = {
|
||||||
|
retries?: number | RetryOptions;
|
||||||
|
stale?: number;
|
||||||
|
update?: number;
|
||||||
|
realpath?: boolean;
|
||||||
|
};
|
||||||
|
|
||||||
|
export type ReleaseFn = () => Promise<void>;
|
||||||
|
|
||||||
|
export function lock(
|
||||||
|
path: string,
|
||||||
|
options?: LockOptions,
|
||||||
|
): Promise<ReleaseFn>;
|
||||||
|
|
||||||
|
const lockfile: {
|
||||||
|
lock: typeof lock;
|
||||||
|
};
|
||||||
|
|
||||||
|
export default lockfile;
|
||||||
|
}
|
||||||
@@ -386,20 +386,6 @@ export async function runOnboardingWizard(
|
|||||||
});
|
});
|
||||||
return String(code);
|
return String(code);
|
||||||
},
|
},
|
||||||
onManualCodeInput: isRemote
|
|
||||||
? () => {
|
|
||||||
if (!manualCodePromise) {
|
|
||||||
manualCodePromise = prompter
|
|
||||||
.text({
|
|
||||||
message: "Paste the redirect URL (or authorization code)",
|
|
||||||
validate: (value) =>
|
|
||||||
value?.trim() ? undefined : "Required",
|
|
||||||
})
|
|
||||||
.then((value) => String(value));
|
|
||||||
}
|
|
||||||
return manualCodePromise;
|
|
||||||
}
|
|
||||||
: undefined,
|
|
||||||
onProgress: (msg) => spin.update(msg),
|
onProgress: (msg) => spin.update(msg),
|
||||||
});
|
});
|
||||||
spin.stop("OpenAI OAuth complete");
|
spin.stop("OpenAI OAuth complete");
|
||||||
|
|||||||
Reference in New Issue
Block a user