Merge pull request #782 from AbhisekBasu1/fix/antigravity-opus-tools-not-working
Fix - Opus on Antigravity Errors
This commit is contained in:
@@ -11,6 +11,7 @@
|
|||||||
- Gemini: downgrade tool-call history missing `thought_signature` to avoid INVALID_ARGUMENT errors. (#793 — thanks @hsrvc)
|
- Gemini: downgrade tool-call history missing `thought_signature` to avoid INVALID_ARGUMENT errors. (#793 — thanks @hsrvc)
|
||||||
- Messaging: enforce context isolation for message tool sends across providers (normalized targets + tests). (#793 — thanks @hsrvc)
|
- Messaging: enforce context isolation for message tool sends across providers (normalized targets + tests). (#793 — thanks @hsrvc)
|
||||||
- Auto-reply: re-evaluate reasoning tag enforcement on fallback providers to prevent leaked reasoning. (#810 — thanks @mcinteerj)
|
- Auto-reply: re-evaluate reasoning tag enforcement on fallback providers to prevent leaked reasoning. (#810 — thanks @mcinteerj)
|
||||||
|
- Tools/Gemini: drop null-only union variants while cleaning tool schemas to avoid Cloud Code Assist schema errors. (#782 — thanks @AbhisekBasu1)
|
||||||
|
|
||||||
## 2026.1.12-3
|
## 2026.1.12-3
|
||||||
|
|
||||||
|
|||||||
@@ -103,6 +103,31 @@ describe("createClawdbotCodingTools", () => {
|
|||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("drops null-only union variants without flattening other unions", () => {
|
||||||
|
const cleaned = __testing.cleanToolSchemaForGemini({
|
||||||
|
type: "object",
|
||||||
|
properties: {
|
||||||
|
parentId: { anyOf: [{ type: "string" }, { type: "null" }] },
|
||||||
|
count: { oneOf: [{ type: "string" }, { type: "number" }] },
|
||||||
|
},
|
||||||
|
}) as {
|
||||||
|
properties?: Record<string, unknown>;
|
||||||
|
};
|
||||||
|
|
||||||
|
const parentId = cleaned.properties?.parentId as
|
||||||
|
| { type?: unknown; anyOf?: unknown; oneOf?: unknown }
|
||||||
|
| undefined;
|
||||||
|
expect(parentId?.anyOf).toBeUndefined();
|
||||||
|
expect(parentId?.oneOf).toBeUndefined();
|
||||||
|
expect(parentId?.type).toBe("string");
|
||||||
|
|
||||||
|
const count = cleaned.properties?.count as
|
||||||
|
| { type?: unknown; anyOf?: unknown; oneOf?: unknown }
|
||||||
|
| undefined;
|
||||||
|
expect(count?.anyOf).toBeUndefined();
|
||||||
|
expect(Array.isArray(count?.oneOf)).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
it("preserves action enums in normalized schemas", () => {
|
it("preserves action enums in normalized schemas", () => {
|
||||||
const tools = createClawdbotCodingTools();
|
const tools = createClawdbotCodingTools();
|
||||||
const toolNames = [
|
const toolNames = [
|
||||||
|
|||||||
@@ -67,6 +67,39 @@ function tryFlattenLiteralAnyOf(
|
|||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
function isNullSchema(variant: unknown): boolean {
|
||||||
|
if (!variant || typeof variant !== "object" || Array.isArray(variant)) {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
const record = variant as Record<string, unknown>;
|
||||||
|
if ("const" in record && record.const === null) return true;
|
||||||
|
if (Array.isArray(record.enum) && record.enum.length === 1) {
|
||||||
|
return record.enum[0] === null;
|
||||||
|
}
|
||||||
|
const typeValue = record.type;
|
||||||
|
if (typeValue === "null") return true;
|
||||||
|
if (
|
||||||
|
Array.isArray(typeValue) &&
|
||||||
|
typeValue.length === 1 &&
|
||||||
|
typeValue[0] === "null"
|
||||||
|
) {
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
function stripNullVariants(variants: unknown[]): {
|
||||||
|
variants: unknown[];
|
||||||
|
stripped: boolean;
|
||||||
|
} {
|
||||||
|
if (variants.length === 0) return { variants, stripped: false };
|
||||||
|
const nonNull = variants.filter((variant) => !isNullSchema(variant));
|
||||||
|
return {
|
||||||
|
variants: nonNull,
|
||||||
|
stripped: nonNull.length !== variants.length,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
type SchemaDefs = Map<string, unknown>;
|
type SchemaDefs = Map<string, unknown>;
|
||||||
|
|
||||||
function extendSchemaDefs(
|
function extendSchemaDefs(
|
||||||
@@ -166,9 +199,24 @@ function cleanSchemaForGeminiWithDefs(
|
|||||||
|
|
||||||
const hasAnyOf = "anyOf" in obj && Array.isArray(obj.anyOf);
|
const hasAnyOf = "anyOf" in obj && Array.isArray(obj.anyOf);
|
||||||
const hasOneOf = "oneOf" in obj && Array.isArray(obj.oneOf);
|
const hasOneOf = "oneOf" in obj && Array.isArray(obj.oneOf);
|
||||||
|
let cleanedAnyOf = hasAnyOf
|
||||||
|
? (obj.anyOf as unknown[]).map((variant) =>
|
||||||
|
cleanSchemaForGeminiWithDefs(variant, nextDefs, refStack),
|
||||||
|
)
|
||||||
|
: undefined;
|
||||||
|
let cleanedOneOf = hasOneOf
|
||||||
|
? (obj.oneOf as unknown[]).map((variant) =>
|
||||||
|
cleanSchemaForGeminiWithDefs(variant, nextDefs, refStack),
|
||||||
|
)
|
||||||
|
: undefined;
|
||||||
|
|
||||||
if (hasAnyOf) {
|
if (hasAnyOf) {
|
||||||
const flattened = tryFlattenLiteralAnyOf(obj.anyOf as unknown[]);
|
const { variants: nonNullVariants, stripped } = stripNullVariants(
|
||||||
|
cleanedAnyOf ?? [],
|
||||||
|
);
|
||||||
|
if (stripped) cleanedAnyOf = nonNullVariants;
|
||||||
|
|
||||||
|
const flattened = tryFlattenLiteralAnyOf(nonNullVariants);
|
||||||
if (flattened) {
|
if (flattened) {
|
||||||
const result: Record<string, unknown> = {
|
const result: Record<string, unknown> = {
|
||||||
type: flattened.type,
|
type: flattened.type,
|
||||||
@@ -179,10 +227,28 @@ function cleanSchemaForGeminiWithDefs(
|
|||||||
}
|
}
|
||||||
return result;
|
return result;
|
||||||
}
|
}
|
||||||
|
if (stripped && nonNullVariants.length === 1) {
|
||||||
|
const lone = nonNullVariants[0];
|
||||||
|
if (lone && typeof lone === "object" && !Array.isArray(lone)) {
|
||||||
|
const result: Record<string, unknown> = {
|
||||||
|
...(lone as Record<string, unknown>),
|
||||||
|
};
|
||||||
|
for (const key of ["description", "title", "default"]) {
|
||||||
|
if (key in obj && obj[key] !== undefined) result[key] = obj[key];
|
||||||
|
}
|
||||||
|
return result;
|
||||||
|
}
|
||||||
|
return lone;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
if (hasOneOf) {
|
if (hasOneOf) {
|
||||||
const flattened = tryFlattenLiteralAnyOf(obj.oneOf as unknown[]);
|
const { variants: nonNullVariants, stripped } = stripNullVariants(
|
||||||
|
cleanedOneOf ?? [],
|
||||||
|
);
|
||||||
|
if (stripped) cleanedOneOf = nonNullVariants;
|
||||||
|
|
||||||
|
const flattened = tryFlattenLiteralAnyOf(nonNullVariants);
|
||||||
if (flattened) {
|
if (flattened) {
|
||||||
const result: Record<string, unknown> = {
|
const result: Record<string, unknown> = {
|
||||||
type: flattened.type,
|
type: flattened.type,
|
||||||
@@ -193,6 +259,19 @@ function cleanSchemaForGeminiWithDefs(
|
|||||||
}
|
}
|
||||||
return result;
|
return result;
|
||||||
}
|
}
|
||||||
|
if (stripped && nonNullVariants.length === 1) {
|
||||||
|
const lone = nonNullVariants[0];
|
||||||
|
if (lone && typeof lone === "object" && !Array.isArray(lone)) {
|
||||||
|
const result: Record<string, unknown> = {
|
||||||
|
...(lone as Record<string, unknown>),
|
||||||
|
};
|
||||||
|
for (const key of ["description", "title", "default"]) {
|
||||||
|
if (key in obj && obj[key] !== undefined) result[key] = obj[key];
|
||||||
|
}
|
||||||
|
return result;
|
||||||
|
}
|
||||||
|
return lone;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
const cleaned: Record<string, unknown> = {};
|
const cleaned: Record<string, unknown> = {};
|
||||||
@@ -206,6 +285,15 @@ function cleanSchemaForGeminiWithDefs(
|
|||||||
}
|
}
|
||||||
|
|
||||||
if (key === "type" && (hasAnyOf || hasOneOf)) continue;
|
if (key === "type" && (hasAnyOf || hasOneOf)) continue;
|
||||||
|
if (
|
||||||
|
key === "type" &&
|
||||||
|
Array.isArray(value) &&
|
||||||
|
value.every((entry) => typeof entry === "string")
|
||||||
|
) {
|
||||||
|
const types = value.filter((entry) => entry !== "null");
|
||||||
|
cleaned.type = types.length === 1 ? types[0] : types;
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
|
||||||
if (key === "properties" && value && typeof value === "object") {
|
if (key === "properties" && value && typeof value === "object") {
|
||||||
const props = value as Record<string, unknown>;
|
const props = value as Record<string, unknown>;
|
||||||
@@ -218,13 +306,17 @@ function cleanSchemaForGeminiWithDefs(
|
|||||||
} else if (key === "items" && value && typeof value === "object") {
|
} else if (key === "items" && value && typeof value === "object") {
|
||||||
cleaned[key] = cleanSchemaForGeminiWithDefs(value, nextDefs, refStack);
|
cleaned[key] = cleanSchemaForGeminiWithDefs(value, nextDefs, refStack);
|
||||||
} else if (key === "anyOf" && Array.isArray(value)) {
|
} else if (key === "anyOf" && Array.isArray(value)) {
|
||||||
cleaned[key] = value.map((variant) =>
|
cleaned[key] =
|
||||||
cleanSchemaForGeminiWithDefs(variant, nextDefs, refStack),
|
cleanedAnyOf ??
|
||||||
);
|
value.map((variant) =>
|
||||||
|
cleanSchemaForGeminiWithDefs(variant, nextDefs, refStack),
|
||||||
|
);
|
||||||
} else if (key === "oneOf" && Array.isArray(value)) {
|
} else if (key === "oneOf" && Array.isArray(value)) {
|
||||||
cleaned[key] = value.map((variant) =>
|
cleaned[key] =
|
||||||
cleanSchemaForGeminiWithDefs(variant, nextDefs, refStack),
|
cleanedOneOf ??
|
||||||
);
|
value.map((variant) =>
|
||||||
|
cleanSchemaForGeminiWithDefs(variant, nextDefs, refStack),
|
||||||
|
);
|
||||||
} else if (key === "allOf" && Array.isArray(value)) {
|
} else if (key === "allOf" && Array.isArray(value)) {
|
||||||
cleaned[key] = value.map((variant) =>
|
cleaned[key] = value.map((variant) =>
|
||||||
cleanSchemaForGeminiWithDefs(variant, nextDefs, refStack),
|
cleanSchemaForGeminiWithDefs(variant, nextDefs, refStack),
|
||||||
|
|||||||
Reference in New Issue
Block a user