fix(security): lock down inbound DMs by default

src/config/config.test.ts

@@ -679,6 +679,166 @@ describe("legacy config detection", () => {
     }
   });
 
+  it('rejects telegram.dmPolicy="open" without allowFrom "*"', async () => {
+    vi.resetModules();
+    const { validateConfigObject } = await import("./config.js");
+    const res = validateConfigObject({
+      telegram: { dmPolicy: "open", allowFrom: ["123456789"] },
+    });
+    expect(res.ok).toBe(false);
+    if (!res.ok) {
+      expect(res.issues[0]?.path).toBe("telegram.allowFrom");
+    }
+  });
+
+  it('accepts telegram.dmPolicy="open" with allowFrom "*"', async () => {
+    vi.resetModules();
+    const { validateConfigObject } = await import("./config.js");
+    const res = validateConfigObject({
+      telegram: { dmPolicy: "open", allowFrom: ["*"] },
+    });
+    expect(res.ok).toBe(true);
+    if (res.ok) {
+      expect(res.config.telegram?.dmPolicy).toBe("open");
+    }
+  });
+
+  it("defaults telegram.dmPolicy to pairing when telegram section exists", async () => {
+    vi.resetModules();
+    const { validateConfigObject } = await import("./config.js");
+    const res = validateConfigObject({ telegram: {} });
+    expect(res.ok).toBe(true);
+    if (res.ok) {
+      expect(res.config.telegram?.dmPolicy).toBe("pairing");
+    }
+  });
+
+  it('rejects whatsapp.dmPolicy="open" without allowFrom "*"', async () => {
+    vi.resetModules();
+    const { validateConfigObject } = await import("./config.js");
+    const res = validateConfigObject({
+      whatsapp: { dmPolicy: "open", allowFrom: ["+15555550123"] },
+    });
+    expect(res.ok).toBe(false);
+    if (!res.ok) {
+      expect(res.issues[0]?.path).toBe("whatsapp.allowFrom");
+    }
+  });
+
+  it('accepts whatsapp.dmPolicy="open" with allowFrom "*"', async () => {
+    vi.resetModules();
+    const { validateConfigObject } = await import("./config.js");
+    const res = validateConfigObject({
+      whatsapp: { dmPolicy: "open", allowFrom: ["*"] },
+    });
+    expect(res.ok).toBe(true);
+    if (res.ok) {
+      expect(res.config.whatsapp?.dmPolicy).toBe("open");
+    }
+  });
+
+  it("defaults whatsapp.dmPolicy to pairing when whatsapp section exists", async () => {
+    vi.resetModules();
+    const { validateConfigObject } = await import("./config.js");
+    const res = validateConfigObject({ whatsapp: {} });
+    expect(res.ok).toBe(true);
+    if (res.ok) {
+      expect(res.config.whatsapp?.dmPolicy).toBe("pairing");
+    }
+  });
+
+  it('rejects signal.dmPolicy="open" without allowFrom "*"', async () => {
+    vi.resetModules();
+    const { validateConfigObject } = await import("./config.js");
+    const res = validateConfigObject({
+      signal: { dmPolicy: "open", allowFrom: ["+15555550123"] },
+    });
+    expect(res.ok).toBe(false);
+    if (!res.ok) {
+      expect(res.issues[0]?.path).toBe("signal.allowFrom");
+    }
+  });
+
+  it('accepts signal.dmPolicy="open" with allowFrom "*"', async () => {
+    vi.resetModules();
+    const { validateConfigObject } = await import("./config.js");
+    const res = validateConfigObject({
+      signal: { dmPolicy: "open", allowFrom: ["*"] },
+    });
+    expect(res.ok).toBe(true);
+    if (res.ok) {
+      expect(res.config.signal?.dmPolicy).toBe("open");
+    }
+  });
+
+  it("defaults signal.dmPolicy to pairing when signal section exists", async () => {
+    vi.resetModules();
+    const { validateConfigObject } = await import("./config.js");
+    const res = validateConfigObject({ signal: {} });
+    expect(res.ok).toBe(true);
+    if (res.ok) {
+      expect(res.config.signal?.dmPolicy).toBe("pairing");
+    }
+  });
+
+  it('rejects imessage.dmPolicy="open" without allowFrom "*"', async () => {
+    vi.resetModules();
+    const { validateConfigObject } = await import("./config.js");
+    const res = validateConfigObject({
+      imessage: { dmPolicy: "open", allowFrom: ["+15555550123"] },
+    });
+    expect(res.ok).toBe(false);
+    if (!res.ok) {
+      expect(res.issues[0]?.path).toBe("imessage.allowFrom");
+    }
+  });
+
+  it('accepts imessage.dmPolicy="open" with allowFrom "*"', async () => {
+    vi.resetModules();
+    const { validateConfigObject } = await import("./config.js");
+    const res = validateConfigObject({
+      imessage: { dmPolicy: "open", allowFrom: ["*"] },
+    });
+    expect(res.ok).toBe(true);
+    if (res.ok) {
+      expect(res.config.imessage?.dmPolicy).toBe("open");
+    }
+  });
+
+  it("defaults imessage.dmPolicy to pairing when imessage section exists", async () => {
+    vi.resetModules();
+    const { validateConfigObject } = await import("./config.js");
+    const res = validateConfigObject({ imessage: {} });
+    expect(res.ok).toBe(true);
+    if (res.ok) {
+      expect(res.config.imessage?.dmPolicy).toBe("pairing");
+    }
+  });
+
+  it('rejects discord.dm.policy="open" without allowFrom "*"', async () => {
+    vi.resetModules();
+    const { validateConfigObject } = await import("./config.js");
+    const res = validateConfigObject({
+      discord: { dm: { policy: "open", allowFrom: ["123"] } },
+    });
+    expect(res.ok).toBe(false);
+    if (!res.ok) {
+      expect(res.issues[0]?.path).toBe("discord.dm.allowFrom");
+    }
+  });
+
+  it('rejects slack.dm.policy="open" without allowFrom "*"', async () => {
+    vi.resetModules();
+    const { validateConfigObject } = await import("./config.js");
+    const res = validateConfigObject({
+      slack: { dm: { policy: "open", allowFrom: ["U123"] } },
+    });
+    expect(res.ok).toBe(false);
+    if (!res.ok) {
+      expect(res.issues[0]?.path).toBe("slack.dm.allowFrom");
+    }
+  });
+
   it("rejects legacy agent.model string", async () => {
     vi.resetModules();
     const { validateConfigObject } = await import("./config.js");