fix(hooks): emit message_received metadata
This commit is contained in:
@@ -18,6 +18,12 @@ const diagnosticMocks = vi.hoisted(() => ({
|
|||||||
logMessageProcessed: vi.fn(),
|
logMessageProcessed: vi.fn(),
|
||||||
logSessionStateChange: vi.fn(),
|
logSessionStateChange: vi.fn(),
|
||||||
}));
|
}));
|
||||||
|
const hookMocks = vi.hoisted(() => ({
|
||||||
|
runner: {
|
||||||
|
hasHooks: vi.fn(() => false),
|
||||||
|
runMessageReceived: vi.fn(async () => {}),
|
||||||
|
},
|
||||||
|
}));
|
||||||
|
|
||||||
vi.mock("./route-reply.js", () => ({
|
vi.mock("./route-reply.js", () => ({
|
||||||
isRoutableChannel: (channel: string | undefined) =>
|
isRoutableChannel: (channel: string | undefined) =>
|
||||||
@@ -45,6 +51,10 @@ vi.mock("../../logging/diagnostic.js", () => ({
|
|||||||
logSessionStateChange: diagnosticMocks.logSessionStateChange,
|
logSessionStateChange: diagnosticMocks.logSessionStateChange,
|
||||||
}));
|
}));
|
||||||
|
|
||||||
|
vi.mock("../../plugins/hook-runner-global.js", () => ({
|
||||||
|
getGlobalHookRunner: () => hookMocks.runner,
|
||||||
|
}));
|
||||||
|
|
||||||
const { dispatchReplyFromConfig } = await import("./dispatch-from-config.js");
|
const { dispatchReplyFromConfig } = await import("./dispatch-from-config.js");
|
||||||
const { resetInboundDedupe } = await import("./inbound-dedupe.js");
|
const { resetInboundDedupe } = await import("./inbound-dedupe.js");
|
||||||
|
|
||||||
@@ -64,6 +74,9 @@ describe("dispatchReplyFromConfig", () => {
|
|||||||
diagnosticMocks.logMessageQueued.mockReset();
|
diagnosticMocks.logMessageQueued.mockReset();
|
||||||
diagnosticMocks.logMessageProcessed.mockReset();
|
diagnosticMocks.logMessageProcessed.mockReset();
|
||||||
diagnosticMocks.logSessionStateChange.mockReset();
|
diagnosticMocks.logSessionStateChange.mockReset();
|
||||||
|
hookMocks.runner.hasHooks.mockReset();
|
||||||
|
hookMocks.runner.hasHooks.mockReturnValue(false);
|
||||||
|
hookMocks.runner.runMessageReceived.mockReset();
|
||||||
});
|
});
|
||||||
it("does not route when Provider matches OriginatingChannel (even if Surface is missing)", async () => {
|
it("does not route when Provider matches OriginatingChannel (even if Surface is missing)", async () => {
|
||||||
mocks.tryFastAbortFromMessage.mockResolvedValue({
|
mocks.tryFastAbortFromMessage.mockResolvedValue({
|
||||||
@@ -201,6 +214,57 @@ describe("dispatchReplyFromConfig", () => {
|
|||||||
expect(replyResolver).toHaveBeenCalledTimes(1);
|
expect(replyResolver).toHaveBeenCalledTimes(1);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("emits message_received hook with originating channel metadata", async () => {
|
||||||
|
mocks.tryFastAbortFromMessage.mockResolvedValue({
|
||||||
|
handled: false,
|
||||||
|
aborted: false,
|
||||||
|
});
|
||||||
|
hookMocks.runner.hasHooks.mockReturnValue(true);
|
||||||
|
const cfg = {} as ClawdbotConfig;
|
||||||
|
const dispatcher = createDispatcher();
|
||||||
|
const ctx = buildTestCtx({
|
||||||
|
Provider: "slack",
|
||||||
|
Surface: "slack",
|
||||||
|
OriginatingChannel: "Telegram",
|
||||||
|
OriginatingTo: "telegram:999",
|
||||||
|
CommandBody: "/search hello",
|
||||||
|
RawBody: "raw text",
|
||||||
|
Body: "body text",
|
||||||
|
Timestamp: 1710000000000,
|
||||||
|
MessageSidFull: "sid-full",
|
||||||
|
SenderId: "user-1",
|
||||||
|
SenderName: "Alice",
|
||||||
|
SenderUsername: "alice",
|
||||||
|
SenderE164: "+15555550123",
|
||||||
|
AccountId: "acc-1",
|
||||||
|
});
|
||||||
|
|
||||||
|
const replyResolver = async () => ({ text: "hi" }) satisfies ReplyPayload;
|
||||||
|
await dispatchReplyFromConfig({ ctx, cfg, dispatcher, replyResolver });
|
||||||
|
|
||||||
|
expect(hookMocks.runner.runMessageReceived).toHaveBeenCalledWith(
|
||||||
|
expect.objectContaining({
|
||||||
|
from: ctx.From,
|
||||||
|
content: "/search hello",
|
||||||
|
timestamp: 1710000000000,
|
||||||
|
metadata: expect.objectContaining({
|
||||||
|
originatingChannel: "Telegram",
|
||||||
|
originatingTo: "telegram:999",
|
||||||
|
messageId: "sid-full",
|
||||||
|
senderId: "user-1",
|
||||||
|
senderName: "Alice",
|
||||||
|
senderUsername: "alice",
|
||||||
|
senderE164: "+15555550123",
|
||||||
|
}),
|
||||||
|
}),
|
||||||
|
expect.objectContaining({
|
||||||
|
channelId: "telegram",
|
||||||
|
accountId: "acc-1",
|
||||||
|
conversationId: "telegram:999",
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
it("emits diagnostics when enabled", async () => {
|
it("emits diagnostics when enabled", async () => {
|
||||||
mocks.tryFastAbortFromMessage.mockResolvedValue({
|
mocks.tryFastAbortFromMessage.mockResolvedValue({
|
||||||
handled: false,
|
handled: false,
|
||||||
|
|||||||
@@ -6,6 +6,7 @@ import {
|
|||||||
logMessageQueued,
|
logMessageQueued,
|
||||||
logSessionStateChange,
|
logSessionStateChange,
|
||||||
} from "../../logging/diagnostic.js";
|
} from "../../logging/diagnostic.js";
|
||||||
|
import { getGlobalHookRunner } from "../../plugins/hook-runner-global.js";
|
||||||
import { getReplyFromConfig } from "../reply.js";
|
import { getReplyFromConfig } from "../reply.js";
|
||||||
import type { FinalizedMsgContext } from "../templating.js";
|
import type { FinalizedMsgContext } from "../templating.js";
|
||||||
import type { GetReplyOptions, ReplyPayload } from "../types.js";
|
import type { GetReplyOptions, ReplyPayload } from "../types.js";
|
||||||
@@ -80,6 +81,56 @@ export async function dispatchReplyFromConfig(params: {
|
|||||||
return { queuedFinal: false, counts: dispatcher.getQueuedCounts() };
|
return { queuedFinal: false, counts: dispatcher.getQueuedCounts() };
|
||||||
}
|
}
|
||||||
|
|
||||||
|
const hookRunner = getGlobalHookRunner();
|
||||||
|
if (hookRunner?.hasHooks("message_received")) {
|
||||||
|
const timestamp =
|
||||||
|
typeof ctx.Timestamp === "number" && Number.isFinite(ctx.Timestamp)
|
||||||
|
? ctx.Timestamp
|
||||||
|
: undefined;
|
||||||
|
const messageIdForHook =
|
||||||
|
ctx.MessageSidFull ?? ctx.MessageSid ?? ctx.MessageSidFirst ?? ctx.MessageSidLast;
|
||||||
|
const content =
|
||||||
|
typeof ctx.BodyForCommands === "string"
|
||||||
|
? ctx.BodyForCommands
|
||||||
|
: typeof ctx.RawBody === "string"
|
||||||
|
? ctx.RawBody
|
||||||
|
: typeof ctx.Body === "string"
|
||||||
|
? ctx.Body
|
||||||
|
: "";
|
||||||
|
const channelId = (ctx.OriginatingChannel ?? ctx.Surface ?? ctx.Provider ?? "").toLowerCase();
|
||||||
|
const conversationId = ctx.OriginatingTo ?? ctx.To ?? ctx.From ?? undefined;
|
||||||
|
|
||||||
|
void hookRunner
|
||||||
|
.runMessageReceived(
|
||||||
|
{
|
||||||
|
from: ctx.From ?? "",
|
||||||
|
content,
|
||||||
|
timestamp,
|
||||||
|
metadata: {
|
||||||
|
to: ctx.To,
|
||||||
|
provider: ctx.Provider,
|
||||||
|
surface: ctx.Surface,
|
||||||
|
threadId: ctx.MessageThreadId,
|
||||||
|
originatingChannel: ctx.OriginatingChannel,
|
||||||
|
originatingTo: ctx.OriginatingTo,
|
||||||
|
messageId: messageIdForHook,
|
||||||
|
senderId: ctx.SenderId,
|
||||||
|
senderName: ctx.SenderName,
|
||||||
|
senderUsername: ctx.SenderUsername,
|
||||||
|
senderE164: ctx.SenderE164,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
channelId,
|
||||||
|
accountId: ctx.AccountId,
|
||||||
|
conversationId,
|
||||||
|
},
|
||||||
|
)
|
||||||
|
.catch((err) => {
|
||||||
|
logVerbose(`dispatch-from-config: message_received hook failed: ${String(err)}`);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
// Check if we should route replies to originating channel instead of dispatcher.
|
// Check if we should route replies to originating channel instead of dispatcher.
|
||||||
// Only route when the originating channel is DIFFERENT from the current surface.
|
// Only route when the originating channel is DIFFERENT from the current surface.
|
||||||
// This handles cross-provider routing (e.g., message from Telegram being processed
|
// This handles cross-provider routing (e.g., message from Telegram being processed
|
||||||
|
|||||||
@@ -87,6 +87,7 @@ export type MsgContext = {
|
|||||||
SenderUsername?: string;
|
SenderUsername?: string;
|
||||||
SenderTag?: string;
|
SenderTag?: string;
|
||||||
SenderE164?: string;
|
SenderE164?: string;
|
||||||
|
Timestamp?: number;
|
||||||
/** Provider label (e.g. whatsapp, telegram). */
|
/** Provider label (e.g. whatsapp, telegram). */
|
||||||
Provider?: string;
|
Provider?: string;
|
||||||
/** Provider surface label (e.g. discord, slack). Prefer this over `Provider` when available. */
|
/** Provider surface label (e.g. discord, slack). Prefer this over `Provider` when available. */
|
||||||
|
|||||||
Reference in New Issue
Block a user