let5see/clawdbot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: use id for cron tool params

Browse Source
This commit is contained in:
Peter Steinberger
2026-01-05 02:15:11 +01:00
parent 359cb66e68
commit a322075764
3 changed files with 24 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/agents/tools/cron-tool.test.ts
View File

@@ -16,12 +16,12 @@ describe("cron tool", () => {
it.each([
[
"update",
{ action: "update", jobId: "job-1", patch: { foo: "bar" } },
{ action: "update", id: "job-1", patch: { foo: "bar" } },
{ id: "job-1", patch: { foo: "bar" } },
],
["remove", { action: "remove", jobId: "job-1" }, { id: "job-1" }],
["run", { action: "run", jobId: "job-1" }, { id: "job-1" }],
["runs", { action: "runs", jobId: "job-1" }, { id: "job-1" }],
["remove", { action: "remove", id: "job-1" }, { id: "job-1" }],
["run", { action: "run", id: "job-1" }, { id: "job-1" }],
["runs", { action: "runs", id: "job-1" }, { id: "job-1" }],
])("%s sends id to gateway", async (action, args, expectedParams) => {
const tool = createCronTool();
await tool.execute("call1", args);
@@ -34,4 +34,15 @@ describe("cron tool", () => {
expect(call.method).toBe(`cron.${action}`);
expect(call.params).toEqual(expectedParams);
});
it("rejects jobId params", async () => {
const tool = createCronTool();
await expect(
tool.execute("call2", {
action: "update",
jobId: "job-1",
patch: { foo: "bar" },
}),
).rejects.toThrow("id required");
});
});

16
src/agents/tools/cron-tool.ts
View File

@@ -29,7 +29,7 @@ const CronToolSchema = Type.Union([
gatewayUrl: Type.Optional(Type.String()),
gatewayToken: Type.Optional(Type.String()),
timeoutMs: Type.Optional(Type.Number()),
jobId: Type.String(),
id: Type.String(),
patch: Type.Object({}, { additionalProperties: true }),
}),
Type.Object({
@@ -37,21 +37,21 @@ const CronToolSchema = Type.Union([
gatewayUrl: Type.Optional(Type.String()),
gatewayToken: Type.Optional(Type.String()),
timeoutMs: Type.Optional(Type.Number()),
jobId: Type.String(),
id: Type.String(),
}),
Type.Object({
action: Type.Literal("run"),
gatewayUrl: Type.Optional(Type.String()),
gatewayToken: Type.Optional(Type.String()),
timeoutMs: Type.Optional(Type.Number()),
jobId: Type.String(),
id: Type.String(),
}),
Type.Object({
action: Type.Literal("runs"),
gatewayUrl: Type.Optional(Type.String()),
gatewayToken: Type.Optional(Type.String()),
timeoutMs: Type.Optional(Type.Number()),
jobId: Type.String(),
id: Type.String(),
}),
Type.Object({
action: Type.Literal("wake"),
@@ -102,7 +102,7 @@ export function createCronTool(): AnyAgentTool {
);
}
case "update": {
const id = readStringParam(params, "jobId", { required: true });
const id = readStringParam(params, "id", { required: true });
if (!params.patch || typeof params.patch !== "object") {
throw new Error("patch required");
}
@@ -114,19 +114,19 @@ export function createCronTool(): AnyAgentTool {
);
}
case "remove": {
const id = readStringParam(params, "jobId", { required: true });
const id = readStringParam(params, "id", { required: true });
return jsonResult(
await callGatewayTool("cron.remove", gatewayOpts, { id }),
);
}
case "run": {
const id = readStringParam(params, "jobId", { required: true });
const id = readStringParam(params, "id", { required: true });
return jsonResult(
await callGatewayTool("cron.run", gatewayOpts, { id }),
);
}
case "runs": {
const id = readStringParam(params, "jobId", { required: true });
const id = readStringParam(params, "id", { required: true });
return jsonResult(
await callGatewayTool("cron.runs", gatewayOpts, { id }),
);