let5see/clawdbot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: align service path tests with platform delimiters

Browse Source
This commit is contained in:
Peter Steinberger
2026-01-24 02:34:50 +00:00
parent 1d862cf5c2
commit a4e57d3ac4
4 changed files with 43 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/daemon/service-env.test.ts
View File

@@ -122,11 +122,14 @@ describe("getMinimalServicePathParts - Linux user directories", () => {
});
describe("buildMinimalServicePath", () => {
const splitPath = (value: string, platform: NodeJS.Platform) =>
value.split(platform === "win32" ? path.win32.delimiter : path.posix.delimiter);
it("includes Homebrew + system dirs on macOS", () => {
const result = buildMinimalServicePath({
platform: "darwin",
});
const parts = result.split(path.delimiter);
const parts = splitPath(result, "darwin");
expect(parts).toContain("/opt/homebrew/bin");
expect(parts).toContain("/usr/local/bin");
expect(parts).toContain("/usr/bin");
@@ -146,7 +149,7 @@ describe("buildMinimalServicePath", () => {
platform: "linux",
env: { HOME: "/home/alice" },
});
const parts = result.split(path.delimiter);
const parts = splitPath(result, "linux");
// Verify user directories are included
expect(parts).toContain("/home/alice/.local/bin");
@@ -164,7 +167,7 @@ describe("buildMinimalServicePath", () => {
platform: "linux",
env: {},
});
const parts = result.split(path.delimiter);
const parts = splitPath(result, "linux");
// Should only have system directories
expect(parts).toEqual(["/usr/local/bin", "/usr/bin", "/bin"]);
@@ -178,7 +181,7 @@ describe("buildMinimalServicePath", () => {
platform: "linux",
env: { HOME: "/home/bob" },
});
const parts = result.split(path.delimiter);
const parts = splitPath(result, "linux");
const firstUserDirIdx = parts.indexOf("/home/bob/.local/bin");
const firstSystemDirIdx = parts.indexOf("/usr/local/bin");
@@ -191,7 +194,7 @@ describe("buildMinimalServicePath", () => {
platform: "linux",
extraDirs: ["/custom/tools"],
});
expect(result.split(path.delimiter)).toContain("/custom/tools");
expect(splitPath(result, "linux")).toContain("/custom/tools");
});
it("deduplicates directories", () => {
@@ -199,7 +202,7 @@ describe("buildMinimalServicePath", () => {
platform: "linux",
extraDirs: ["/usr/bin"],
});
const parts = result.split(path.delimiter);
const parts = splitPath(result, "linux");
const unique = [...new Set(parts)];
expect(parts.length).toBe(unique.length);
});

3
src/daemon/service-env.ts
View File

@@ -121,8 +121,7 @@ export function buildMinimalServicePath(options: BuildServicePathOptions = {}):
return env.PATH ?? "";
}
const delimiter = platform === "win32" ? path.win32.delimiter : path.posix.delimiter;
return getMinimalServicePathPartsFromEnv({ ...options, env }).join(delimiter);
return getMinimalServicePathPartsFromEnv({ ...options, env }).join(path.posix.delimiter);
}
export function buildServiceEnvironment(params: {