feat(config): gate channel config writes

This commit is contained in:
Peter Steinberger
2026-01-15 01:41:11 +00:00
parent f65668cb5f
commit ad8799522c
28 changed files with 576 additions and 2 deletions

View File

@@ -1,11 +1,18 @@
import type { SlackEventMiddlewareArgs } from "@slack/bolt";
import { danger } from "../../../globals.js";
import { loadConfig, writeConfigFile } from "../../../config/config.js";
import { resolveChannelConfigWrites } from "../../../channels/plugins/config-writes.js";
import { danger, warn } from "../../../globals.js";
import { enqueueSystemEvent } from "../../../infra/system-events.js";
import { resolveSlackChannelLabel } from "../channel-config.js";
import type { SlackMonitorContext } from "../context.js";
import type { SlackChannelCreatedEvent, SlackChannelRenamedEvent } from "../types.js";
import { migrateSlackChannelConfig } from "../../channel-migration.js";
import type {
SlackChannelCreatedEvent,
SlackChannelIdChangedEvent,
SlackChannelRenamedEvent,
} from "../types.js";
export function registerSlackChannelEvents(params: { ctx: SlackMonitorContext }) {
const { ctx } = params;
@@ -75,4 +82,74 @@ export function registerSlackChannelEvents(params: { ctx: SlackMonitorContext })
}
},
);
ctx.app.event(
"channel_id_changed",
async ({ event, body }: SlackEventMiddlewareArgs<"channel_id_changed">) => {
try {
if (ctx.shouldDropMismatchedSlackEvent(body)) return;
const payload = event as SlackChannelIdChangedEvent;
const oldChannelId = payload.old_channel_id;
const newChannelId = payload.new_channel_id;
if (!oldChannelId || !newChannelId) return;
const channelInfo = await ctx.resolveChannelName(newChannelId);
const label = resolveSlackChannelLabel({
channelId: newChannelId,
channelName: channelInfo?.name,
});
ctx.runtime.log?.(
warn(`[slack] Channel ID changed: ${oldChannelId}${newChannelId} (${label})`),
);
if (
!resolveChannelConfigWrites({
cfg: ctx.cfg,
channelId: "slack",
accountId: ctx.accountId,
})
) {
ctx.runtime.log?.(
warn("[slack] Config writes disabled; skipping channel config migration."),
);
return;
}
const currentConfig = loadConfig();
const migration = migrateSlackChannelConfig({
cfg: currentConfig,
accountId: ctx.accountId,
oldChannelId,
newChannelId,
});
if (migration.migrated) {
migrateSlackChannelConfig({
cfg: ctx.cfg,
accountId: ctx.accountId,
oldChannelId,
newChannelId,
});
await writeConfigFile(currentConfig);
ctx.runtime.log?.(warn("[slack] Channel config migrated and saved successfully."));
} else if (migration.skippedExisting) {
ctx.runtime.log?.(
warn(
`[slack] Channel config already exists for ${newChannelId}; leaving ${oldChannelId} unchanged`,
),
);
} else {
ctx.runtime.log?.(
warn(
`[slack] No config found for old channel ID ${oldChannelId}; migration logged only`,
),
);
}
} catch (err) {
ctx.runtime.error?.(danger(`slack channel_id_changed handler failed: ${String(err)}`));
}
},
);
}

View File

@@ -46,6 +46,13 @@ export type SlackChannelRenamedEvent = {
event_ts?: string;
};
export type SlackChannelIdChangedEvent = {
type: "channel_id_changed";
old_channel_id?: string;
new_channel_id?: string;
event_ts?: string;
};
export type SlackPinEvent = {
type: "pin_added" | "pin_removed";
channel_id?: string;