fix: add per-channel markdown table conversion (#1495) (thanks @odysseus0)

src/discord/monitor/message-handler.process.ts

@@ -27,6 +27,7 @@ import {
   resolveStorePath,
   updateLastRoute,
 } from "../../config/sessions.js";
+import { resolveMarkdownTableMode } from "../../config/markdown-tables.js";
 import { danger, logVerbose, shouldLogVerbose } from "../../globals.js";
 import { buildAgentSessionKey } from "../../routing/resolve-route.js";
 import { resolveThreadSessionKeys } from "../../routing/session-key.js";
@@ -323,6 +324,11 @@ export async function processDiscordMessage(ctx: DiscordMessagePreflightContext)
   let prefixContext: ResponsePrefixContext = {
     identityName: resolveIdentityName(cfg, route.agentId),
   };
+  const tableMode = resolveMarkdownTableMode({
+    cfg,
+    channel: "discord",
+    accountId,
+  });
 
   const { dispatcher, replyOptions, markDispatchIdle } = createReplyDispatcherWithTyping({
     responsePrefix: resolveEffectiveMessagesConfig(cfg, route.agentId).responsePrefix,
@@ -340,6 +346,7 @@ export async function processDiscordMessage(ctx: DiscordMessagePreflightContext)
         replyToId,
         textLimit,
         maxLinesPerMessage: discordConfig?.maxLinesPerMessage,
+        tableMode,
       });
       replyReference.markSent();
     },

src/discord/monitor/reply-delivery.ts

@@ -1,6 +1,8 @@
 import type { RequestClient } from "@buape/carbon";
 
 import type { ReplyPayload } from "../../auto-reply/types.js";
+import type { MarkdownTableMode } from "../../config/types.base.js";
+import { convertMarkdownTables } from "../../markdown/tables.js";
 import type { RuntimeEnv } from "../../runtime.js";
 import { chunkDiscordText } from "../chunk.js";
 import { sendMessageDiscord } from "../send.js";
@@ -15,11 +17,14 @@ export async function deliverDiscordReply(params: {
   textLimit: number;
   maxLinesPerMessage?: number;
   replyToId?: string;
+  tableMode?: MarkdownTableMode;
 }) {
   const chunkLimit = Math.min(params.textLimit, 2000);
   for (const payload of params.replies) {
     const mediaList = payload.mediaUrls ?? (payload.mediaUrl ? [payload.mediaUrl] : []);
-    const text = payload.text ?? "";
+    const rawText = payload.text ?? "";
+    const tableMode = params.tableMode ?? "code";
+    const text = convertMarkdownTables(rawText, tableMode);
     if (!text && mediaList.length === 0) continue;
     const replyTo = params.replyToId?.trim() || undefined;
 

src/discord/send.outbound.ts

@@ -1,7 +1,9 @@
 import type { RequestClient } from "@buape/carbon";
 import { Routes } from "discord-api-types/v10";
 import { loadConfig } from "../config/config.js";
+import { resolveMarkdownTableMode } from "../config/markdown-tables.js";
 import { recordChannelActivity } from "../infra/channel-activity.js";
+import { convertMarkdownTables } from "../markdown/tables.js";
 import type { RetryConfig } from "../infra/retry.js";
 import type { PollInput } from "../polls.js";
 import { resolveDiscordAccount } from "./accounts.js";
@@ -38,6 +40,12 @@ export async function sendMessageDiscord(
     cfg,
     accountId: opts.accountId,
   });
+  const tableMode = resolveMarkdownTableMode({
+    cfg,
+    channel: "discord",
+    accountId: accountInfo.accountId,
+  });
+  const textWithTables = convertMarkdownTables(text ?? "", tableMode);
   const { token, rest, request } = createDiscordClient(opts, cfg);
   const recipient = parseRecipient(to);
   const { channelId } = await resolveChannelId(rest, recipient, request);
@@ -47,7 +55,7 @@ export async function sendMessageDiscord(
       result = await sendDiscordMedia(
         rest,
         channelId,
-        text,
+        textWithTables,
         opts.mediaUrl,
         opts.replyTo,
         request,
@@ -58,7 +66,7 @@ export async function sendMessageDiscord(
       result = await sendDiscordText(
         rest,
         channelId,
-        text,
+        textWithTables,
         opts.replyTo,
         request,
         accountInfo.config.maxLinesPerMessage,