From bf4544784a23204933f8e345625954ad17368246 Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Fri, 23 Jan 2026 23:30:52 +0000 Subject: [PATCH] fix: stabilize typing + summary merge --- src/channels/typing.ts | 5 +++-- src/discord/monitor/message-handler.process.ts | 7 +++++-- src/slack/monitor/message-handler/dispatch.ts | 1 + 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/channels/typing.ts b/src/channels/typing.ts index 9c47fad89..f24c7f188 100644 --- a/src/channels/typing.ts +++ b/src/channels/typing.ts @@ -9,6 +9,7 @@ export function createTypingCallbacks(params: { onStartError: (err: unknown) => void; onStopError?: (err: unknown) => void; }): TypingCallbacks { + const stop = params.stop; const onReplyStart = async () => { try { await params.start(); @@ -17,9 +18,9 @@ export function createTypingCallbacks(params: { } }; - const onIdle = params.stop + const onIdle = stop ? () => { - void params.stop().catch((err) => (params.onStopError ?? params.onStartError)(err)); + void stop().catch((err) => (params.onStopError ?? params.onStartError)(err)); } : undefined; diff --git a/src/discord/monitor/message-handler.process.ts b/src/discord/monitor/message-handler.process.ts index 5297caf49..f575e6e55 100644 --- a/src/discord/monitor/message-handler.process.ts +++ b/src/discord/monitor/message-handler.process.ts @@ -391,8 +391,11 @@ export async function processDiscordMessage(ctx: DiscordMessagePreflightContext) removeAfterReply: removeAckAfterReply, ackReactionPromise, ackReactionValue: ackReaction, - remove: () => - removeReactionDiscord(message.channelId, message.id, ackReaction, { rest: client.rest }), + remove: async () => { + await removeReactionDiscord(message.channelId, message.id, ackReaction, { + rest: client.rest, + }); + }, onError: (err) => { logAckFailure({ log: logVerbose, diff --git a/src/slack/monitor/message-handler/dispatch.ts b/src/slack/monitor/message-handler/dispatch.ts index 32968aa17..d31885cfa 100644 --- a/src/slack/monitor/message-handler/dispatch.ts +++ b/src/slack/monitor/message-handler/dispatch.ts @@ -68,6 +68,7 @@ export async function dispatchPreparedSlackMessage(prepared: PreparedSlackMessag }, stop: async () => { if (!didSetStatus) return; + didSetStatus = false; await ctx.setSlackThreadStatus({ channelId: message.channel, threadTs: statusThreadTs,