test: cover replyToMode behavior

src/discord/monitor.test.ts

@@ -7,6 +7,7 @@ import {
   resolveDiscordChannelConfig,
   resolveDiscordGuildEntry,
   resolveGroupDmAllow,
+  resolveDiscordReplyTarget,
 } from "./monitor.js";
 
 const fakeGuild = (id: string, name: string) =>
@@ -160,3 +161,49 @@ describe("discord group DM gating", () => {
     ).toBe(false);
   });
 });
+
+describe("discord reply target selection", () => {
+  it("skips replies when mode is off", () => {
+    expect(
+      resolveDiscordReplyTarget({
+        replyToMode: "off",
+        replyToId: "123",
+        hasReplied: false,
+      }),
+    ).toBeUndefined();
+  });
+
+  it("replies only once when mode is first", () => {
+    expect(
+      resolveDiscordReplyTarget({
+        replyToMode: "first",
+        replyToId: "123",
+        hasReplied: false,
+      }),
+    ).toBe("123");
+    expect(
+      resolveDiscordReplyTarget({
+        replyToMode: "first",
+        replyToId: "123",
+        hasReplied: true,
+      }),
+    ).toBeUndefined();
+  });
+
+  it("replies on every message when mode is all", () => {
+    expect(
+      resolveDiscordReplyTarget({
+        replyToMode: "all",
+        replyToId: "123",
+        hasReplied: false,
+      }),
+    ).toBe("123");
+    expect(
+      resolveDiscordReplyTarget({
+        replyToMode: "all",
+        replyToId: "123",
+        hasReplied: true,
+      }),
+    ).toBe("123");
+  });
+});

src/discord/monitor.ts

@@ -67,6 +67,18 @@ export type DiscordChannelConfigResolved = {
   requireMention?: boolean;
 };
 
+export function resolveDiscordReplyTarget(opts: {
+  replyToMode: ReplyToMode;
+  replyToId?: string;
+  hasReplied: boolean;
+}): string | undefined {
+  if (opts.replyToMode === "off") return undefined;
+  const replyToId = opts.replyToId?.trim();
+  if (!replyToId) return undefined;
+  if (opts.replyToMode === "all") return replyToId;
+  return opts.hasReplied ? undefined : replyToId;
+}
+
 function summarizeAllowList(list?: Array<string | number>) {
   if (!list || list.length === 0) return "any";
   const sample = list.slice(0, 4).map((entry) => String(entry));
@@ -1000,19 +1012,20 @@ async function deliverReplies({
     const mediaList =
       payload.mediaUrls ?? (payload.mediaUrl ? [payload.mediaUrl] : []);
     const text = payload.text ?? "";
-    const replyToId =
-      replyToMode === "off" ? undefined : payload.replyToId?.trim();
+    const replyToId = payload.replyToId;
     if (!text && mediaList.length === 0) continue;
     if (mediaList.length === 0) {
       for (const chunk of chunkText(text, 2000)) {
+        const replyTo = resolveDiscordReplyTarget({
+          replyToMode,
+          replyToId,
+          hasReplied,
+        });
         await sendMessageDiscord(target, chunk, {
           token,
-          replyTo:
-            replyToId && (replyToMode === "all" || !hasReplied)
-              ? replyToId
-              : undefined,
+          replyTo,
         });
-        if (replyToId && !hasReplied) {
+        if (replyTo && !hasReplied) {
           hasReplied = true;
         }
       }
@@ -1021,15 +1034,17 @@ async function deliverReplies({
       for (const mediaUrl of mediaList) {
         const caption = first ? text : "";
         first = false;
+        const replyTo = resolveDiscordReplyTarget({
+          replyToMode,
+          replyToId,
+          hasReplied,
+        });
         await sendMessageDiscord(target, caption, {
           token,
           mediaUrl,
-          replyTo:
-            replyToId && (replyToMode === "all" || !hasReplied)
-              ? replyToId
-              : undefined,
+          replyTo,
         });
-        if (replyToId && !hasReplied) {
+        if (replyTo && !hasReplied) {
           hasReplied = true;
         }
       }