let5see/clawdbot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: drain openresponses test responses

Browse Source
This commit is contained in:
Peter Steinberger
2026-01-20 14:17:21 +00:00
parent 5d017dae5a
commit da10ca1585
1 changed files with 34 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
src/gateway/openresponses-http.e2e.test.ts
View File

@@ -60,6 +60,15 @@ function parseSseEvents(text: string): Array<{ event?: string; data: string }> {
return events; return events;
} }
async function ensureResponseConsumed(res: Response) {
if (res.bodyUsed) return;
try {
await res.text();
} catch {
// Ignore drain failures; best-effort to release keep-alive sockets in tests.
}
}
describe("OpenResponses HTTP API (e2e)", () => { describe("OpenResponses HTTP API (e2e)", () => {
it("is disabled by default (requires config)", async () => { it("is disabled by default (requires config)", async () => {
const port = await getFreePort(); const port = await getFreePort();
@@ -70,6 +79,7 @@ describe("OpenResponses HTTP API (e2e)", () => {
input: "hi", input: "hi",
}); });
expect(res.status).toBe(404); expect(res.status).toBe(404);
await ensureResponseConsumed(res);
} finally { } finally {
await server.close({ reason: "test done" }); await server.close({ reason: "test done" });
} }
@@ -86,6 +96,7 @@ describe("OpenResponses HTTP API (e2e)", () => {
input: "hi", input: "hi",
}); });
expect(res.status).toBe(404); expect(res.status).toBe(404);
await ensureResponseConsumed(res);
} finally { } finally {
await server.close({ reason: "test done" }); await server.close({ reason: "test done" });
} }
@@ -100,6 +111,7 @@ describe("OpenResponses HTTP API (e2e)", () => {
headers: { authorization: "Bearer secret" }, headers: { authorization: "Bearer secret" },
}); });
expect(res.status).toBe(405); expect(res.status).toBe(405);
await ensureResponseConsumed(res);
} finally { } finally {
await server.close({ reason: "test done" }); await server.close({ reason: "test done" });
} }
@@ -115,6 +127,7 @@ describe("OpenResponses HTTP API (e2e)", () => {
body: JSON.stringify({ model: "clawdbot", input: "hi" }), body: JSON.stringify({ model: "clawdbot", input: "hi" }),
}); });
expect(res.status).toBe(401); expect(res.status).toBe(401);
await ensureResponseConsumed(res);
} finally { } finally {
await server.close({ reason: "test done" }); await server.close({ reason: "test done" });
} }
@@ -130,6 +143,7 @@ describe("OpenResponses HTTP API (e2e)", () => {
expect((json.error as Record<string, unknown> | undefined)?.type).toBe( expect((json.error as Record<string, unknown> | undefined)?.type).toBe(
"invalid_request_error", "invalid_request_error",
); );
await ensureResponseConsumed(res);
} finally { } finally {
await server.close({ reason: "test done" }); await server.close({ reason: "test done" });
} }
@@ -155,6 +169,7 @@ describe("OpenResponses HTTP API (e2e)", () => {
expect((opts as { sessionKey?: string } | undefined)?.sessionKey ?? "").toMatch( expect((opts as { sessionKey?: string } | undefined)?.sessionKey ?? "").toMatch(
/^agent:beta:/, /^agent:beta:/,
); );
await ensureResponseConsumed(res);
} finally { } finally {
await server.close({ reason: "test done" }); await server.close({ reason: "test done" });
} }
@@ -179,6 +194,7 @@ describe("OpenResponses HTTP API (e2e)", () => {
expect((opts as { sessionKey?: string } | undefined)?.sessionKey ?? "").toMatch( expect((opts as { sessionKey?: string } | undefined)?.sessionKey ?? "").toMatch(
/^agent:beta:/, /^agent:beta:/,
); );
await ensureResponseConsumed(res);
} finally { } finally {
await server.close({ reason: "test done" }); await server.close({ reason: "test done" });
} }
@@ -203,6 +219,7 @@ describe("OpenResponses HTTP API (e2e)", () => {
expect((opts as { sessionKey?: string } | undefined)?.sessionKey ?? "").toContain( expect((opts as { sessionKey?: string } | undefined)?.sessionKey ?? "").toContain(
"openresponses-user:alice", "openresponses-user:alice",
); );
await ensureResponseConsumed(res);
} finally { } finally {
await server.close({ reason: "test done" }); await server.close({ reason: "test done" });
} }
@@ -224,6 +241,7 @@ describe("OpenResponses HTTP API (e2e)", () => {
const [opts] = agentCommand.mock.calls[0] ?? []; const [opts] = agentCommand.mock.calls[0] ?? [];
expect((opts as { message?: string } | undefined)?.message).toBe("hello world"); expect((opts as { message?: string } | undefined)?.message).toBe("hello world");
await ensureResponseConsumed(res);
} finally { } finally {
await server.close({ reason: "test done" }); await server.close({ reason: "test done" });
} }
@@ -245,6 +263,7 @@ describe("OpenResponses HTTP API (e2e)", () => {
const [opts] = agentCommand.mock.calls[0] ?? []; const [opts] = agentCommand.mock.calls[0] ?? [];
expect((opts as { message?: string } | undefined)?.message).toBe("hello there"); expect((opts as { message?: string } | undefined)?.message).toBe("hello there");
await ensureResponseConsumed(res);
} finally { } finally {
await server.close({ reason: "test done" }); await server.close({ reason: "test done" });
} }
@@ -273,6 +292,7 @@ describe("OpenResponses HTTP API (e2e)", () => {
(opts as { extraSystemPrompt?: string } | undefined)?.extraSystemPrompt ?? ""; (opts as { extraSystemPrompt?: string } | undefined)?.extraSystemPrompt ?? "";
expect(extraSystemPrompt).toContain("You are a helpful assistant."); expect(extraSystemPrompt).toContain("You are a helpful assistant.");
expect(extraSystemPrompt).toContain("Be concise."); expect(extraSystemPrompt).toContain("Be concise.");
await ensureResponseConsumed(res);
} finally { } finally {
await server.close({ reason: "test done" }); await server.close({ reason: "test done" });
} }
@@ -297,6 +317,7 @@ describe("OpenResponses HTTP API (e2e)", () => {
const extraSystemPrompt = const extraSystemPrompt =
(opts as { extraSystemPrompt?: string } | undefined)?.extraSystemPrompt ?? ""; (opts as { extraSystemPrompt?: string } | undefined)?.extraSystemPrompt ?? "";
expect(extraSystemPrompt).toContain("Always respond in French."); expect(extraSystemPrompt).toContain("Always respond in French.");
await ensureResponseConsumed(res);
} finally { } finally {
await server.close({ reason: "test done" }); await server.close({ reason: "test done" });
} }
@@ -328,6 +349,7 @@ describe("OpenResponses HTTP API (e2e)", () => {
expect(message).toContain("Assistant: I am Claude."); expect(message).toContain("Assistant: I am Claude.");
expect(message).toContain(CURRENT_MESSAGE_MARKER); expect(message).toContain(CURRENT_MESSAGE_MARKER);
expect(message).toContain("User: What did I just ask you?"); expect(message).toContain("User: What did I just ask you?");
await ensureResponseConsumed(res);
} finally { } finally {
await server.close({ reason: "test done" }); await server.close({ reason: "test done" });
} }
@@ -353,6 +375,7 @@ describe("OpenResponses HTTP API (e2e)", () => {
const [opts] = agentCommand.mock.calls[0] ?? []; const [opts] = agentCommand.mock.calls[0] ?? [];
const message = (opts as { message?: string } | undefined)?.message ?? ""; const message = (opts as { message?: string } | undefined)?.message ?? "";
expect(message).toContain("Sunny, 70F."); expect(message).toContain("Sunny, 70F.");
await ensureResponseConsumed(res);
} finally { } finally {
await server.close({ reason: "test done" }); await server.close({ reason: "test done" });
} }
@@ -395,6 +418,7 @@ describe("OpenResponses HTTP API (e2e)", () => {
(opts as { extraSystemPrompt?: string } | undefined)?.extraSystemPrompt ?? ""; (opts as { extraSystemPrompt?: string } | undefined)?.extraSystemPrompt ?? "";
expect(message).toBe("read this"); expect(message).toBe("read this");
expect(extraSystemPrompt).toContain('<file name="hello.txt">'); expect(extraSystemPrompt).toContain('<file name="hello.txt">');
await ensureResponseConsumed(res);
} finally { } finally {
await server.close({ reason: "test done" }); await server.close({ reason: "test done" });
} }
@@ -423,6 +447,7 @@ describe("OpenResponses HTTP API (e2e)", () => {
const [opts] = agentCommand.mock.calls[0] ?? []; const [opts] = agentCommand.mock.calls[0] ?? [];
expect((opts as { clientTools?: unknown[] } | undefined)?.clientTools).toBeUndefined(); expect((opts as { clientTools?: unknown[] } | undefined)?.clientTools).toBeUndefined();
await ensureResponseConsumed(res);
} finally { } finally {
await server.close({ reason: "test done" }); await server.close({ reason: "test done" });
} }
@@ -458,6 +483,7 @@ describe("OpenResponses HTTP API (e2e)", () => {
(opts as { clientTools?: Array<{ function?: { name?: string } }> })?.clientTools ?? []; (opts as { clientTools?: Array<{ function?: { name?: string } }> })?.clientTools ?? [];
expect(clientTools).toHaveLength(1); expect(clientTools).toHaveLength(1);
expect(clientTools[0]?.function?.name).toBe("get_time"); expect(clientTools[0]?.function?.name).toBe("get_time");
await ensureResponseConsumed(res);
} finally { } finally {
await server.close({ reason: "test done" }); await server.close({ reason: "test done" });
} }
@@ -479,6 +505,7 @@ describe("OpenResponses HTTP API (e2e)", () => {
tool_choice: { type: "function", function: { name: "unknown_tool" } }, tool_choice: { type: "function", function: { name: "unknown_tool" } },
}); });
expect(res.status).toBe(400); expect(res.status).toBe(400);
await ensureResponseConsumed(res);
} finally { } finally {
await server.close({ reason: "test done" }); await server.close({ reason: "test done" });
} }
@@ -503,6 +530,7 @@ describe("OpenResponses HTTP API (e2e)", () => {
expect( expect(
(opts as { streamParams?: { maxTokens?: number } } | undefined)?.streamParams?.maxTokens, (opts as { streamParams?: { maxTokens?: number } } | undefined)?.streamParams?.maxTokens,
).toBe(123); ).toBe(123);
await ensureResponseConsumed(res);
} finally { } finally {
await server.close({ reason: "test done" }); await server.close({ reason: "test done" });
} }
@@ -529,6 +557,7 @@ describe("OpenResponses HTTP API (e2e)", () => {
expect(res.status).toBe(200); expect(res.status).toBe(200);
const json = (await res.json()) as Record<string, unknown>; const json = (await res.json()) as Record<string, unknown>;
expect(json.usage).toEqual({ input_tokens: 3, output_tokens: 5, total_tokens: 10 }); expect(json.usage).toEqual({ input_tokens: 3, output_tokens: 5, total_tokens: 10 });
await ensureResponseConsumed(res);
} finally { } finally {
await server.close({ reason: "test done" }); await server.close({ reason: "test done" });
} }
@@ -563,6 +592,7 @@ describe("OpenResponses HTTP API (e2e)", () => {
expect(content.length).toBe(1); expect(content.length).toBe(1);
expect(content[0]?.type).toBe("output_text"); expect(content[0]?.type).toBe("output_text");
expect(content[0]?.text).toBe("hello"); expect(content[0]?.text).toBe("hello");
await ensureResponseConsumed(res);
} finally { } finally {
await server.close({ reason: "test done" }); await server.close({ reason: "test done" });
} }
@@ -581,6 +611,7 @@ describe("OpenResponses HTTP API (e2e)", () => {
expect((json.error as Record<string, unknown> | undefined)?.type).toBe( expect((json.error as Record<string, unknown> | undefined)?.type).toBe(
"invalid_request_error", "invalid_request_error",
); );
await ensureResponseConsumed(res);
} finally { } finally {
await server.close({ reason: "test done" }); await server.close({ reason: "test done" });
} }
@@ -631,6 +662,7 @@ describe("OpenResponses HTTP API (e2e)", () => {
}) })
.join(""); .join("");
expect(allDeltas).toBe("hello"); expect(allDeltas).toBe("hello");
await ensureResponseConsumed(res);
} finally { } finally {
await server.close({ reason: "test done" }); await server.close({ reason: "test done" });
} }
@@ -653,6 +685,7 @@ describe("OpenResponses HTTP API (e2e)", () => {
const text = await res.text(); const text = await res.text();
expect(text).toContain("[DONE]"); expect(text).toContain("[DONE]");
expect(text).toContain("hello"); expect(text).toContain("hello");
await ensureResponseConsumed(res);
} finally { } finally {
await server.close({ reason: "test done" }); await server.close({ reason: "test done" });
} }
@@ -681,6 +714,7 @@ describe("OpenResponses HTTP API (e2e)", () => {
const parsed = JSON.parse(event.data) as { type?: string }; const parsed = JSON.parse(event.data) as { type?: string };
expect(event.event).toBe(parsed.type); expect(event.event).toBe(parsed.type);
} }
await ensureResponseConsumed(res);
} finally { } finally {
await server.close({ reason: "test done" }); await server.close({ reason: "test done" });
} }