From 8b4696c087aed2256c74d106b58367406fb96a53 Mon Sep 17 00:00:00 2001 From: zerone0x Date: Sun, 25 Jan 2026 15:24:02 +0800 Subject: [PATCH 1/3] fix(voice-call): validate provider credentials from env vars The `validateProviderConfig()` function now checks both config values AND environment variables when validating provider credentials. This aligns the validation behavior with `resolveProvider()` which already falls back to env vars. Previously, users who set credentials via environment variables would get validation errors even though the credentials would be found at runtime. The error messages correctly suggested env vars as an alternative, but the validation didn't actually check them. Affects all three supported providers: Twilio, Telnyx, and Plivo. Fixes #1709 Co-Authored-By: Claude --- extensions/voice-call/src/config.test.ts | 196 +++++++++++++++++++++++ extensions/voice-call/src/config.ts | 12 +- 2 files changed, 202 insertions(+), 6 deletions(-) create mode 100644 extensions/voice-call/src/config.test.ts diff --git a/extensions/voice-call/src/config.test.ts b/extensions/voice-call/src/config.test.ts new file mode 100644 index 000000000..3a4311c8a --- /dev/null +++ b/extensions/voice-call/src/config.test.ts @@ -0,0 +1,196 @@ +import { afterEach, beforeEach, describe, expect, it } from "vitest"; + +import { validateProviderConfig, type VoiceCallConfig } from "./config.js"; + +function createBaseConfig( + provider: "telnyx" | "twilio" | "plivo" | "mock", +): VoiceCallConfig { + return { + enabled: true, + provider, + fromNumber: "+15550001234", + inboundPolicy: "disabled", + allowFrom: [], + outbound: { defaultMode: "notify", notifyHangupDelaySec: 3 }, + maxDurationSeconds: 300, + silenceTimeoutMs: 800, + transcriptTimeoutMs: 180000, + ringTimeoutMs: 30000, + maxConcurrentCalls: 1, + serve: { port: 3334, bind: "127.0.0.1", path: "/voice/webhook" }, + tailscale: { mode: "off", path: "/voice/webhook" }, + tunnel: { provider: "none", allowNgrokFreeTier: true }, + streaming: { + enabled: false, + sttProvider: "openai-realtime", + sttModel: "gpt-4o-transcribe", + silenceDurationMs: 800, + vadThreshold: 0.5, + streamPath: "/voice/stream", + }, + skipSignatureVerification: false, + stt: { provider: "openai", model: "whisper-1" }, + tts: { provider: "openai", model: "gpt-4o-mini-tts", voice: "coral" }, + responseModel: "openai/gpt-4o-mini", + responseTimeoutMs: 30000, + }; +} + +describe("validateProviderConfig", () => { + const originalEnv = { ...process.env }; + + beforeEach(() => { + // Clear all relevant env vars before each test + delete process.env.TWILIO_ACCOUNT_SID; + delete process.env.TWILIO_AUTH_TOKEN; + delete process.env.TELNYX_API_KEY; + delete process.env.TELNYX_CONNECTION_ID; + delete process.env.PLIVO_AUTH_ID; + delete process.env.PLIVO_AUTH_TOKEN; + }); + + afterEach(() => { + // Restore original env + process.env = { ...originalEnv }; + }); + + describe("twilio provider", () => { + it("passes validation when credentials are in config", () => { + const config = createBaseConfig("twilio"); + config.twilio = { accountSid: "AC123", authToken: "secret" }; + + const result = validateProviderConfig(config); + + expect(result.valid).toBe(true); + expect(result.errors).toEqual([]); + }); + + it("passes validation when credentials are in environment variables", () => { + process.env.TWILIO_ACCOUNT_SID = "AC123"; + process.env.TWILIO_AUTH_TOKEN = "secret"; + const config = createBaseConfig("twilio"); + + const result = validateProviderConfig(config); + + expect(result.valid).toBe(true); + expect(result.errors).toEqual([]); + }); + + it("passes validation with mixed config and env vars", () => { + process.env.TWILIO_AUTH_TOKEN = "secret"; + const config = createBaseConfig("twilio"); + config.twilio = { accountSid: "AC123" }; + + const result = validateProviderConfig(config); + + expect(result.valid).toBe(true); + expect(result.errors).toEqual([]); + }); + + it("fails validation when accountSid is missing everywhere", () => { + process.env.TWILIO_AUTH_TOKEN = "secret"; + const config = createBaseConfig("twilio"); + + const result = validateProviderConfig(config); + + expect(result.valid).toBe(false); + expect(result.errors).toContain( + "plugins.entries.voice-call.config.twilio.accountSid is required (or set TWILIO_ACCOUNT_SID env)", + ); + }); + + it("fails validation when authToken is missing everywhere", () => { + process.env.TWILIO_ACCOUNT_SID = "AC123"; + const config = createBaseConfig("twilio"); + + const result = validateProviderConfig(config); + + expect(result.valid).toBe(false); + expect(result.errors).toContain( + "plugins.entries.voice-call.config.twilio.authToken is required (or set TWILIO_AUTH_TOKEN env)", + ); + }); + }); + + describe("telnyx provider", () => { + it("passes validation when credentials are in config", () => { + const config = createBaseConfig("telnyx"); + config.telnyx = { apiKey: "KEY123", connectionId: "CONN456" }; + + const result = validateProviderConfig(config); + + expect(result.valid).toBe(true); + expect(result.errors).toEqual([]); + }); + + it("passes validation when credentials are in environment variables", () => { + process.env.TELNYX_API_KEY = "KEY123"; + process.env.TELNYX_CONNECTION_ID = "CONN456"; + const config = createBaseConfig("telnyx"); + + const result = validateProviderConfig(config); + + expect(result.valid).toBe(true); + expect(result.errors).toEqual([]); + }); + + it("fails validation when apiKey is missing everywhere", () => { + process.env.TELNYX_CONNECTION_ID = "CONN456"; + const config = createBaseConfig("telnyx"); + + const result = validateProviderConfig(config); + + expect(result.valid).toBe(false); + expect(result.errors).toContain( + "plugins.entries.voice-call.config.telnyx.apiKey is required (or set TELNYX_API_KEY env)", + ); + }); + }); + + describe("plivo provider", () => { + it("passes validation when credentials are in config", () => { + const config = createBaseConfig("plivo"); + config.plivo = { authId: "MA123", authToken: "secret" }; + + const result = validateProviderConfig(config); + + expect(result.valid).toBe(true); + expect(result.errors).toEqual([]); + }); + + it("passes validation when credentials are in environment variables", () => { + process.env.PLIVO_AUTH_ID = "MA123"; + process.env.PLIVO_AUTH_TOKEN = "secret"; + const config = createBaseConfig("plivo"); + + const result = validateProviderConfig(config); + + expect(result.valid).toBe(true); + expect(result.errors).toEqual([]); + }); + + it("fails validation when authId is missing everywhere", () => { + process.env.PLIVO_AUTH_TOKEN = "secret"; + const config = createBaseConfig("plivo"); + + const result = validateProviderConfig(config); + + expect(result.valid).toBe(false); + expect(result.errors).toContain( + "plugins.entries.voice-call.config.plivo.authId is required (or set PLIVO_AUTH_ID env)", + ); + }); + }); + + describe("disabled config", () => { + it("skips validation when enabled is false", () => { + const config = createBaseConfig("twilio"); + config.enabled = false; + + const result = validateProviderConfig(config); + + expect(result.valid).toBe(true); + expect(result.errors).toEqual([]); + }); + }); +}); diff --git a/extensions/voice-call/src/config.ts b/extensions/voice-call/src/config.ts index 832e692ca..403a2eb89 100644 --- a/extensions/voice-call/src/config.ts +++ b/extensions/voice-call/src/config.ts @@ -352,12 +352,12 @@ export function validateProviderConfig(config: VoiceCallConfig): { } if (config.provider === "telnyx") { - if (!config.telnyx?.apiKey) { + if (!config.telnyx?.apiKey && !process.env.TELNYX_API_KEY) { errors.push( "plugins.entries.voice-call.config.telnyx.apiKey is required (or set TELNYX_API_KEY env)", ); } - if (!config.telnyx?.connectionId) { + if (!config.telnyx?.connectionId && !process.env.TELNYX_CONNECTION_ID) { errors.push( "plugins.entries.voice-call.config.telnyx.connectionId is required (or set TELNYX_CONNECTION_ID env)", ); @@ -365,12 +365,12 @@ export function validateProviderConfig(config: VoiceCallConfig): { } if (config.provider === "twilio") { - if (!config.twilio?.accountSid) { + if (!config.twilio?.accountSid && !process.env.TWILIO_ACCOUNT_SID) { errors.push( "plugins.entries.voice-call.config.twilio.accountSid is required (or set TWILIO_ACCOUNT_SID env)", ); } - if (!config.twilio?.authToken) { + if (!config.twilio?.authToken && !process.env.TWILIO_AUTH_TOKEN) { errors.push( "plugins.entries.voice-call.config.twilio.authToken is required (or set TWILIO_AUTH_TOKEN env)", ); @@ -378,12 +378,12 @@ export function validateProviderConfig(config: VoiceCallConfig): { } if (config.provider === "plivo") { - if (!config.plivo?.authId) { + if (!config.plivo?.authId && !process.env.PLIVO_AUTH_ID) { errors.push( "plugins.entries.voice-call.config.plivo.authId is required (or set PLIVO_AUTH_ID env)", ); } - if (!config.plivo?.authToken) { + if (!config.plivo?.authToken && !process.env.PLIVO_AUTH_TOKEN) { errors.push( "plugins.entries.voice-call.config.plivo.authToken is required (or set PLIVO_AUTH_TOKEN env)", ); From d37df28319da750ecfeb5416c0297b8a25e58ed2 Mon Sep 17 00:00:00 2001 From: Shakker Nerd Date: Mon, 26 Jan 2026 14:01:08 +0000 Subject: [PATCH 2/3] feat: Resolve voice call configuration by merging environment variables into settings. --- extensions/voice-call/index.ts | 16 ++++---- extensions/voice-call/src/config.ts | 58 +++++++++++++++++++++++++--- extensions/voice-call/src/runtime.ts | 27 +++++++------ 3 files changed, 74 insertions(+), 27 deletions(-) diff --git a/extensions/voice-call/index.ts b/extensions/voice-call/index.ts index 760726faa..60076bbe2 100644 --- a/extensions/voice-call/index.ts +++ b/extensions/voice-call/index.ts @@ -1,8 +1,8 @@ import { Type } from "@sinclair/typebox"; - import type { CoreConfig } from "./src/core-bridge.js"; import { VoiceCallConfigSchema, + resolveVoiceCallConfig, validateProviderConfig, type VoiceCallConfig, } from "./src/config.js"; @@ -145,8 +145,10 @@ const voiceCallPlugin = { description: "Voice-call plugin with Telnyx/Twilio/Plivo providers", configSchema: voiceCallConfigSchema, register(api) { - const cfg = voiceCallConfigSchema.parse(api.pluginConfig); - const validation = validateProviderConfig(cfg); + const config = resolveVoiceCallConfig( + voiceCallConfigSchema.parse(api.pluginConfig), + ); + const validation = validateProviderConfig(config); if (api.pluginConfig && typeof api.pluginConfig === "object") { const raw = api.pluginConfig as Record; @@ -167,7 +169,7 @@ const voiceCallPlugin = { let runtime: VoiceCallRuntime | null = null; const ensureRuntime = async () => { - if (!cfg.enabled) { + if (!config.enabled) { throw new Error("Voice call disabled in plugin config"); } if (!validation.valid) { @@ -176,7 +178,7 @@ const voiceCallPlugin = { if (runtime) return runtime; if (!runtimePromise) { runtimePromise = createVoiceCallRuntime({ - config: cfg, + config, coreConfig: api.config as CoreConfig, ttsRuntime: api.runtime.tts, logger: api.logger, @@ -457,7 +459,7 @@ const voiceCallPlugin = { ({ program }) => registerVoiceCallCli({ program, - config: cfg, + config, ensureRuntime, logger: api.logger, }), @@ -467,7 +469,7 @@ const voiceCallPlugin = { api.registerService({ id: "voicecall", start: async () => { - if (!cfg.enabled) return; + if (!config.enabled) return; try { await ensureRuntime(); } catch (err) { diff --git a/extensions/voice-call/src/config.ts b/extensions/voice-call/src/config.ts index 1a3a9bbbd..6d6036792 100644 --- a/extensions/voice-call/src/config.ts +++ b/extensions/voice-call/src/config.ts @@ -381,6 +381,52 @@ export type VoiceCallConfig = z.infer; // Configuration Helpers // ----------------------------------------------------------------------------- +/** + * Resolves the configuration by merging environment variables into missing fields. + * Returns a new configuration object with environment variables applied. + */ +export function resolveVoiceCallConfig(config: VoiceCallConfig): VoiceCallConfig { + const resolved = JSON.parse(JSON.stringify(config)) as VoiceCallConfig; + + // Telnyx + if (resolved.provider === "telnyx") { + resolved.telnyx = resolved.telnyx ?? {}; + resolved.telnyx.apiKey = + resolved.telnyx.apiKey ?? process.env.TELNYX_API_KEY; + resolved.telnyx.connectionId = + resolved.telnyx.connectionId ?? process.env.TELNYX_CONNECTION_ID; + resolved.telnyx.publicKey = + resolved.telnyx.publicKey ?? process.env.TELNYX_PUBLIC_KEY; + } + + // Twilio + if (resolved.provider === "twilio") { + resolved.twilio = resolved.twilio ?? {}; + resolved.twilio.accountSid = + resolved.twilio.accountSid ?? process.env.TWILIO_ACCOUNT_SID; + resolved.twilio.authToken = + resolved.twilio.authToken ?? process.env.TWILIO_AUTH_TOKEN; + } + + // Plivo + if (resolved.provider === "plivo") { + resolved.plivo = resolved.plivo ?? {}; + resolved.plivo.authId = + resolved.plivo.authId ?? process.env.PLIVO_AUTH_ID; + resolved.plivo.authToken = + resolved.plivo.authToken ?? process.env.PLIVO_AUTH_TOKEN; + } + + // Tunnel Config + resolved.tunnel = resolved.tunnel ?? { provider: "none", allowNgrokFreeTier: true }; + resolved.tunnel.ngrokAuthToken = + resolved.tunnel.ngrokAuthToken ?? process.env.NGROK_AUTHTOKEN; + resolved.tunnel.ngrokDomain = + resolved.tunnel.ngrokDomain ?? process.env.NGROK_DOMAIN; + + return resolved; +} + /** * Validate that the configuration has all required fields for the selected provider. */ @@ -403,12 +449,12 @@ export function validateProviderConfig(config: VoiceCallConfig): { } if (config.provider === "telnyx") { - if (!config.telnyx?.apiKey && !process.env.TELNYX_API_KEY) { + if (!config.telnyx?.apiKey) { errors.push( "plugins.entries.voice-call.config.telnyx.apiKey is required (or set TELNYX_API_KEY env)", ); } - if (!config.telnyx?.connectionId && !process.env.TELNYX_CONNECTION_ID) { + if (!config.telnyx?.connectionId) { errors.push( "plugins.entries.voice-call.config.telnyx.connectionId is required (or set TELNYX_CONNECTION_ID env)", ); @@ -416,12 +462,12 @@ export function validateProviderConfig(config: VoiceCallConfig): { } if (config.provider === "twilio") { - if (!config.twilio?.accountSid && !process.env.TWILIO_ACCOUNT_SID) { + if (!config.twilio?.accountSid) { errors.push( "plugins.entries.voice-call.config.twilio.accountSid is required (or set TWILIO_ACCOUNT_SID env)", ); } - if (!config.twilio?.authToken && !process.env.TWILIO_AUTH_TOKEN) { + if (!config.twilio?.authToken) { errors.push( "plugins.entries.voice-call.config.twilio.authToken is required (or set TWILIO_AUTH_TOKEN env)", ); @@ -429,12 +475,12 @@ export function validateProviderConfig(config: VoiceCallConfig): { } if (config.provider === "plivo") { - if (!config.plivo?.authId && !process.env.PLIVO_AUTH_ID) { + if (!config.plivo?.authId) { errors.push( "plugins.entries.voice-call.config.plivo.authId is required (or set PLIVO_AUTH_ID env)", ); } - if (!config.plivo?.authToken && !process.env.PLIVO_AUTH_TOKEN) { + if (!config.plivo?.authToken) { errors.push( "plugins.entries.voice-call.config.plivo.authToken is required (or set PLIVO_AUTH_TOKEN env)", ); diff --git a/extensions/voice-call/src/runtime.ts b/extensions/voice-call/src/runtime.ts index 0770333cd..a2eb15315 100644 --- a/extensions/voice-call/src/runtime.ts +++ b/extensions/voice-call/src/runtime.ts @@ -1,6 +1,6 @@ import type { CoreConfig } from "./core-bridge.js"; import type { VoiceCallConfig } from "./config.js"; -import { validateProviderConfig } from "./config.js"; +import { resolveVoiceCallConfig, validateProviderConfig } from "./config.js"; import { CallManager } from "./manager.js"; import type { VoiceCallProvider } from "./providers/base.js"; import { MockProvider } from "./providers/mock.js"; @@ -37,17 +37,15 @@ function resolveProvider(config: VoiceCallConfig): VoiceCallProvider { switch (config.provider) { case "telnyx": return new TelnyxProvider({ - apiKey: config.telnyx?.apiKey ?? process.env.TELNYX_API_KEY, - connectionId: - config.telnyx?.connectionId ?? process.env.TELNYX_CONNECTION_ID, - publicKey: config.telnyx?.publicKey ?? process.env.TELNYX_PUBLIC_KEY, + apiKey: config.telnyx?.apiKey, + connectionId: config.telnyx?.connectionId, + publicKey: config.telnyx?.publicKey, }); case "twilio": return new TwilioProvider( { - accountSid: - config.twilio?.accountSid ?? process.env.TWILIO_ACCOUNT_SID, - authToken: config.twilio?.authToken ?? process.env.TWILIO_AUTH_TOKEN, + accountSid: config.twilio?.accountSid, + authToken: config.twilio?.authToken, }, { allowNgrokFreeTier: config.tunnel?.allowNgrokFreeTier ?? true, @@ -61,8 +59,8 @@ function resolveProvider(config: VoiceCallConfig): VoiceCallProvider { case "plivo": return new PlivoProvider( { - authId: config.plivo?.authId ?? process.env.PLIVO_AUTH_ID, - authToken: config.plivo?.authToken ?? process.env.PLIVO_AUTH_TOKEN, + authId: config.plivo?.authId, + authToken: config.plivo?.authToken, }, { publicUrl: config.publicUrl, @@ -85,7 +83,7 @@ export async function createVoiceCallRuntime(params: { ttsRuntime?: TelephonyTtsRuntime; logger?: Logger; }): Promise { - const { config, coreConfig, ttsRuntime, logger } = params; + const { config: rawConfig, coreConfig, ttsRuntime, logger } = params; const log = logger ?? { info: console.log, warn: console.warn, @@ -93,6 +91,8 @@ export async function createVoiceCallRuntime(params: { debug: console.debug, }; + const config = resolveVoiceCallConfig(rawConfig); + if (!config.enabled) { throw new Error( "Voice call disabled. Enable the plugin entry in config.", @@ -125,9 +125,8 @@ export async function createVoiceCallRuntime(params: { provider: config.tunnel.provider, port: config.serve.port, path: config.serve.path, - ngrokAuthToken: - config.tunnel.ngrokAuthToken ?? process.env.NGROK_AUTHTOKEN, - ngrokDomain: config.tunnel.ngrokDomain ?? process.env.NGROK_DOMAIN, + ngrokAuthToken: config.tunnel.ngrokAuthToken, + ngrokDomain: config.tunnel.ngrokDomain, }); publicUrl = tunnelResult?.publicUrl ?? null; } catch (err) { From 6918fbc0bdce20b0f1ccfcf4a98b08b2856a5034 Mon Sep 17 00:00:00 2001 From: Shakker Nerd Date: Mon, 26 Jan 2026 14:11:45 +0000 Subject: [PATCH 3/3] test: incorporate `resolveVoiceCallConfig` into config validation tests. --- extensions/voice-call/src/config.test.ts | 26 ++++++++++++++++-------- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/extensions/voice-call/src/config.test.ts b/extensions/voice-call/src/config.test.ts index 3a4311c8a..7334498e2 100644 --- a/extensions/voice-call/src/config.test.ts +++ b/extensions/voice-call/src/config.test.ts @@ -1,6 +1,6 @@ import { afterEach, beforeEach, describe, expect, it } from "vitest"; -import { validateProviderConfig, type VoiceCallConfig } from "./config.js"; +import { validateProviderConfig, resolveVoiceCallConfig, type VoiceCallConfig } from "./config.js"; function createBaseConfig( provider: "telnyx" | "twilio" | "plivo" | "mock", @@ -68,7 +68,8 @@ describe("validateProviderConfig", () => { it("passes validation when credentials are in environment variables", () => { process.env.TWILIO_ACCOUNT_SID = "AC123"; process.env.TWILIO_AUTH_TOKEN = "secret"; - const config = createBaseConfig("twilio"); + let config = createBaseConfig("twilio"); + config = resolveVoiceCallConfig(config); const result = validateProviderConfig(config); @@ -78,8 +79,9 @@ describe("validateProviderConfig", () => { it("passes validation with mixed config and env vars", () => { process.env.TWILIO_AUTH_TOKEN = "secret"; - const config = createBaseConfig("twilio"); + let config = createBaseConfig("twilio"); config.twilio = { accountSid: "AC123" }; + config = resolveVoiceCallConfig(config); const result = validateProviderConfig(config); @@ -89,7 +91,8 @@ describe("validateProviderConfig", () => { it("fails validation when accountSid is missing everywhere", () => { process.env.TWILIO_AUTH_TOKEN = "secret"; - const config = createBaseConfig("twilio"); + let config = createBaseConfig("twilio"); + config = resolveVoiceCallConfig(config); const result = validateProviderConfig(config); @@ -101,7 +104,8 @@ describe("validateProviderConfig", () => { it("fails validation when authToken is missing everywhere", () => { process.env.TWILIO_ACCOUNT_SID = "AC123"; - const config = createBaseConfig("twilio"); + let config = createBaseConfig("twilio"); + config = resolveVoiceCallConfig(config); const result = validateProviderConfig(config); @@ -126,7 +130,8 @@ describe("validateProviderConfig", () => { it("passes validation when credentials are in environment variables", () => { process.env.TELNYX_API_KEY = "KEY123"; process.env.TELNYX_CONNECTION_ID = "CONN456"; - const config = createBaseConfig("telnyx"); + let config = createBaseConfig("telnyx"); + config = resolveVoiceCallConfig(config); const result = validateProviderConfig(config); @@ -136,7 +141,8 @@ describe("validateProviderConfig", () => { it("fails validation when apiKey is missing everywhere", () => { process.env.TELNYX_CONNECTION_ID = "CONN456"; - const config = createBaseConfig("telnyx"); + let config = createBaseConfig("telnyx"); + config = resolveVoiceCallConfig(config); const result = validateProviderConfig(config); @@ -161,7 +167,8 @@ describe("validateProviderConfig", () => { it("passes validation when credentials are in environment variables", () => { process.env.PLIVO_AUTH_ID = "MA123"; process.env.PLIVO_AUTH_TOKEN = "secret"; - const config = createBaseConfig("plivo"); + let config = createBaseConfig("plivo"); + config = resolveVoiceCallConfig(config); const result = validateProviderConfig(config); @@ -171,7 +178,8 @@ describe("validateProviderConfig", () => { it("fails validation when authId is missing everywhere", () => { process.env.PLIVO_AUTH_TOKEN = "secret"; - const config = createBaseConfig("plivo"); + let config = createBaseConfig("plivo"); + config = resolveVoiceCallConfig(config); const result = validateProviderConfig(config);