let5see/clawdbot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(model-catalog): avoid caching import failures

Browse Source 
Move dynamic import of @mariozechner/pi-coding-agent into the try/catch so transient module resolution errors don't poison the model catalog cache with a rejected promise.

This previously caused Discord/Telegram handlers and heartbeat to fail until process restart if the import failed once.
This commit is contained in:
Doug von Kohorn
2026-01-20 20:09:55 +01:00
parent c6812c6af4
commit e4f9555f21
1 changed files with 17 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/agents/model-catalog.ts
View File

@@ -34,10 +34,14 @@ export async function loadModelCatalog(params?: {
if (modelCatalogPromise) return modelCatalogPromise; if (modelCatalogPromise) return modelCatalogPromise;
modelCatalogPromise = (async () => { modelCatalogPromise = (async () => {
const piSdk = await import("@mariozechner/pi-coding-agent");
const models: ModelCatalogEntry[] = [];
try { try {
// IMPORTANT: keep the dynamic import *inside* the try/catch.
// If this fails once (e.g. during a pnpm install that temporarily swaps node_modules),
// we must not poison the cache with a rejected promise (otherwise all channel handlers
// will keep failing until restart).
const piSdk = await import("@mariozechner/pi-coding-agent");
const models: ModelCatalogEntry[] = [];
const cfg = params?.config ?? loadConfig(); const cfg = params?.config ?? loadConfig();
await ensureClawdbotModelsJson(cfg); await ensureClawdbotModelsJson(cfg);
const agentDir = resolveClawdbotAgentDir(); const agentDir = resolveClawdbotAgentDir();
@@ -66,16 +70,17 @@ export async function loadModelCatalog(params?: {
// If we found nothing, don't cache this result so we can try again. // If we found nothing, don't cache this result so we can try again.
modelCatalogPromise = null; modelCatalogPromise = null;
} }
} catch {
// Leave models empty on discovery errors and don't cache.
modelCatalogPromise = null;
}
return models.sort((a, b) => { return models.sort((a, b) => {
const p = a.provider.localeCompare(b.provider); const p = a.provider.localeCompare(b.provider);
if (p !== 0) return p; if (p !== 0) return p;
return a.name.localeCompare(b.name); return a.name.localeCompare(b.name);
}); });
} catch {
// Don't poison the cache on transient dependency/filesystem issues.
modelCatalogPromise = null;
return [];
}
})(); })();
return modelCatalogPromise; return modelCatalogPromise;