fix(signal): surface signal-cli failures as errors
This commit is contained in:
@@ -16,6 +16,15 @@ describe("classifySignalCliLogLine", () => {
|
|||||||
expect(classifySignalCliLogLine("ERROR Something")).toBe("error");
|
expect(classifySignalCliLogLine("ERROR Something")).toBe("error");
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("treats failures without explicit severity as error", () => {
|
||||||
|
expect(
|
||||||
|
classifySignalCliLogLine("Failed to initialize HTTP Server - oops"),
|
||||||
|
).toBe("error");
|
||||||
|
expect(classifySignalCliLogLine('Exception in thread "main"')).toBe(
|
||||||
|
"error",
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
it("returns null for empty lines", () => {
|
it("returns null for empty lines", () => {
|
||||||
expect(classifySignalCliLogLine("")).toBe(null);
|
expect(classifySignalCliLogLine("")).toBe(null);
|
||||||
expect(classifySignalCliLogLine(" ")).toBe(null);
|
expect(classifySignalCliLogLine(" ")).toBe(null);
|
||||||
|
|||||||
@@ -23,6 +23,8 @@ export function classifySignalCliLogLine(line: string): "log" | "error" | null {
|
|||||||
if (!trimmed) return null;
|
if (!trimmed) return null;
|
||||||
// signal-cli commonly writes all logs to stderr; treat severity explicitly.
|
// signal-cli commonly writes all logs to stderr; treat severity explicitly.
|
||||||
if (/\b(ERROR|WARN|WARNING)\b/.test(trimmed)) return "error";
|
if (/\b(ERROR|WARN|WARNING)\b/.test(trimmed)) return "error";
|
||||||
|
// Some signal-cli failures are not tagged with WARN/ERROR but should still be surfaced loudly.
|
||||||
|
if (/\b(FAILED|SEVERE|EXCEPTION)\b/i.test(trimmed)) return "error";
|
||||||
return "log";
|
return "log";
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user