fix: handle object-format capabilities in normalizeCapabilities
When capabilities is configured as an object (e.g., { inlineButtons: "dm" })
instead of a string array, normalizeCapabilities() would crash with
"capabilities.map is not a function".
This can occur when using the new Telegram inline buttons scoping feature:
channels.telegram.capabilities.inlineButtons = "dm"
The fix adds an Array.isArray() guard to return undefined for non-array
capabilities, allowing channel-specific handlers (like
resolveTelegramInlineButtonsScope) to process the object format separately.
Fixes crash when using object-format TelegramCapabilitiesConfig.
This commit is contained in:
@@ -105,6 +105,26 @@ describe("resolveChannelCapabilities", () => {
|
|||||||
}),
|
}),
|
||||||
).toEqual(["polls"]);
|
).toEqual(["polls"]);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("handles object-format capabilities gracefully (e.g., { inlineButtons: 'dm' })", () => {
|
||||||
|
const cfg = {
|
||||||
|
channels: {
|
||||||
|
telegram: {
|
||||||
|
// Object format - used for granular control like inlineButtons scope.
|
||||||
|
// Channel-specific handlers (resolveTelegramInlineButtonsScope) process these.
|
||||||
|
capabilities: { inlineButtons: "dm" },
|
||||||
|
},
|
||||||
|
},
|
||||||
|
};
|
||||||
|
|
||||||
|
// Should return undefined (not crash), allowing channel-specific handlers to process it.
|
||||||
|
expect(
|
||||||
|
resolveChannelCapabilities({
|
||||||
|
cfg: cfg as ClawdbotConfig,
|
||||||
|
channel: "telegram",
|
||||||
|
}),
|
||||||
|
).toBeUndefined();
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
const createRegistry = (channels: PluginRegistry["channels"]): PluginRegistry => ({
|
const createRegistry = (channels: PluginRegistry["channels"]): PluginRegistry => ({
|
||||||
|
|||||||
@@ -4,6 +4,9 @@ import type { ClawdbotConfig } from "./config.js";
|
|||||||
|
|
||||||
function normalizeCapabilities(capabilities: string[] | undefined): string[] | undefined {
|
function normalizeCapabilities(capabilities: string[] | undefined): string[] | undefined {
|
||||||
if (!capabilities) return undefined;
|
if (!capabilities) return undefined;
|
||||||
|
// Handle object-format capabilities (e.g., { inlineButtons: "dm" }) gracefully.
|
||||||
|
// Channel-specific handlers (like resolveTelegramInlineButtonsScope) process these separately.
|
||||||
|
if (!Array.isArray(capabilities)) return undefined;
|
||||||
const normalized = capabilities.map((entry) => entry.trim()).filter(Boolean);
|
const normalized = capabilities.map((entry) => entry.trim()).filter(Boolean);
|
||||||
return normalized.length > 0 ? normalized : undefined;
|
return normalized.length > 0 ? normalized : undefined;
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user