10 KiB
10 KiB
summary, read_when
| summary | read_when | ||
|---|---|---|---|
| Channel plugin refactor implementation notes (registry, status, gateway/runtime) |
|
Channel Plugins — Implementation Notes
Goal: make chat channels (iMessage, Discord, etc.) pluggable with minimal wiring and shared UX/state paths.
Architecture Overview
- Registry:
src/channels/plugins/index.tsowns the plugin list. - Channel dock:
src/channels/dock.tsowns lightweight channel metadata used by shared flows (reply, command auth, block streaming) without importing full plugins. - IDs/aliases:
src/channels/registry.tsowns stable channel ids + input aliases. - Shape:
src/channels/plugins/types.tsdefines the plugin contract. - Gateway:
src/gateway/server-channels.tsdrives start/stop + runtime snapshots via plugins. - Outbound:
src/infra/outbound/deliver.tsroutes through plugin outbound when present. - Outbound delivery loads outbound adapters on-demand via
src/channels/plugins/outbound/load.ts(avoid importing heavy channel plugins on hot paths). - Reload:
src/gateway/config-reload.tsuses pluginreload.configPrefixeslazily (avoid init cycles). - CLI:
src/commands/channels/*uses plugin list for add/remove/status/list. - Protocol:
src/gateway/protocol/schema.tskeepschannels.statusschema-light (maps keyed by channel id).
Plugin Contract (high-level)
Each ChannelPlugin bundles:
meta: id/labels/docs/sort order.capabilities: chatTypes + optional features (polls, media, nativeCommands, etc.).config: list/resolve/default/isConfigured/describeAccount + isEnabled + (un)configured reasons +resolveAllowFrom+formatAllowFrom.outbound: deliveryMode + chunker + resolveTarget (mode-aware) + sendText/sendMedia/sendPoll + pollMaxOptions.status: defaultRuntime + probe/audit/buildAccountSnapshot + buildChannelSummary + logSelfId + collectStatusIssues.gateway: startAccount/stopAccount with runtime context (getStatus/setStatus), plus optionalloginWithQrStart/loginWithQrWaitfor gateway-owned QR login flows.security: dmPolicy + allowFrom hints used bydoctor security.heartbeat: optional readiness checks + heartbeat recipient resolution when providers own targeting.auth: optional login hook used byclawdbot channels login.reload:configPrefixesthat map to hot restarts.onboarding: optional CLI onboarding adapter (wizard UI hooks per channel).agentTools: optional channel-owned agent tools (ex: QR login).
Key Integration Notes
listChannelPlugins()is the runtime source of truth for channel UX and wiring.- Avoid importing
src/channels/plugins/index.tsfrom shared modules (reply flow, command auth, sandbox explain). It’s intentionally “heavy” (channels may pull web login / monitor code). UsegetChannelDock()+normalizeChannelId()(fromsrc/channels/registry.ts) for cheap metadata, and onlygetChannelPlugin()at execution boundaries (ex:src/auto-reply/reply/route-reply.ts). - WhatsApp plugin keeps Baileys-heavy login bits behind lazy imports; cheap auth file checks live in
src/web/auth-store.ts(so outbound routing doesn’t pay Baileys import cost). routeReplydelegates sending to pluginoutboundadapters via a lazy import ofsrc/infra/outbound/deliver.ts(so adding a channel is “just implement outbound adapter”, no router switches).- Avoid static imports of channel monitors inside plugin modules. Monitors typically import the reply pipeline, which can create ESM cycles (and break Vite/Vitest SSR with TDZ errors). Prefer lazy imports inside
gateway.startAccount. - Debug cycle leaks quickly with:
npx -y madge --circular src/channels/plugins/index.ts. - Protocol v3:
channels.statusis map-based and schema-light so new channels can ship without protocol updates. DEFAULT_CHAT_CHANNELlives insrc/channels/registry.tsand is used anywhere we need a fallback delivery surface.- Channel reload rules are computed lazily to avoid static init cycles in tests.
- Signal/iMessage media size limits are resolved inside their plugins.
normalizeChannelId()handles aliases (ex:imsg,teams) so CLI and API inputs stay stable.- Gateway runtime snapshot (
getRuntimeSnapshot) is map-based:{ channels, channelAccounts }(no${id}Accountskeys). channels.statusresponse keys (v3):channelOrder: string[]channelLabels: Record<string, string>channels: Record<string, unknown>(channel summary objects, plugin-defined)channelAccounts: Record<string, ChannelAccountSnapshot[]>channelDefaultAccountId: Record<string, string>
channels.statussummary objects come fromstatus.buildChannelSummary(no per-channel branching in the handler).channels.statuswarnings flow throughstatus.collectStatusIssuesper plugin.- CLI list uses
meta.showConfiguredto decide whether to show configured state. - CLI provider options and prompt provider lists are generated from
listProviderPlugins()(avoid hardcoded arrays). - Channel selection (
resolveMessageChannelSelection) inspectsconfig.isEnabled+config.isConfiguredper plugin instead of hardcoded checks. - Pairing flows (CLI + store) use
plugin.pairing(idLabel,normalizeAllowEntry,notifyApproval) viasrc/channels/plugins/pairing.ts. - CLI channel remove/disable delegates to
config.setAccountEnabled+config.deleteAccountper plugin. - CLI channel add delegates to
plugin.setupfor account validation, naming, and config writes (no hardcoded checks). - Agent channel status entries are built from plugin config/status (
status.resolveAccountStatefor custom state labels). - Agent binding defaults use
meta.forceAccountBindingto avoid hardcoded checks. - Onboarding quickstart allowlist uses
meta.quickstartAllowFromto avoid hardcoded channel lists. resolveChannelDefaultAccountId()is the shared helper for picking default accounts fromaccountIds+ plugin config.routeReplyuses plugin outbound senders;ChannelOutboundContextsupportsreplyToId+threadIdand outbound delivery supportsabortSignalfor cooperative cancellation.- Outbound target resolution (
resolveOutboundTarget) delegates toplugin.outbound.resolveTarget(mode-aware, uses config allowlists when present). - Outbound delivery results accept
metafor channel-specific fields to avoid core type churn in new plugins. - Agent gateway routing sets
deliveryTargetModeand usesresolveOutboundTargetfor implicit fallback targets whentois missing. - Elevated tool allowlists (
tools.elevated.allowFrom) are a record keyed by channel id (no schema update needed when adding channels). - Block streaming defaults live on the plugin (
capabilities.blockStreaming,streaming.blockStreamingCoalesceDefaults) instead of hardcoded provider checks. - Channel logout routes through
channels.logoutusinggateway.logoutAccounton each plugin (clients should call the generic method). - Gateway message-channel normalization uses
src/channels/registry.tsfor cheap validation/normalization without plugin init cycles. - Group mention gating now flows through
plugin.groups.resolveRequireMention(Discord/Slack/Telegram/WhatsApp/iMessage) instead of branching in reply handlers. - Command authorization uses
config.resolveAllowFrom+config.formatAllowFrom, withcommands.enforceOwnerForCommandsandcommands.skipWhenConfigEmptydriving provider-specific behavior. - Security warnings (
doctor security) useplugin.security.resolveDmPolicy+plugin.security.collectWarnings; supplypolicyPath+allowFromPathfor accurate config hints. - Reply threading uses
plugin.threading.resolveReplyToModeandplugin.threading.allowTagsWhenOffrather than provider switches in reply helpers. - Tool auto-threading context flows through
plugin.threading.buildToolContext(e.g., Slack threadTs injection). - Messaging tool dedupe now relies on
plugin.messaging.normalizeTargetfor provider-specific target normalization. - Message tool + CLI action dispatch now use
plugin.actions.listActions+plugin.actions.handleAction; useplugin.actions.supportsActionfor dispatch-only gating when you still want fallback send/poll. - Session announce targets can opt into
meta.preferSessionLookupForAnnounceTargetwhen session keys are insufficient (e.g., WhatsApp). - Onboarding provider setup is delegated to adapter modules under
src/providers/plugins/onboarding/*, keepingsetupProvidersprovider-agnostic. - Onboarding registry now reads
plugin.onboardingfrom each provider (no standalone onboarding map). - Channel login flows (
clawdbot channels login) route throughplugin.auth.loginwhen available. clawdbot statusreportslinkProvider(derived fromstatus.buildProviderSummary().linked) instead of a hardcodedwebprovider field.- Gateway
web.login.*methods useplugin.gatewayMethodsownership to pick the provider (no hardcodednormalizeProviderId("web")in the handler).
CLI Commands (inline references)
- Add/remove channels:
clawdbot channels add <channel>/clawdbot channels remove <channel>. - Inspect channel state:
clawdbot channels list,clawdbot channels status. - Link/unlink channels:
clawdbot channels login --channel <channel>/clawdbot channels logout --channel <channel>. - Pairing approvals:
clawdbot pairing list <provider>,clawdbot pairing approve <provider> <code>.
Adding a Provider (checklist)
- Create
src/providers/plugins/<id>.tsexportingProviderPlugin. - Register in
src/providers/plugins/index.tsand updatesrc/providers/registry.ts(ids/aliases/meta) if needed. - Add a dock entry in
src/providers/dock.tsfor any shared behavior (capabilities, allowFrom format/resolve, mention stripping, threading, streaming chunk defaults). - Add
reload.configPrefixesfor hot reload when config changes. - Delegate to existing provider modules (send/probe/monitor) or create them.
- If you changed the gateway protocol: run
pnpm protocol:check(updatesdist/protocol.schema.json+apps/macos/Sources/ClawdbotProtocol/GatewayModels.swift). - Update docs/tests for any behavior changes.
Cleanup Expectations
- Keep plugin files small; move heavy logic into provider modules.
- Prefer shared helpers over V2 copies.
- Update docs when behavior/inputs change.