483fba41b9
* feat(discord): add exec approval forwarding to DMs Add support for forwarding exec approval requests to Discord DMs, allowing users to approve/deny command execution via interactive buttons. Features: - New DiscordExecApprovalHandler that connects to gateway and listens for exec.approval.requested/resolved events - Sends DMs with embeds showing command details and 3 buttons: Allow once, Always allow, Deny - Configurable via channels.discord.execApprovals with: - enabled: boolean - approvers: Discord user IDs to notify - agentFilter: only forward for specific agents - sessionFilter: only forward for matching session patterns - Updates message embed when approval is resolved or expires Also fixes exec completion routing: when async exec completes after approval, the heartbeat now uses a specialized prompt to ensure the model relays the result to the user instead of responding HEARTBEAT_OK. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat: generic exec approvals forwarding (#1621) (thanks @czekaj) --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: Peter Steinberger <steipete@gmail.com>
78 lines
1.9 KiB
TypeScript
78 lines
1.9 KiB
TypeScript
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
|
|
import type { ClawdbotConfig } from "../config/config.js";
|
|
import { createExecApprovalForwarder } from "./exec-approval-forwarder.js";
|
|
|
|
const baseRequest = {
|
|
id: "req-1",
|
|
request: {
|
|
command: "echo hello",
|
|
agentId: "main",
|
|
sessionKey: "agent:main:main",
|
|
},
|
|
createdAtMs: 1000,
|
|
expiresAtMs: 6000,
|
|
};
|
|
|
|
afterEach(() => {
|
|
vi.useRealTimers();
|
|
});
|
|
|
|
describe("exec approval forwarder", () => {
|
|
it("forwards to session target and resolves", async () => {
|
|
vi.useFakeTimers();
|
|
const deliver = vi.fn().mockResolvedValue([]);
|
|
const cfg = {
|
|
approvals: { exec: { enabled: true, mode: "session" } },
|
|
} as ClawdbotConfig;
|
|
|
|
const forwarder = createExecApprovalForwarder({
|
|
getConfig: () => cfg,
|
|
deliver,
|
|
nowMs: () => 1000,
|
|
resolveSessionTarget: () => ({ channel: "slack", to: "U1" }),
|
|
});
|
|
|
|
await forwarder.handleRequested(baseRequest);
|
|
expect(deliver).toHaveBeenCalledTimes(1);
|
|
|
|
await forwarder.handleResolved({
|
|
id: baseRequest.id,
|
|
decision: "allow-once",
|
|
resolvedBy: "slack:U1",
|
|
ts: 2000,
|
|
});
|
|
expect(deliver).toHaveBeenCalledTimes(2);
|
|
|
|
await vi.runAllTimersAsync();
|
|
expect(deliver).toHaveBeenCalledTimes(2);
|
|
});
|
|
|
|
it("forwards to explicit targets and expires", async () => {
|
|
vi.useFakeTimers();
|
|
const deliver = vi.fn().mockResolvedValue([]);
|
|
const cfg = {
|
|
approvals: {
|
|
exec: {
|
|
enabled: true,
|
|
mode: "targets",
|
|
targets: [{ channel: "telegram", to: "123" }],
|
|
},
|
|
},
|
|
} as ClawdbotConfig;
|
|
|
|
const forwarder = createExecApprovalForwarder({
|
|
getConfig: () => cfg,
|
|
deliver,
|
|
nowMs: () => 1000,
|
|
resolveSessionTarget: () => null,
|
|
});
|
|
|
|
await forwarder.handleRequested(baseRequest);
|
|
expect(deliver).toHaveBeenCalledTimes(1);
|
|
|
|
await vi.runAllTimersAsync();
|
|
expect(deliver).toHaveBeenCalledTimes(2);
|
|
});
|
|
});
|