fix(gateway): resolve local avatars to URL in HTML injection and RPC

The frontend fix alone wasn't enough because:
1. serveIndexHtml() was injecting the raw avatar filename into HTML
2. agent.identity.get RPC was returning raw filename, overwriting the
   HTML-injected value

Now both paths resolve local file avatars (*.png, *.jpg, etc.) to the
/avatar/{agentId} endpoint URL.
This commit is contained in:
Dave Lauer
2026-01-22 15:16:31 -05:00
parent 9d09a7879c
commit ffca65d15f
2 changed files with 24 additions and 2 deletions

View File

@@ -206,11 +206,22 @@ interface ServeIndexHtmlOpts {
agentId?: string;
}
function looksLikeLocalAvatarPath(value: string | undefined): boolean {
if (!value) return false;
if (/^https?:\/\//i.test(value) || /^data:image\//i.test(value)) return false;
return /\.(png|jpe?g|gif|webp|svg|ico)$/i.test(value);
}
function serveIndexHtml(res: ServerResponse, indexPath: string, opts: ServeIndexHtmlOpts) {
const { basePath, config, agentId } = opts;
const identity = config
? resolveAssistantIdentity({ cfg: config, agentId })
: DEFAULT_ASSISTANT_IDENTITY;
// Resolve local file avatars to /avatar/{agentId} URL
let avatarValue = identity.avatar;
if (looksLikeLocalAvatarPath(avatarValue) && identity.agentId) {
avatarValue = buildAvatarUrl(basePath, identity.agentId);
}
res.setHeader("Content-Type", "text/html; charset=utf-8");
res.setHeader("Cache-Control", "no-cache");
const raw = fs.readFileSync(indexPath, "utf8");
@@ -218,7 +229,7 @@ function serveIndexHtml(res: ServerResponse, indexPath: string, opts: ServeIndex
injectControlUiConfig(raw, {
basePath,
assistantName: identity.name,
assistantAvatar: identity.avatar,
assistantAvatar: avatarValue,
}),
);
}

View File

@@ -407,7 +407,18 @@ export const agentHandlers: GatewayRequestHandlers = {
}
const cfg = loadConfig();
const identity = resolveAssistantIdentity({ cfg, agentId });
respond(true, identity, undefined);
// Resolve local file avatars to /avatar/{agentId} URL
let avatarValue = identity.avatar;
if (
avatarValue &&
!/^https?:\/\//i.test(avatarValue) &&
!/^data:image\//i.test(avatarValue) &&
/\.(png|jpe?g|gif|webp|svg|ico)$/i.test(avatarValue) &&
identity.agentId
) {
avatarValue = `/avatar/${identity.agentId}`;
}
respond(true, { ...identity, avatar: avatarValue }, undefined);
},
"agent.wait": async ({ params, respond }) => {
if (!validateAgentWaitParams(params)) {